From: "Ludovic Courtès" <ludo@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 43106@debbugs.gnu.org
Subject: [bug#43106] [PATCH v3 2/2] services: childhurd: Support installing secrets from the host.
Date: Tue, 01 Sep 2020 22:54:21 +0200 [thread overview]
Message-ID: <877dtd8bgi.fsf@gnu.org> (raw)
In-Reply-To: <87sgc1d38p.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 01 Sep 2020 15:40:38 +0200")
Hi!
Jan Nieuwenhuizen <janneke@gnu.org> skribis:
> Ludovic Courtès writes:
[...]
>> Perhaps ‘hurd-vm-service-type’ should unconditionally extend (via
>> ‘service-extension’) ‘secret-service-type’, just to ensure that Hurd VMs
>> always include the secret service.
>
> Eh, hurd-vm-service lives in the host, the secret-services lives in the
> client; am I missing something? ;-)
Ah no, it’s me. :-)
> We could add a check for secret-service, possibly here
>
> (define (hurd-vm-disk-image config)
> "Return a disk-image for the Hurd according to CONFIG."
> (let ((os (hurd-vm-configuration-os config))
> (disk-size (hurd-vm-configuration-disk-size config)))
> (system-image
> (image
> (inherit hurd-disk-image)
> (size disk-size)
> (operating-system os)))))
>
> and/or insert if it it's missing...seems a bit over the top to me?
Yes, exactly. We could pass ‘os’ through
‘secret-service-operating-system’, where:
(define (secret-service-operating-system os)
(operating-system
(inherit os)
(services (cons (service secret-service-type)
(operating-system-user-services os)))))
(A similar pattern is found in ‘virtualized-operating-system’ and
‘containerized-operating-system’.)
Thanks for these patches!
Ludo’.
next prev parent reply other threads:[~2020-09-01 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 21:57 [bug#43106] [PATCH] DRAFT services: childhurd: Support for setting secrets Jan (janneke) Nieuwenhuizen
2020-08-30 13:44 ` Ludovic Courtès
2020-08-30 20:41 ` Jan Nieuwenhuizen
2020-08-31 6:39 ` [bug#43106] [PATCH v3 0/2] Secret services for the Childhurd Jan (janneke) Nieuwenhuizen
2020-08-31 6:39 ` [bug#43106] [PATCH v3 1/2] services: Add secret-service-type Jan (janneke) Nieuwenhuizen
2020-09-01 8:26 ` Ludovic Courtès
2020-08-31 6:39 ` [bug#43106] [PATCH v3 2/2] services: childhurd: Support installing secrets from the host Jan (janneke) Nieuwenhuizen
2020-08-31 15:23 ` Jan Nieuwenhuizen
2020-09-01 8:37 ` Ludovic Courtès
2020-09-01 8:50 ` [bug#43106] [PATCH v3 0/2] Secret services for the Childhurd Ludovic Courtès
2020-09-01 11:16 ` Jan Nieuwenhuizen
2020-09-01 20:45 ` Ludovic Courtès
2020-09-01 13:38 ` [bug#43106] [PATCH v3 1/2] services: Add secret-service-type Jan Nieuwenhuizen
2020-09-01 13:40 ` [bug#43106] [PATCH v3 2/2] services: childhurd: Support installing secrets from the host Jan Nieuwenhuizen
2020-09-01 14:16 ` bug#43106: " Jan Nieuwenhuizen
2020-09-01 20:54 ` Ludovic Courtès [this message]
2020-09-02 5:28 ` [bug#43106] " Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dtd8bgi.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43106@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.