[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.

[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.

[Joseph LaFreniere]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

Patch file is attached.

The repository has existed for over a year and is referred to by 
the upstream xonsh project (xon.sh), so the lack of a tagged 
release is not indicative of a lack of maturity.

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-xonsh-mode.patch --]
[-- Type: text/x-patch, Size: 1741 bytes --]

From c99c1eeb00b44b54217159e8ec0814d94bb8aa09 Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Thu, 22 Oct 2020 20:15:59 -0500
Subject: [PATCH] gnu: Add emacs-xonsh-mode.

* gnu/packages/emacs-xyz.scm (emacs-xonsh-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 818db3e4e5..4ecf0eb9e1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25191,3 +25191,28 @@ the TypeScript implementation.")
       (description "This package provides an Emacs client for the Rocket.chat
 service.")
       (license license:expat))))
+
+(define-public emacs-xonsh-mode
+  ;; There is no tagged release yet.
+  (let ((tag "0.0.0")
+        (commit "7fa581524533a9b6b770426e4445e571a69e469d")
+        (revision "0"))
+    (package
+      (name "emacs-xonsh-mode")
+      (version (git-version tag revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/seanfarley/xonsh-mode.git")
+               (commit commit)))
+         (sha256
+          (base32 "0lfi2372clkkzi4a940fwparsfhxxzb7bmysfd50n1myakgldri5"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/seanfarley/xonsh-mode")
+      (synopsis "Major mode for editing @code{xonsh} files")
+      (description
+       "This package implements a major mode for xonsh scripts. The basic
+functionality includes syntax highlight for xonsh operators.  Files with the
+.xonshrc or .xsh extension are automatically opened with this mode.")
+      (license license:gpl3+))))
-- 
2.28.0

[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.

[Nicolas Goaziou]

Hello,

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.

Thank you. Some comments follow.
> +  ;; There is no tagged release yet.
> +  (let ((tag "0.0.0")

The version is actually "O" according to the "Version" keyword in the
Elisp file, not "0.0.0".

> +        (commit "7fa581524533a9b6b770426e4445e571a69e469d")
> +        (revision "0"))
> +    (package
> +      (name "emacs-xonsh-mode")
> +      (version (git-version tag revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/seanfarley/xonsh-mode.git")
> +               (commit commit)))
> +         (sha256
> +          (base32 "0lfi2372clkkzi4a940fwparsfhxxzb7bmysfd50n1myakgldri5"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/seanfarley/xonsh-mode")
> +      (synopsis "Major mode for editing @code{xonsh} files")

  Emacs major mode for editing @file{xonshrc} files

seems slightly more accurate.

> +      (description
> +       "This package implements a major mode for xonsh scripts. The basic

Mind the two spaces after the full stop above.

> +functionality includes syntax highlight for xonsh operators.  Files with the
> +.xonshrc or .xsh extension are automatically opened with this mode.")

@file{.xonshrc} or @file{.xsh} extension

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.

[Joseph LaFreniere]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> The version is actually "O" according to the "Version" keyword 
> in the
> Elisp file, not "0.0.0".

Updated.

>   Emacs major mode for editing @file{xonshrc} files
>
> seems slightly more accurate.

I pulled in the change denoting that the package provides an 
_Emacs_ major mode.  I'm less sure about changing @code{xonsh} to 
@file{xonshrc}.  You suggestion is what the Emacs Lisp package's 
header says, but that header is slightly misleading because the 
major mode is not just for xonsh rc files but also full xonsh 
script files (.xsh).

> Mind the two spaces after the full stop above.

Updated.

> @file{.xonshrc} or @file{.xsh} extension

Updated.

> Could you send an updated patch?

Patch file is attached.  Thank you for the review!

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-xonsh-mode.patch --]
[-- Type: text/x-patch, Size: 1760 bytes --]

From 1c8450c5ef7666cd0334d52e70ed9ce962400de1 Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Thu, 22 Oct 2020 20:15:59 -0500
Subject: [PATCH] gnu: Add emacs-xonsh-mode.

* gnu/packages/emacs-xyz.scm (emacs-xonsh-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 818db3e4e5..b0c533dc22 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25191,3 +25191,29 @@ the TypeScript implementation.")
       (description "This package provides an Emacs client for the Rocket.chat
 service.")
       (license license:expat))))
+
+(define-public emacs-xonsh-mode
+  ;; There is no tagged release yet.
+  (let ((tag "0")
+        (commit "7fa581524533a9b6b770426e4445e571a69e469d")
+        (revision "0"))
+    (package
+      (name "emacs-xonsh-mode")
+      (version (git-version tag revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/seanfarley/xonsh-mode.git")
+               (commit commit)))
+         (sha256
+          (base32 "0lfi2372clkkzi4a940fwparsfhxxzb7bmysfd50n1myakgldri5"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/seanfarley/xonsh-mode")
+      (synopsis "Emacs major mode for editing @code{xonsh} files")
+      (description
+       "This package implements a major mode for xonsh scripts.  The basic
+functionality includes syntax highlight for xonsh operators.  Files with the
+@file{.xonshrc} or @file{.xsh} extension are automatically opened with this
+mode.")
+      (license license:gpl3+))))
-- 
2.28.0

[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.

[Hilton Chain via Guix-patches via]

Hello Nicolas,

It seems that you missed the updated patch (<https://issues.guix.gnu.org/44165#2>).

This patch looks good to me, and there's no update on the source side.  Can you review it later?

Thanks!

[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.

[Nicolas Goaziou]

Hello,

Hilton Chain via Guix-patches via <guix-patches@gnu.org> writes:

> Hello Nicolas,
>
> It seems that you missed the updated patch (<https://issues.guix.gnu.org/44165#2>).
>
> This patch looks good to me, and there's no update on the source side.
> Can you review it later?

Done. It indeed fell through the cracks.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou