From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +LY2AflSnV/ECAAA0tVLHw (envelope-from ) for ; Sat, 31 Oct 2020 12:05:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AKyxOPhSnV/FHgAAB5/wlQ (envelope-from ) for ; Sat, 31 Oct 2020 12:05:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7952A94051B for ; Sat, 31 Oct 2020 12:05:12 +0000 (UTC) Received: from localhost ([::1]:53100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYpd9-0006NF-96 for larch@yhetil.org; Sat, 31 Oct 2020 08:05:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYpcl-0006N6-6D for guix-devel@gnu.org; Sat, 31 Oct 2020 08:04:47 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:35937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYpcj-0005zd-5c for guix-devel@gnu.org; Sat, 31 Oct 2020 08:04:46 -0400 Received: by mail-wm1-x32e.google.com with SMTP id e2so5165271wme.1 for ; Sat, 31 Oct 2020 05:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LYsQxory8M5LaRGJtSPkpvQUZ1j0T+Etf8lv089i/oM=; b=KN3g+mIyGI/GgaDXnMmNmNbwrsdGjDUJnz1EbDoiMqS20t/RBVGdsMCSHW160Z83E4 pY2hi6g1QWDKW7mjsckuEgFUs9bVAk1iDwjoGLtn6Wj9f2lz7c7umLzYVs/z798VXgZz ASsvumKCAWezDprlTAIg673nhTR7IA4Mlh4Sg9wDGl3SCTXkCHo4lkgadNFWKucQJkRJ ZjjZmBstIwOrz9VrJZOeK5qb42ubt/lBphgT9XI0tMml7rXWlB9yGGxihdWP7H5H3mmO t/xHLqlsfWazBnYXdtetY1KylaZV3jNRciNAf/l1k657nw3o8w2KV9m72DDaiGG2BJku duxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LYsQxory8M5LaRGJtSPkpvQUZ1j0T+Etf8lv089i/oM=; b=nHZGWU6qRuU4c3WVgzCD2dquN38B7WkcnY+NQ79bvsBeRpU5+snL9fM+nEcOpMB2jH CLt7ckxNoizdgRlov3+hmbz1UqDIerk6CSR565Y7PLhtx+GQzwvHHjvcP4TJRWfQbMQP IFuh7ymLaDnEeD4BVDeb44NeP33kOcQ1A1NxKU5N5KvUwowL+sG/Mf26005SOuLmEBRU Lb+GCLjM94ai1AuNw6sGMArm2WSin18qReNsMKPx32Ya1JeLPR7gtwpDijACQHxtvQRo 7IU+IpeCspvdeHbRDgsuxs03UXNyQGdWY/jCVkNMcRGMzwH+mC+8HoDIkygXBasjU1An xwjw== X-Gm-Message-State: AOAM532psVZ2U3B/Fi40DVXh5Yw4TdgLLTw9te98Y59Caa2wRRZ9GBEE NdoVJtnnpTYfK2eZ9iqj1UYeWq2HgdzdIg== X-Google-Smtp-Source: ABdhPJz1UUxS7tpngpc60147knvXqE63IUOdWRXMoigqWMmIbc+OFAZCwOfwloZjtSqDIBALcXYGcA== X-Received: by 2002:a1c:7f97:: with SMTP id a145mr8039164wmd.160.1604145882850; Sat, 31 Oct 2020 05:04:42 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id o129sm8325410wmb.25.2020.10.31.05.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Oct 2020 05:04:41 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Marinus Savoritias Subject: Re: bug#43879: Problem with graphical installer References: <8b7e2678-d9b0-698b-7e91-2b6145b3de7f@disroot.org> <87blgynuqr.fsf@gmail.com> <363c246d-90b2-1a8d-9b7b-6092e0836cc9@disroot.org> Date: Sat, 31 Oct 2020 13:04:31 +0100 In-Reply-To: <363c246d-90b2-1a8d-9b7b-6092e0836cc9@disroot.org> (Marinus Savoritias's message of "Mon, 19 Oct 2020 21:18:14 +0200") Message-ID: <877dr64n5c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=rosen644835@gmail.com; helo=mail-wm1-x32e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, 43879@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=KN3g+mIy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: QeEmkC4TJWU/ --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi, I CC the list, as we are currently on freeze, but this might require a fix or at least a big explanation somewhere, my bad for not answering soon enough. :-( Marinus Savoritias writes: > Hi, > > The steps that I followed were: > > 1. Use guided installation using full disk with graphical installer > > 2. I selected use entire disk and not a separate /home > > 3. It gave me the warning that its going to format the disk. Testing this I think this warning may be the confusion source. "All data will be lost" doesn't include in this case the old ESP partition (the one in /boot/efi) as that one is not removed when it exists. > [...] I curiously found that the files from the previous installation > of Gentoo were there. Even though the installer said that it formatted > the disk. To clarify this I propose the attached patch. > I was using the default that the guided installation uses. I didn't > change anything there. Probably it's too late to add new options to that list, or a new selection step when the partitioning is guided asking if esp should be kept, as the tests have to be updated too. > At that point as I said I formatted the disk separately to make sure > it was properly formatted this time but the same thing happened. > > The only way I could work around the bug was by selecting the manual > partitioning instead of guided in the graphical installer. I'm throwing a guess here: did you format the root partition but not /boot/efi the second time? Happy hacking! Miguel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-installer-Report-to-the-user-the-formatted-partition.patch Content-Transfer-Encoding: quoted-printable Content-Description: list-formatted-partitions.patch From=202c7f127fbf51de89500a6310d6d1ed130587d111 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Sat, 31 Oct 2020 12:15:35 +0100 Subject: [PATCH] installer: Report to the user the formatted partitions. * gnu/installer/newt/partitions.scm (define-module): Use (ice-9 format). (draw-formatting-page): Add parameter partitions and provide the list of formatted partitions to the user. (run-partitioning-page): Provide user-partitions to draw-formatting-page. =2D-- gnu/installer/newt/partition.scm | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partitio= n.scm index 3b891d693a..bb452a4925 100644 =2D-- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -25,6 +25,7 @@ #:use-module (gnu installer newt page) #:use-module (gnu installer newt utils) #:use-module (guix i18n) + #:use-module (ice-9 format) #:use-module (ice-9 match) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) @@ -56,11 +57,17 @@ #:button-callback-procedure button-exit-action))) (car result))) =20 =2D(define (draw-formatting-page) +(define (draw-formatting-page partitions) "Draw a page asking for confirmation, and then indicating that partitions are being formatted." =2D (run-confirmation-page (G_ "We are about to format your hard disk. Al= l \ =2Dits data will be lost. Do you wish to continue?") + ;; TRANSLATORS: The ~{ and ~} format specifiers are used to iterate the = list + ;; of device names of the user partitions that will be formatted. + (run-confirmation-page (format #f (G_ "We are about to write the configu= red \ +partition table to the disk and format the partitions listed below. All i= ts \ +data will be lost. Do you wish to continue?~%~{ - ~a~%~}") + (map user-partition-file-name + (filter user-partition-need-formatti= ng? + partitions))) (G_ "Format disk?") #:exit-button-procedure button-exit-action) (draw-info-page @@ -773,7 +780,7 @@ by pressing the Exit button.~%~%"))) (user-partitions (run-page non-install-devices)) (user-partitions-with-pass (prompt-luks-passwords user-partitions)) =2D (form (draw-formatting-page))) + (form (draw-formatting-page user-partitions))) ;; Make sure the disks are not in use before proceeding to formatting. (free-parted non-install-devices) (format-user-partitions user-partitions-with-pass) =2D-=20 2.28.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+dUtAACgkQY0xuiXn6 vsJaFQwAjLHepJFDC5NNcGJn9cApFkol0lW44EAvQnEY10ySR9tffmIkGepp2vbM FN7L+A5veyrgBu4GJ0xVxYcNXtRBU8WOlZtRLfnz/EpUXj+JTM3HoiIF1ffDQP+z aH2z/AfC4GjkLkcguG2X3FfyK2FVeCDQUdAjM7v5bjQzbwy1lLt/KSNrzTSFwvlL 4nSMIc887jh+R2y28Ye8DdJAOWw6g2FUGKHFu0Aav9sRaB/FN4afoBJufrM4cO8a vB738C0gBqyssTqRhpb6mImz4ztG4EU0QMwemhlT5R2JwO48meaJVf2zxQTRlrrz fVPMTTHDD1IHA0IZlpi73P3mIkVIs3ZwsxTCtNOj1apgOYGrWVg2IVGXgN9IAkNS vw45H85GHqxNAFmffgthnSQAwLkHv6h03voWOSt+j6h6gNMsLYqmhXJkD7Wg/DD7 fh0iQIJ0pPNavYAEzOqIoEBnG0l/DaPtKMRM6Fw1RPTh0JCbsUITWHDV4NEMzntU jS+LKTOv =fcri -----END PGP SIGNATURE----- --==-=-=--