[bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.

[bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.

[Niklas Eklund]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]


This patch updates emacs-request to the latest commit on git. The reason for
updating the package is that early this year a patch was merged which allowed
emacs-request to utilize the auth-source package providing a more convenient
experience for users and package developers.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Content --]
[-- Type: text/x-patch, Size: 2702 bytes --]

From 7236dcf7c836cec8562df3d47ba8c2bc27bfdf0d Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Thu, 15 Oct 2020 22:23:58 +0200
Subject: [PATCH] gnu: emacs-request: Update to latest commit.

* gnu/packages/emacs-xyz.scm (emacs-request): Update to latest commit.
---
 gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++------------------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 09984bc704..cbdc9d4234 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6910,29 +6910,31 @@ parallel.")
     (license license:gpl3+)))
 
 (define-public emacs-request
-  (package
-    (name "emacs-request")
-    (version "0.3.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/tkf/emacs-request")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "1djywhvvb6kwdj0nd3axjvb7k2g06dzkc6hsf29w9rsk96vr8ryl"))))
-    (build-system emacs-build-system)
-    (arguments
-     `(#:tests? #f)) ; requires network access.
-    (propagated-inputs
-     `(("emacs-deferred" ,emacs-deferred)))
-    (home-page "https://github.com/tkf/emacs-request")
-    (synopsis "Package for speaking HTTP in Emacs Lisp")
-    (description "This package provides a HTTP request library with multiple
+  (let ((commit "d02d1347ffdf138cffd380cbeac62ac8732036ef")
+        (revision "0"))
+    (package
+      (name "emacs-request")
+      (version (git-version "0.3.2" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/tkf/emacs-request")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1rkpakzish2d470ca15yq3k0m1j7a2lrkvvddcyvc2rx0sncsdjs"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:tests? #f))                  ; requires network access.
+      (propagated-inputs
+       `(("emacs-deferred" ,emacs-deferred)))
+      (home-page "https://github.com/tkf/emacs-request")
+      (synopsis "Package for speaking HTTP in Emacs Lisp")
+      (description "This package provides a HTTP request library with multiple
 backends.  It supports url.el which is shipped with Emacs and the curl command
 line program.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-rudel
   (package
-- 
2.28.0

[bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.

[Nicolas Goaziou]

Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:

> This patch updates emacs-request to the latest commit on git. The reason for
> updating the package is that early this year a patch was merged which allowed
> emacs-request to utilize the auth-source package providing a more convenient
> experience for users and package developers.

Thank you.

Could you add a comment explaining the above at the top of the package
definition and send it again?

Regards,
-- 
Nicolas Goaziou

[bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.

[Niklas Eklund]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund@posteo.net> writes:
>
>> This patch updates emacs-request to the latest commit on git. The reason for
>> updating the package is that early this year a patch was merged which allowed
>> emacs-request to utilize the auth-source package providing a more convenient
>> experience for users and package developers.
>
> Thank you.
>
> Could you add a comment explaining the above at the top of the package
> definition and send it again?
>
> Regards,
> -- 
> Nicolas Goaziou

Absolutely, I wasn't sure if I were to put it in the code or not, but
now I know for the future.

Cheers,
Niklas

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-patch, Size: 1753 bytes --]

From 0feb4bd289c7bab7b82e4d2f37fc7247acda6f6e Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Wed, 30 Sep 2020 15:34:36 +0200
Subject: [PATCH v2] gnu: Add emacs-gcmh.

* gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13471f77d1..575ee25308 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1768,6 +1768,31 @@ always indented.  It reindents after every change, making it more reliable
 than @code{electric-indent-mode}.")
     (license license:gpl2+)))
 
+(define-public emacs-gcmh
+  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
+        (revision "0"))
+    (package
+      (name "emacs-gcmh")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/koral/gcmh")
+               (commit commit)))
+         (sha256
+          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
+         (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/koral/gcmh")
+      (synopsis "Emacs Garbage Collector Magic Hack")
+      (description
+       "This package enforces a sneaky @dfn{garbage collector} (GC) strategy
+to minimize GC interference with the activity.  During normal use a high GC
+threshold is set.  When idling GC is immediately triggered and a low threshold
+is set.")
+      (license license:gpl3+))))
+
 (define-public emacs-ctrlf
   (package
     (name "emacs-ctrlf")
-- 
2.28.0

[bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.

[Ludovic Courtès]

Hi,

Niklas Eklund <niklas.eklund@posteo.net> skribis:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Niklas Eklund <niklas.eklund@posteo.net> writes:
>>
>>> This patch updates emacs-request to the latest commit on git. The reason for
>>> updating the package is that early this year a patch was merged which allowed
>>> emacs-request to utilize the auth-source package providing a more convenient
>>> experience for users and package developers.
>>
>> Thank you.
>>
>> Could you add a comment explaining the above at the top of the package
>> definition and send it again?
>>
>> Regards,
>> -- 
>> Nicolas Goaziou
>
> Absolutely, I wasn't sure if I were to put it in the code or not, but
> now I know for the future.

[...]

> +(define-public emacs-gcmh
> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
> +        (revision "0"))

Looks like you forgot the comment.  :-)

Could you send an updated patch?  (Else we can do it for you.)

Thanks,
Ludo’.

[bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.

[Niklas Eklund]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
>> +(define-public emacs-gcmh
>> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
>> +        (revision "0"))
>
> Looks like you forgot the comment.  :-)
>
> Could you send an updated patch?  (Else we can do it for you.)

>
> Thanks,
> Ludo’.

Hi Ludo,

I could have sworn I updated that, must be something that I have done
wrong here :O.

I will make a new atempt, in this message attaching a new patch. If that
still fails feel free to make the change :)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: new patch --]
[-- Type: text/x-patch, Size: 2852 bytes --]

From 75bfe74c5e150b5aca294c7b51e94d63b188dbe7 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Thu, 15 Oct 2020 22:23:58 +0200
Subject: [PATCH v3] gnu: emacs-request: Update to latest commit.

* gnu/packages/emacs-xyz.scm (emacs-request): Update to latest commit.
---
 gnu/packages/emacs-xyz.scm | 46 +++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 09984bc704..e88119ea43 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6910,29 +6910,33 @@ parallel.")
     (license license:gpl3+)))
 
 (define-public emacs-request
-  (package
-    (name "emacs-request")
-    (version "0.3.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/tkf/emacs-request")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "1djywhvvb6kwdj0nd3axjvb7k2g06dzkc6hsf29w9rsk96vr8ryl"))))
-    (build-system emacs-build-system)
-    (arguments
-     `(#:tests? #f)) ; requires network access.
-    (propagated-inputs
-     `(("emacs-deferred" ,emacs-deferred)))
-    (home-page "https://github.com/tkf/emacs-request")
-    (synopsis "Package for speaking HTTP in Emacs Lisp")
-    (description "This package provides a HTTP request library with multiple
+  ;; We prefer a more recent commit that has support for auth-source,
+  ;; which makes authentication more convenient for users and maintainers.
+  (let ((commit "d02d1347ffdf138cffd380cbeac62ac8732036ef")
+        (revision "0"))
+    (package
+      (name "emacs-request")
+      (version (git-version "0.3.2" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/tkf/emacs-request")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1rkpakzish2d470ca15yq3k0m1j7a2lrkvvddcyvc2rx0sncsdjs"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:tests? #f))                  ; requires network access.
+      (propagated-inputs
+       `(("emacs-deferred" ,emacs-deferred)))
+      (home-page "https://github.com/tkf/emacs-request")
+      (synopsis "Package for speaking HTTP in Emacs Lisp")
+      (description "This package provides a HTTP request library with multiple
 backends.  It supports url.el which is shipped with Emacs and the curl command
 line program.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-rudel
   (package
-- 
2.28.0


[-- Attachment #3: Type: text/plain, Size: 16 bytes --]


Thanks,
Niklas

bug#44024: [PATCH] gnu: emacs-request: Update to latest commit.

[Nicolas Goaziou]

Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-request): Update to latest commit.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou