all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory.
@ 2020-12-18  3:34 Michael Rohleder
  2020-12-18  5:27 ` Michael Rohleder
  2021-01-12  9:12 ` Nicolas Goaziou
  0 siblings, 2 replies; 4+ messages in thread
From: Michael Rohleder @ 2020-12-18  3:34 UTC (permalink / raw)
  To: 45309

* gnu/packages/fonts.scm (font-google-roboto)[arguments]: Add phase to unpack
to a directory and ignore macosx files.
---
After commit e93ee2547ecec152f9a198ccc338c4329cc69a71 this pkg doesn't contain anything.
The difference to the version before is that the upstream zip file doesn't
contain a subfolder anymore, so this patch unpacks to one (and excludes macosx
files while at it).

Maybe the roboto-hinted.zip is better than unhinted? Idk.

 gnu/packages/fonts.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 717656d682..72e97d99ea 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -801,6 +801,15 @@ display all Unicode symbols.")
        (sha256
         (base32 "0a57f957qy49kildqx2lp2paqk9i8kkayakmrzxh39hhhmqlrxkh"))))
     (build-system font-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'unpack
+           (lambda* (#:key inputs #:allow-other-keys)
+             (invoke "unzip" (assoc-ref inputs "source")
+                     "-x" "__MACOSX/*"
+                     "-d" "roboto-unhinted")
+             #t)))))
     (home-page "https://github.com/google/roboto")
     (synopsis "The Roboto family of fonts")
     (description
-- 
2.29.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory.
  2020-12-18  3:34 [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory Michael Rohleder
@ 2020-12-18  5:27 ` Michael Rohleder
  2021-01-12  9:12 ` Nicolas Goaziou
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Rohleder @ 2020-12-18  5:27 UTC (permalink / raw)
  To: 45309

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Now that commit ec4a9cadcb2b44f86917c3ebb17c903149e42883 has reverted
this problem/bug, I'm not sure if the patch is relevant anymore.

-- 
GNU Emacs is an old-school C program emulating a 1980s Symbolics
Lisp Machine emulating an old-fashioned Motif-style Xt toolkit
emulating a 1970s text terminal emulating a 1960s teletype.
(Daniel Colascione)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory.
  2020-12-18  3:34 [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory Michael Rohleder
  2020-12-18  5:27 ` Michael Rohleder
@ 2021-01-12  9:12 ` Nicolas Goaziou
  2021-01-12  9:31   ` Michael Rohleder
  1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2021-01-12  9:12 UTC (permalink / raw)
  To: Michael Rohleder; +Cc: 45309

Hello,

Michael Rohleder <mike@rohleder.de> writes:

> After commit e93ee2547ecec152f9a198ccc338c4329cc69a71 this pkg doesn't contain anything.
> The difference to the version before is that the upstream zip file doesn't
> contain a subfolder anymore, so this patch unpacks to one (and excludes macosx
> files while at it).

Oops.

> Maybe the roboto-hinted.zip is better than unhinted? Idk.

There is no roboto-hinted.zip in release v2.138, only
roboto-unhinted.zip and roboto-android.zip. Maybe the latter would be
a better fit?

WDYT?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory.
  2021-01-12  9:12 ` Nicolas Goaziou
@ 2021-01-12  9:31   ` Michael Rohleder
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Rohleder @ 2021-01-12  9:31 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 45309

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>> Maybe the roboto-hinted.zip is better than unhinted? Idk.
>
> There is no roboto-hinted.zip in release v2.138, only
> roboto-unhinted.zip and roboto-android.zip. Maybe the latter would be
> a better fit?
>
> WDYT?

I don't know, but I guess the android.zip has the same unzipping problem
(haven't looked).

With the patch everything should be good, no?

-- 
The use of COBOL cripples the mind; its teaching should, therefore, be
regarded as a criminal offence.
		-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-12  9:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18  3:34 [bug#45309] [PATCH] gnu: font-google-roboto: Unzip fonts to a directory Michael Rohleder
2020-12-18  5:27 ` Michael Rohleder
2021-01-12  9:12 ` Nicolas Goaziou
2021-01-12  9:31   ` Michael Rohleder

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git