From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wDKLLLfADWAfFwAA0tVLHw (envelope-from ) for ; Sun, 24 Jan 2021 18:47:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MEdlKLfADWAmCwAAbx9fmQ (envelope-from ) for ; Sun, 24 Jan 2021 18:47:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 45C3594024D for ; Sun, 24 Jan 2021 18:47:19 +0000 (UTC) Received: from localhost ([::1]:49006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3kPu-0005T1-9P for larch@yhetil.org; Sun, 24 Jan 2021 13:47:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3kPe-0005Si-4k for guix-patches@gnu.org; Sun, 24 Jan 2021 13:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53942) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3kPd-0001EA-U4 for guix-patches@gnu.org; Sun, 24 Jan 2021 13:47:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3kPd-0001de-Sw for guix-patches@gnu.org; Sun, 24 Jan 2021 13:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45293] [PATCH] gnu: Add skim. Resent-From: John Soo Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 24 Jan 2021 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45293 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 <873216071@qq.com> Received: via spool by 45293-submit@debbugs.gnu.org id=B45293.16115139776247 (code B ref 45293); Sun, 24 Jan 2021 18:47:01 +0000 Received: (at 45293) by debbugs.gnu.org; 24 Jan 2021 18:46:17 +0000 Received: from localhost ([127.0.0.1]:37255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3kOv-0001ch-5H for submit@debbugs.gnu.org; Sun, 24 Jan 2021 13:46:17 -0500 Received: from mail-pl1-f175.google.com ([209.85.214.175]:42666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3kOs-0001cU-KU for 45293@debbugs.gnu.org; Sun, 24 Jan 2021 13:46:15 -0500 Received: by mail-pl1-f175.google.com with SMTP id s15so6218296plr.9 for <45293@debbugs.gnu.org>; Sun, 24 Jan 2021 10:46:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5r/f4ckGG7dGql2kH4zwV1S5ZLUVC4mHR2DQxj4aOq0=; b=uz+ESi3tSeu9LWwZQZO2mORLmy9wli9/oHLZW3lK7UIar/s1LAb6Y/UpBjBeelFTDo ufB4Wjgck+DSvVmdbJwENwWnvCvRVHPFCWUWLIfR8Q/12MKnva7cv6VhrV5+L3AuBYdF spop4jSxJ/r+YK6kuMet+FDzFtGguJLT53gOr3sTisffuC7liTo12XmMyoIOJwri57yc kcZXdII6ONypvQwxGPGbxq9zoo7mf23d9K6iX6k115VRJLL/zvwp9PNEeHmLLLfUfm4q O5WNDXRt2sXd9ye9q3m4E5d+t17x4k57Pn/0h8h0rol3UFcGvnUd4bgSlvvhokeaSjQ+ cGyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5r/f4ckGG7dGql2kH4zwV1S5ZLUVC4mHR2DQxj4aOq0=; b=AA7JM2nRk4bZUYIh9IYZzJseVcTtXVJggGmIqtjKjoTtlPUTPi27K8f/4IOcfodp6B PYXUVuguAfwKG19jnDZGb1zCA9wWXReMhWaG7wwZnZXdTH0/g1uu4ZCv/wim5pY4Akkb kxa0XhBj6N8IKfv1FFLS1Ro6r44ewVTu2uqHUYRlPz9N2DcLKCH3z4eaKIO0XpDRYSJK 95K3f1725cj1pXxsWKtLrhwcM8My8JaOIF+EyMqKRtpnFcPWRLvlb6Y7m0iHVApRIuv3 7mdmCtuvLcMaiUpnXgmj/rAYDmdZR/n87hhzyN7jB4Il6AxvCuO45LVc1JOnAlW7XLUT T7Uw== X-Gm-Message-State: AOAM530kbFcVAXoxuxLKo0UTSaHuA2FwXBLClJ8vWHWah1amFRs6S8Jw KQvO1MEpeHTRlUswXNlwADPuL2PRZaC1CA== X-Google-Smtp-Source: ABdhPJxJzsOgz5rhco7ysKTOaAR7xaT+84XREXBGcJjAPEw4rzBWk61VCFQt/1bT9g21wBboXus4yw== X-Received: by 2002:a17:90b:e15:: with SMTP id ge21mr6674600pjb.185.1611513968639; Sun, 24 Jan 2021 10:46:08 -0800 (PST) Received: from ecenter ([2600:1700:83b0:8bd0::7a8]) by smtp.gmail.com with ESMTPSA id z16sm13999813pgj.51.2021.01.24.10.46.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jan 2021 10:46:08 -0800 (PST) From: John Soo References: Date: Sun, 24 Jan 2021 10:46:07 -0800 In-Reply-To: (873216071@qq.com's message of "Thu, 17 Dec 2020 21:10:02 +0800") Message-ID: <877do2w4uo.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45293@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=asu-edu.20150623.gappssmtp.com header.s=20150623 header.b=uz+ESi3t; dmarc=fail reason="SPF not aligned (relaxed)" header.from=asu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 45C3594024D X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: GC3nucTkHJLW Hello, I made some patches for skim also. Yours look good but there are some extras not installed. In particular the manpages, vim plugins and shell completions are missing. Can you add something like the following to the #:phases part of the arguments? (modify-phases %standard-phases (add-after 'install 'install-extras (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin")) (share (string-append out "/share")) (man (string-append out "/share/man")) (vimfiles (string-append share "/vim/vimfiles/plugin")) (bash-completion (string-append share "/bash-completions/completions")) (zsh-site (string-append share "/zsh/site-functions")) (fish-vendor (string-append share "/fish/vendor-completions.d"))) ;; Binaries (for-each (lambda (binary) (install-file binary bin)) (find-files "bin")) (mkdir-p share) ;; Manpages (copy-recursively "man" man) ;; Vim plugins (mkdir-p vimfiles) (copy-recursively "plugin" vimfiles) ;; Completions (mkdir-p bash-completion) (copy-file "shell/completion.bash" (string-append bash-completion "/skim")) (copy-file "shell/key-bindings.bash" (string-append bash-completion "/skim-bindings")) (mkdir-p zsh-site) (copy-file "shell/completion.zsh" (string-append zsh-site "/_skim")) (copy-file "shell/key-bindings.zsh" (string-append zsh-site "/_skim-bindings")) (mkdir-p fish-vendor) (copy-file "shell/key-bindings.fish" (string-append fish-vendor "/skim-bindings.fish")))))) Thanks! John