From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2I+POo/04mD2VgAAgWs5BA (envelope-from ) for ; Mon, 05 Jul 2021 14:01:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0FNQNo/04mByZgAAB5/wlQ (envelope-from ) for ; Mon, 05 Jul 2021 12:01:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59E5BE278 for ; Mon, 5 Jul 2021 14:01:19 +0200 (CEST) Received: from localhost ([::1]:40744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0NHp-00065V-CJ for larch@yhetil.org; Mon, 05 Jul 2021 08:01:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0NFe-0003QU-Dx for bug-guix@gnu.org; Mon, 05 Jul 2021 07:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0NFe-0008Ri-3H for bug-guix@gnu.org; Mon, 05 Jul 2021 07:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0NFe-0005q9-3D for bug-guix@gnu.org; Mon, 05 Jul 2021 07:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#28602: Unpack fails with no error message when using a .zip source Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 05 Jul 2021 11:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28602 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: nee Received: via spool by 28602-submit@debbugs.gnu.org id=B28602.162548630922377 (code B ref 28602); Mon, 05 Jul 2021 11:59:02 +0000 Received: (at 28602) by debbugs.gnu.org; 5 Jul 2021 11:58:29 +0000 Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0NF6-0005oq-Mj for submit@debbugs.gnu.org; Mon, 05 Jul 2021 07:58:28 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:44972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0NF3-0005ny-MC for 28602@debbugs.gnu.org; Mon, 05 Jul 2021 07:58:26 -0400 Received: by mail-wm1-f44.google.com with SMTP id i2-20020a05600c3542b02902058529ea07so3426075wmq.3 for <28602@debbugs.gnu.org>; Mon, 05 Jul 2021 04:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PczEcsSE6pVtzrHa57FTuJHW8BXN4lFx3iARA8KrliY=; b=pQwnlhcagozm10627r0ztBr91gbXoh2oNfqQKP8qqKwRF6XoMcdX5iwou5Xh5o7B4c phYmCqZ/rb/fB+tYBNz2gZCLge940JUXfLVe7PWEMeYwstejZ/1z7tXlnfQ+DFKuRGIC r/B4jAAVK+sJApymbmGfMjMZcZCtn/GWTm498KO5cUhJisVFbEumxBaZzaLbloVpeIW0 Lj8qUoXqAzTxREt/M0qEKGMZSjp/aabEKr/joLqfrZL/8Fx/M6H7TjAEip2ZT4l/Q93R RTGOWoXdyrXi5ZUGwRPFT0P2rwWIZ0grNEgWO4+IW8XLH/Os8JhVR4xR1MCBun3JOwQV zWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PczEcsSE6pVtzrHa57FTuJHW8BXN4lFx3iARA8KrliY=; b=WBpv4XeVRE8v7detkJvsrhyIwrrkZ6MAgdNcAvGuyMJKidYUUUuNJ9uU+ABks8CiK3 /MjMm+dFtCvdD2BtVmomGphZ5y6XjXSoO2CA60ae239rEgOoK00jJCUuJ/sF9enu/d07 P6X1dhDIQL5so5dLd+OcLlZdmBPXmsYD9FwNdcQU7oTX1WSTgMQs7c2n6g9afAG2EKLK arVGRa/Cs4y5Z1yNxHuQONHLdKVnzTUf54LhTy3e+8DwFHuNXqLff2bMqaE5MRN1uOrG MD2dxthMd9Gdq/0MV+fdX4plhEGWwUMNjcktimUjNfzcnXNfWm1AeThE05q2SVYKKLPt juKg== X-Gm-Message-State: AOAM5320leSWo5RhRvb2zuf/S7TZwVm5EGS6RBJwN9lpTpENmEj6SxKd pTKBZa5jzW5matz409Us51Upv9gCdW0= X-Google-Smtp-Source: ABdhPJyMCH+rv4kQt2A/TMS0S/ilzcb604/BByb/CcRh4u4qNWvm5hVNlpbZJZ2eJr7ZltMfsNzlmw== X-Received: by 2002:a7b:c249:: with SMTP id b9mr14761772wmj.4.1625486300057; Mon, 05 Jul 2021 04:58:20 -0700 (PDT) Received: from pfiuh02 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id x21sm17438934wmj.6.2021.07.05.04.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 04:58:19 -0700 (PDT) From: zimoun References: <2c2ccbd7-bb47-5292-74d9-e4c7fdc2c990@cock.li> <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> Date: Mon, 05 Jul 2021 13:46:26 +0200 In-Reply-To: <7075db45-09ad-f2d7-1bd4-27f2c9755a42@cock.li> (nee@cock.li's message of "Mon, 9 Oct 2017 23:00:29 +0200") Message-ID: <877di52dbh.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 28602@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625486479; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PczEcsSE6pVtzrHa57FTuJHW8BXN4lFx3iARA8KrliY=; b=KezalPPSDUBhzFSu9xkzVjMHIKikOdGpEqHCE/myLekIYqyVLfD4/Zfvv1J4JaY6FVUTe/ HExDcJ+0Rqu2pMG/sFpSnFyti/bXzo4nOASx6FJR486ymduHSEbUIH5fy1D0m6JMMhs0I6 D/mxixW7b9CHVXjkGy9haExxtLN4txrQgaMgHbgcj+0gr8+Ad1f9lyJ8OLtyRRsmSYa9Cv DV9NMLS/K/rNzeMVHrPGtS8PzY/06n/dSwLnFANkbQJBoQo0A4gqRQYDQBM60mAaY9E2W3 S6Nit6CdnVP4mE3Grtal16goPGbA57fm2b1GMBxGz748huVmWUz1PfbISoMU+A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625486479; a=rsa-sha256; cv=none; b=KKGl4RySp3kFkoFbm9BFAT7Y4jJF/XAUuC0J9feccHc5MvKfOfDL4cVo9Lk4ZDtHs9i7Kw J7vwDmVrYw2mJdrH/Z15mL1jBJ2XsbNC3amm1GmE/+JvraYBmjtLWvWj6wFtKCSwCb39Kk v7KP7giyJCxoTN9m8RwklxqYlvRm/G/dsT5+ZxQIJPTp7ZKJNCOVFfffSTBXgYDDgIs65d bdTNWWewqjPgJ4Ce0pVIFxfbBIZ+az+jpfjzT0Z3uv/1l1+wMy6ca5DUKo/9bncjQB89H+ BIdVITC6kN2Cr0FZW/QBCEdV1byfLlxLwEh4/Mo9urNXnFZeagNXs8o3g4bcrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=pQwnlhca; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=pQwnlhca; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 59E5BE278 X-Spam-Score: -1.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: bESSLFAJ7O2P Hi, Thanks for the patch and sorry for the delay. On Mon, 09 Oct 2017 at 23:00, nee wrote: > Hello here is a patch to fix this bug. It changes the gnu-build-system, > so the hashes of almost all packages will also change. I guess > core-updates is the right branch for this. > >>>From 089b9741a734f0682a671df6c0c36dfefcbd407c Mon Sep 17 00:00:00 2001 > From: nee > Date: Mon, 9 Oct 2017 22:49:12 +0200 > Subject: [PATCH] guix: gnu-build-system: warn about missing unzip input during > unpack. > > --- > guix/build/gnu-build-system.scm | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm > index e37b75140..c16d15964 100644 > --- a/guix/build/gnu-build-system.scm > +++ b/guix/build/gnu-build-system.scm > @@ -67,6 +67,21 @@ See https://reproducible-builds.org/specs/source-date-epoch/." > #f > dir)) > > +(define (unzip filepath) > + "Unzip archive file. > +Warn the user when unzip fails and the executable is not present." > + (define exit-code (system* "unzip" filepath)) > + (define program-not-found-code 32512) > + (cond ((zero? exit-code) #t) > + ((eqv? exit-code program-not-found-code) > + (format (current-error-port) > + "warning: Archive with .zip suffix failed to unpack. > +Please add unzip as native-input to the package, > +e.g. (native-inputs `((\"unzip\" ,unzip)))") > + (newline (current-error-port)) > + #f) > + (else #f))) Give a look at 'invoke' from (guix build utils). > (define* (set-paths #:key target inputs native-inputs > (search-paths '()) (native-search-paths '()) > #:allow-other-keys) > @@ -154,7 +169,7 @@ working directory." > #:keep-mtime? #t) > #t) > (and (if (string-suffix? ".zip" source) > - (zero? (system* "unzip" source)) > + (unzip source) > (zero? (system* "tar" "xvf" source))) > (chdir (first-subdirectory "."))))) After 9a87649c863e1ff8b073b356875eb05eecedbcf7, this part uses 'invoke'. Instead of your 'unzip', the exception raised by 'invoke' should be catched and then should trigger the hint message. WDYT? All the best, simon