From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +FLII3O4WmEyFAEAgWs5BA (envelope-from ) for ; Mon, 04 Oct 2021 10:16:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IG95H3O4WmEIMQAA1q6Kng (envelope-from ) for ; Mon, 04 Oct 2021 08:16:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35B892AEDC for ; Mon, 4 Oct 2021 10:16:51 +0200 (CEST) Received: from localhost ([::1]:44600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXJ9V-0006Xc-5E for larch@yhetil.org; Mon, 04 Oct 2021 04:16:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXJ2w-0003WZ-EE for guix-patches@gnu.org; Mon, 04 Oct 2021 04:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXJ2w-0007K1-0e for guix-patches@gnu.org; Mon, 04 Oct 2021 04:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXJ2v-0007MB-S4 for guix-patches@gnu.org; Mon, 04 Oct 2021 04:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50960] [PATCH 10/10] shell: Maintain a profile cache. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Oct 2021 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 50960@debbugs.gnu.org Received: via spool by 50960-submit@debbugs.gnu.org id=B50960.163333494628209 (code B ref 50960); Mon, 04 Oct 2021 08:10:01 +0000 Received: (at 50960) by debbugs.gnu.org; 4 Oct 2021 08:09:06 +0000 Received: from localhost ([127.0.0.1]:35563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXJ22-0007Ku-4r for submit@debbugs.gnu.org; Mon, 04 Oct 2021 04:09:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXJ20-0007KR-Cl for 50960@debbugs.gnu.org; Mon, 04 Oct 2021 04:09:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43824) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXJ1u-0006W4-TD; Mon, 04 Oct 2021 04:08:58 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60524 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXJ1t-0002PF-8t; Mon, 04 Oct 2021 04:08:58 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211002102240.27815-1-ludo@gnu.org> <20211002102240.27815-10-ludo@gnu.org> <6c199526d88150c31461e3b7f9e76909217e658c.camel@telenet.be> <87ee93y0n9.fsf@gnu.org> <7c07bacb08ead4ee3f36b7ff034d3eff82a814ab.camel@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 04 Oct 2021 10:08:55 +0200 In-Reply-To: <7c07bacb08ead4ee3f36b7ff034d3eff82a814ab.camel@telenet.be> (Maxime Devos's message of "Sat, 02 Oct 2021 16:22:42 +0200") Message-ID: <877dettdns.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633335411; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=1Eg3Qu07PVTktetbifx/VcCFTeD6rzx40GiSl++157M=; b=VPBreRrjVl6MPfHnodVtDTw1JucG4PSSnqsnoCK/EPjmsSdWfeZ6g5t2tu3wNEGfb4g0Bp rB6xIjz7UUDkyi1nZ2rWZ3uU84O626xZsZWUmPOiyURFfKaexVsbTX4+mudIHiNbXjDPCZ tQvj9bwdSKhBtSiXR/ptKBIUsASNZRio6CJD55HlywCCXQSVzV/qj4l/e+HfyCTfohyE4m gJKZpLt+0XBHB3ApPHfGYqeGowxhfJHWlrzJql1FUFxC03DjTBHDi2Fx5WVJIHmxBoIAIo 5OzTc3ajKc7pMlSZytJtwOqLRQ28nqcIabuJsVmZJ+CUd3MRrZNB0qgEGnA8Eg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633335411; a=rsa-sha256; cv=none; b=ZkBZFimLov4WwVY5+twg5SjFQJfClPTE4FvlNSUZhbsiz/HzHqwdklcqPptJA0rzManUI2 GM4df9kxeB+OKlmpDWIRQvwpFUBXncq38OGFVb6LHMTOYifvCJapSda4PatYS+0P3OEwfA 67mx4v9ESounpVIeKOk3W4JNRMLDxHbi6QdLlM52LpY40cHYRXcmV+JbohjmD9NS0jBKp1 hiqP5elmxdekT2OVRNl2PB2mP52n6unmyJwjzmzCO8tlwHu/AozDROF5G4b/CqJnX3PXSn qKyJLIwk+4OPSExMbCfjrNfiwu96CiLZYU46T5SYB8G8V0DfVwSPDC0NSnNUEA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 35B892AEDC X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: bnV7DwzQxxpT Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op za 02-10-2021 om 16:14 [+0200]: >> > Why only use the 'basename' of a file name instead of the full name? >> > (Consider the case where a user has multiple "guix.scm" or "manifest.s= cm".) >> > This turns out to be unproblematic, because stat:dev and stat:ino is i= ncluded >> > as well, though including (a part of) the file name is superfluous bec= ause >> > stat:dev and stat:ino are included. >> >=20 >> > Could you document the rationale for including the file name, and why = only >> > the basename is included instead of the full file name? >>=20 >> Actually it=E2=80=99s probably not useful to include the file (base)name= . I >> think initially I thought about distinguishing between guix.scm and >> manifest.scm, since they return different kinds of objects, but dev/ino >> is probably enough. WDYT? > > Looking at https://lwn.net/Articles/866582/, it appears when BTRFS and NF= S are > combined, it is possible for two dev/ino pairs to be the same for differe= nt files. > It appears to be considered a bug but non-trivial to fix. Thus, dev/ino = apparently > is not always sufficient, so it may be reasonable to include the file nam= e. > > I would include the full file name, because the basename is often rather = generic > ("guix.scm", "manifest.scm"), though this depends on the habits of the us= er. OK, that makes sense to me, let=E2=80=99s do that. Ludo=E2=80=99.