From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 53472@debbugs.gnu.org
Cc: paren@disroot.org
Subject: [bug#53472] [PATCH v4] gnu: Add emacs-nim-mode
Date: Fri, 28 Jan 2022 08:55:26 +0100 [thread overview]
Message-ID: <877dakxpjl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20220124201247.30159-1-paren@disroot.org> (guix-patches@gnu.org's message of "Mon, 24 Jan 2022 20:12:47 +0000")
Hello,
"(unmatched-parenthesis via Guix-patches" via <guix-patches@gnu.org>
writes:
> * gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.
Thank you.
You add both emacs-nim-mode and emacs-commenter. Could you split the
patch into two parts?
> + (uri (string-append "https://github.com/yuutayamada/commenter/archive/refs/tags/v" version ".tar.gz"))
These URI are not stable. You should use git-fetch with commit
(string-append "v" version) instead.
> + (sha256
> + (base32 "1n9m8f4gflb0c3nh98nkmsqzscyf5d1p1gcz8apskkmf7z0z0q2j"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/yuutayamada/commenter")
> + (synopsis "Allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")
The synopsis is too long:
"Set both single- and multi-line comment variables in Emacs"
> + (description "This package allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")
I suggest to drop the "etc." since there is "like" before.
"This Emacs package sets both single- and multi-line comment variables like @code{comment-start} or @code{comment-end}."
> +(define-public emacs-nim-mode
> + (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
> + (revision "0"))
Since you're not using a tagged commit, could you put a comment above
the let binding explaining why?
> + (synopsis "Major mode for editing Nim source code")
I would add "Emacs": "Emacs major mode for editing Nim source code"
> + (description "This package provides major modes for Nim:
> ++@itemize
> ++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
> ++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
> ++@item File outline by procedures
> ++@item Indentation and line breaking (alpha)
> ++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
> ++@end itemize")
I suggest:
This package includes major modes for Nim. In particular, it provides
syntax highlighting for Nim code, Nimble configuration files, and
@file{nim.cfg}, outlining features, a dedicated compilation command,
indentation and line breaking.
It also implements integration with @code{nimsuggest}, the Nim linting
and completion server, although this is currently unstable.
> + (license license:gpl3+))))
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-01-28 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 13:38 [bug#53472] [PATCH] gnu: Add emacs-nim-mode (unmatched-parenthesis via Guix-patches via
2022-01-23 16:21 ` Maxime Devos
2022-01-24 18:30 ` paren--- via Guix-patches via
2022-01-24 18:40 ` [bug#53472] [PATCH v2] " (unmatched-parenthesis via Guix-patches via
2022-01-24 19:00 ` [bug#53472] [PATCH v3] " (unmatched-parenthesis via Guix-patches via
2022-01-24 20:12 ` [bug#53472] [PATCH v4] " (unmatched-parenthesis via Guix-patches via
2022-01-28 7:55 ` Nicolas Goaziou [this message]
2022-03-07 20:51 ` [bug#53472] [PATCH] " Ludovic Courtès
2022-09-25 21:03 ` bug#53472: " Björn Höfling
2022-09-26 6:33 ` [bug#53472] " ( via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dakxpjl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53472@debbugs.gnu.org \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.