From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WCINDzCl/WEbSAAAgWs5BA (envelope-from ) for ; Fri, 04 Feb 2022 23:14:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2CLuBzCl/WFHIAAAG6o9tA (envelope-from ) for ; Fri, 04 Feb 2022 23:14:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BADFC9470 for ; Fri, 4 Feb 2022 23:14:07 +0100 (CET) Received: from localhost ([::1]:46282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nG6qE-0005HQ-UR for larch@yhetil.org; Fri, 04 Feb 2022 17:14:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nG6nG-0003J6-VP for guix-patches@gnu.org; Fri, 04 Feb 2022 17:11:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nG6nF-0004jR-Rd for guix-patches@gnu.org; Fri, 04 Feb 2022 17:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nG6nF-0006lv-MO for guix-patches@gnu.org; Fri, 04 Feb 2022 17:11:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53468] [RFC PATCH] gnu: linux-pam: Change path to unix_chkpwd helper. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Feb 2022 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53468 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 53468@debbugs.gnu.org Received: via spool by 53468-submit@debbugs.gnu.org id=B53468.164401265426018 (code B ref 53468); Fri, 04 Feb 2022 22:11:01 +0000 Received: (at 53468) by debbugs.gnu.org; 4 Feb 2022 22:10:54 +0000 Received: from localhost ([127.0.0.1]:33095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nG6n4-0006lW-RO for submit@debbugs.gnu.org; Fri, 04 Feb 2022 17:10:54 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nG6n3-0006lJ-PF for 53468@debbugs.gnu.org; Fri, 04 Feb 2022 17:10:50 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4E8643D5; Fri, 4 Feb 2022 23:10:43 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wR0TIPqr86VQ; Fri, 4 Feb 2022 23:10:42 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 5EBAB2FD; Fri, 4 Feb 2022 23:10:42 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87tudu38yz.fsf@trop.in> <87sftetuhg.fsf@trop.in> Date: Fri, 04 Feb 2022 23:10:41 +0100 In-Reply-To: <87sftetuhg.fsf@trop.in> (Andrew Tropin's message of "Sun, 23 Jan 2022 17:08:43 +0300") Message-ID: <877daamgf2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 4E8643D5 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644012847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=dRLfSO/46N8itmH8hQfIGAPH3wugyfFd5DvfZAyJgi4=; b=FSldpPMw2yrvmaJAFaGtbaAAhLiJNNEfEwVRz+D531vjIm3eggcQHJO61Sxz87li+u8Kt5 ClLkrNI3UOK6AubN7vmuhvlZmuONIe/dQRR4SgZJxF4uVL4Svp0bNqpT9Xm4fOt0eqPhFJ 097Ab/Feox3je/rdJax3vYK/djBAksnGM72G3RVurn1ZRN1Pc4FwXIZsEVSFjCoKOcO3WQ hXi242H5b5/e7nAf93dA86u0wjYvHJ54+c8DqeJlzeH9RKG7q3ZtQ1qnFbcmQKT2XM/od5 fSE4lEZOQLSHflekYnwobY3GTEbRh6R/ic4d5X/IOYJfy80z92RBK1qNSb52bA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644012847; a=rsa-sha256; cv=none; b=JyW/eGd0TVUaGkhUsHOCLiXdl8N3pCKTuU5oMGqPgLzCJi2QqLKqX0dZ9ZGHqI77Lu1DfE NudSHUJrDVkDpyKTuQ8PfRw75lRW/uXVi1l+kQhh15ry7NYh6Jz2CCsG8fTpK4ZQGKjtL1 5FnPhg1POR1sB1DIGrj2svt6HwesCzyLNAUFNo/EXX0veqPYtoMPoI3TBd4OR+3tTl551R q9tFSXToAtd/X1PB2Io4izWHI56AelMceGugawzRPFZZn9CyghnuSOhDi85nXMwr28qSMn XJeRNmQU/Y+J7pxPr1W+2JNFvt1yp8z0BfoTodwjCPsH3eiJjrQXeC6sMdHYtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BADFC9470 X-Spam-Score: -4.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: Pq9En+ox4PnZ Hi! Andrew Tropin skribis: > From ad876e5b134072601fa97d82a39b320a269f34a5 Mon Sep 17 00:00:00 2001 > From: Andrew Tropin > Date: Thu, 13 Jan 2022 21:41:58 +0300 > Subject: [RFC PATCH v2] gnu: linux-pam: Change path to unix_chkpwd helper. > > * gnu/packages/patches/change-path-to-unix_chkpwd.patch: New file > * gnu/packages/linux.scm (linux-pam): Add patch. > * gnu/system/pam.scm (pam-root-service-type): Add unix_chkpwd to setuid > binaries. [...] > + DIAG_PUSH_IGNORE_CAST_QUAL; > +- execve(CHKPWD_HELPER, (char *const *) args, envp); > ++ execve("/run/setuid-programs/unix_chkpwd", (char *const *) args, en= vp); > + DIAG_POP_IGNORE_CAST_QUAL; Looks reasonable to me. However, could you change the CHKPWD_HELPER macro definition in the Makefile template, as you suggested, instead of patching the file? Thanks! Ludo=E2=80=99.