From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +IitJrnnPGLiFwAAgWs5BA (envelope-from ) for ; Thu, 24 Mar 2022 22:50:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qMRWI7nnPGKVYgEAauVa8A (envelope-from ) for ; Thu, 24 Mar 2022 22:50:49 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A539160 for ; Thu, 24 Mar 2022 22:50:49 +0100 (CET) Received: from localhost ([::1]:54780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXVM0-00079f-J7 for larch@yhetil.org; Thu, 24 Mar 2022 17:50:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXVLm-00079S-6m for guix-devel@gnu.org; Thu, 24 Mar 2022 17:50:34 -0400 Received: from [2001:470:142:3::e] (port=52278 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXVLl-0001Kf-U9; Thu, 24 Mar 2022 17:50:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AC8Mc8rdHNvUPVJtWO9NsldxgJuCQOhOLlMFg9UfObo=; b=Ts+Q2Pn99URiZYD6J5Lu HWTJUjdCfjj7SiWPcLMWlBn8eob9wYTzR2a+Kkenj6Gqvx9FE9KtUj9WPMFEgUd+chIx2UMLqYDBb aBzWhRzuaZv9BAaKGA86UO8xFenvPQik7FfAYXSr6/YgNVuXO40qizd11EGGJ/4B/wOXFigeSiclC NZoh2SKEBQ4XoiEas2xENJ0141ApUdmjrsBfMC7U4NOTr8qo4rU2QH7k2y2nE3r+BFbPsyFbBEQ6T Rcw4iOs1U/XTZoHD6XWC+8qBt0h4JtfLagfL83ntdup107FnEa+sVTcw/hoNd+ai/ieZMYjASsEfn LmMl96hJGgjlMA==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51162 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXVLl-00024V-6G; Thu, 24 Mar 2022 17:50:33 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Skyler via "Development of GNU Guix and the GNU System distribution." Subject: Re: Fixing xen build References: <5Kp9uY-wxUeedRyLF-De7KTRCrd10fXSb8slRzO95xC5lxmVH99idmHlEVGMG0B8L1Bp1E5O_I3hsraQvvgH-82FC53mX-7sjTwQBbfIu2A=@protonmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Germinal an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 24 Mar 2022 22:50:30 +0100 In-Reply-To: <5Kp9uY-wxUeedRyLF-De7KTRCrd10fXSb8slRzO95xC5lxmVH99idmHlEVGMG0B8L1Bp1E5O_I3hsraQvvgH-82FC53mX-7sjTwQBbfIu2A=@protonmail.com> (Skyler via's message of "Sun, 20 Mar 2022 18:12:05 +0000") Message-ID: <877d8j9g0p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Skyler Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648158649; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=AC8Mc8rdHNvUPVJtWO9NsldxgJuCQOhOLlMFg9UfObo=; b=swNtOCZMj6+GTv9wxLQHFPzdLlJWOm5vcb1APUhSRhusurLg5skZMwfxoEmRNA5RuvY+oK Zqm418KzlPwEFKnuTERqaxO6EDqoUcPKW+OZ4i81489LCYC3EZ1xRorYxY50jR+OrMCD2u Dz/pflHzfKpQQv75y/US7/SM7kOyOgzTXoML4P3U9GQY6KUpb+BUvo333kZwB5t6iuFhr0 AXDdaLwTdCUGdqY0//L2RYk4LHKpZieQencvAMLoRi3795W+wFzWwUpdnXQcph6bjBarKe tdNXnWlQUHD8rAdawimnhF8ecup3Kd0PIToxp8JH02tuXUQIbxgCBpPkkIoINw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648158649; a=rsa-sha256; cv=none; b=srsqsfH3c8fMOEnF/hJGdczORclEkhZG1lxwG+vPXRF0mqgZcbOaknj1h8RDQ+ibtWzbl5 ElJ97Q/qznoUdxdZRPDXoODQPFx233ZcNnKoM8lOAn0E4DnoDZXdvBzc4PlbBinedaVXg7 oniyKChOQfXG+rxZSXXp/RQsqq/cAuG235tYBFLpMhSeaEs/MI7fMbkHoSebP+WnX7DHxv D3YaFEwI96ZzPEZQ8sUkT5XQr+m8wN4ryBr5jPhKPzALDbX421Nsn0XnH64VC5xG3XaUHE yAKO0bKhhZiWTUi2ZQbSdp+jmuvkpNouJyl/akwQdhc3lQ2yglrzA5wC7pp3Fw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=Ts+Q2Pn9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.29 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=Ts+Q2Pn9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5A539160 X-Spam-Score: -5.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3mhSNSPyBhrw Hi Skyler, Skyler via "Development of GNU Guix and the GNU System distribution." skribis: > Xen currently does not build on x86_64-linux (http://ci.guix.gnu.org/sear= ch?query=3Dxen+system:x86_64-linux). It will build if all instances of .not= e.gnu.build-id are quoted in > xen/arch/x86/xen.lds.S. This is because of the hyphen in the symbol in th= e argument to ADDR. I tested this by placing the following into a file name= d xen.scm and running guix build -f > xen.scm: I added this to the =E2=80=98patch=E2=80=99 phase of =E2=80=98xen=E2=80=99 = and can confirm that it solves the problem (will push shortly). > (define (transform-keyword-value search-key transformer input output) > (let ((next-key (first input)) > (next-value (second input)) > (remaining (drop input 2))) > (if (eq? search-key next-key) > (append (list search-key (transformer next-value)) remaining outp= ut) > (transform-keyword-value search-key transformer remaining (cons* = next-key next-value output))))) You can use =E2=80=98substitute-keyword-arguments=E2=80=99 from (guix utils= ) to do that (unfortunately undocumented right now). > I'm not sure if this should be reported elsewhere. It might be that it's = intended that symbols with hyphens need to be quoted when used in numeric e= xpressions (which would make sense, it > could be confused with subtraction) in which case Xen's script needs to b= e updated. It might be that ld is supposed to be able to understand that it= 's part of the symbol, in which case > there's a bug in ld. But neither makes sense to me. Xen's package definit= ion (including the source form) has not changed since the successful builds= in December, so it worked before. Quoting > the symbol seems reasonable based on how other languages behave, but .not= e.gnu.build-id seems like a standard practice based on some searches, and i= t's mentioned in ld's man page, so I would > expect it to work easily. If the hyphen was going to cause issues, would = the standard practice not use an underscore? I don't understand enough to k= now where else this should be reported, > but the above code fixes the guix build which is what I care about most. I=E2=80=99m not sure exactly where the problem is, but I=E2=80=99m glad you= found a fix. :-) Hopefully we can eventually get rid of this hack. Thanks! Ludo=E2=80=99.