From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AAZFHkqyXWKF6QAAbAwnHQ (envelope-from ) for ; Mon, 18 Apr 2022 20:47:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uLdTHkqyXWLPFAAA9RJhRA (envelope-from ) for ; Mon, 18 Apr 2022 20:47:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 273AD24583 for ; Mon, 18 Apr 2022 20:47:37 +0200 (CEST) Received: from localhost ([::1]:32916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngWPQ-0001lh-Hs for larch@yhetil.org; Mon, 18 Apr 2022 14:47:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngWOs-0001lS-Nk for guix-patches@gnu.org; Mon, 18 Apr 2022 14:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngWOs-0008CV-CX for guix-patches@gnu.org; Mon, 18 Apr 2022 14:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngWOs-0007E9-8A for guix-patches@gnu.org; Mon, 18 Apr 2022 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55005] [PATCH 04/13] gnu: Add ghc-githash Resent-From: Thomas Albers Raviola Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Apr 2022 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55005 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55005@debbugs.gnu.org Received: via spool by 55005-submit@debbugs.gnu.org id=B55005.165030758727739 (code B ref 55005); Mon, 18 Apr 2022 18:47:02 +0000 Received: (at 55005) by debbugs.gnu.org; 18 Apr 2022 18:46:27 +0000 Received: from localhost ([127.0.0.1]:40767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWOI-0007DK-Oh for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:46:26 -0400 Received: from gamma.thomaslabs.org ([38.242.253.186]:53670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWOG-0007D8-Ry for 55005@debbugs.gnu.org; Mon, 18 Apr 2022 14:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; t=1650307582; bh=UphawHIDVAYMjWROEUQ0MfTssYcoID9Vk2HEAauLKDY=; h=in-reply-to:date: subject:cc:to:from:references; d=thomaslabs.org; b=ATLSf3ozSADvQ2liHvr Bg5xT0ILvlRsDAux7AGQ3nRnbOWX3O5LL/B2jq9WeDTMOJ5ppXiLkspKt5DHGJdCg+UOjr BQI0vzL99Jd4RkMrQsMb8leFa0PJAp7jBdgz7sNjZSZ1QqRIpI+EUK4/tgLRFs4K1vOsMV H93MeFN+3RKfxiVPDfi+iVuULTmUtznuVWcixWm0dihaKbZvgsxpTklGuefOT/sOdqW9Oh mUJEzd8LXnrVQATDR+iiNO1TEzyBDpOb/AfzBnPcLIeFVMnj4j/CmAVBnuazGisLpek9z/ 7YUvn7JKNWZQtLPQBypTi5iTUequ5fYUICHCLp7ORvg== Received: from alpha (ip1f13c149.dynamic.kabel-deutschland.de [31.19.193.73]) by gamma.thomaslabs.org (OpenSMTPD) with ESMTPSA id 0dc4bfd8 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 18 Apr 2022 18:46:22 +0000 (UTC) References: <20220418180957.19545-1-thomas@thomaslabs.org> <20220418180957.19545-4-thomas@thomaslabs.org> <7342b568f5f436782e8617f9e6f2450dc7b7d065.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 Date: Mon, 18 Apr 2022 20:35:11 +0200 In-reply-to: <7342b568f5f436782e8617f9e6f2450dc7b7d065.camel@telenet.be> Message-ID: <877d7mxm9u.fsf@thomaslabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thomas Albers Raviola X-ACL-Warn: , Thomas Albers Raviola via Guix-patches From: Thomas Albers Raviola via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650307658; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UphawHIDVAYMjWROEUQ0MfTssYcoID9Vk2HEAauLKDY=; b=YkhXrmfMmKJ7nHygzTgHye6aYXlSPSS3VGHWGmPLTJ57SrMGgKHn+C/mgqep7VvdznhJ4E +8JZrb3dk+vaQakcCkruvs44/Earu9Ghv2KZCBePVj3drh7mOssefI61Lh3BN1pDapnHiT Y8rMxoYGx7G7cXzZNwn1c/6qgs5DFoJxkEHLKCYENhWf+hjX842iGVvL6TXpCzqjXa4PRy JILbr/lUg8XljCB+YdTnh5ukti/roiH15Zi1JsMT3peco/2SfVjDjBD9v6ridpF2gwaBE6 qV/d34EH8TNBKtsdTiT+/2jBhcqIRgvono/JaZp+RhrNOeJrk9kIixI6J/oEpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650307658; a=rsa-sha256; cv=none; b=BSD8/pXTLLRdPzIbC9STmB3mAljJSsBcQZDlnVN7GKan5ZnDVf+BhMtsuWhruRoqjpbdoh I2zde24P8CZPRbrgwUNOgiZWm6sA+ZPj7gI0Sh+y2pzY3VwM4Sg1QcImPU/cANUi+M9XER sGvX88C4V8bQhNCZO+lBFnfdVMUIID/RxuPst8H6rnAm1LXq0Sxl6Wrhu+blpEx6/9cZ7Q URtmBHPuyx7zLnb3tJeDb6vGBy4RirAp1PZ0NrUPfr49BE6WuT9Wicfdz92Q5RJ3JDbLYo tq5iksrlPYHcKmjboTfXO1ECMeuRWl8abIcHCa4FA0+PI4V/TIOW6h76EcKpdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thomaslabs.org header.s=default header.b=ATLSf3oz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thomaslabs.org header.s=default header.b=ATLSf3oz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 273AD24583 X-Spam-Score: -3.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: Am5QUhdTKZtS Maxime Devos writes: > [[PGP Signed Part:Undecided]] > Thomas Albers via Guix-patches via schreef op ma 18-04-2022 om 20:09 > [+0200]: >> --- >> =C2=A0gnu/packages/haskell-xyz.scm | 25 +++++++++++++++++++++++++ >> =C2=A01 file changed, 25 insertions(+) > > A commit message is mising. > You're right. Not only for that package, but for all in the series. I was convinced 'git send-email' would add them automatically like it usually does. Is there a command line option for this that I am missing? >> diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm >> index 18baf7b2f8..314209f573 100644 >> --- a/gnu/packages/haskell-xyz.scm >> +++ b/gnu/packages/haskell-xyz.scm >> @@ -16179,3 +16179,28 @@ (define-public ghc-sqlite-simple >> =C2=A0=C2=A0=C2=A0=C2=A0 (description >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Mid-level SQLite client library, based o= n postgresql-simple.") >> =C2=A0=C2=A0=C2=A0=C2=A0 (license license:bsd-3))) >> + >> +(define-public ghc-githash >> +=C2=A0 (package >> +=C2=A0=C2=A0=C2=A0 (name "ghc-githash") >> +=C2=A0=C2=A0=C2=A0 (version "0.1.6.2") >> +=C2=A0=C2=A0=C2=A0 (source >> +=C2=A0=C2=A0=C2=A0=C2=A0 (origin >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method url-fetch) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (string-append >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 "https://hackage.haskell.org/package/githash/githash-" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 version >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ".tar.gz")) > > I would Put 'version' and ".tar.gz" on one line here. > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "1vkwc7j71vdrxy01vlm= 6xfp16kam7m9bnj9y3h217fzhq5mjywhz")))) >> +=C2=A0=C2=A0=C2=A0 (build-system haskell-build-system) >> +=C2=A0=C2=A0=C2=A0 (outputs '("out" "static")) > > What are the static libraries for? > I am myself no sure. They are generated in the build process, so I thought to add them. >> +=C2=A0=C2=A0=C2=A0 (arguments `(#:tests? #f)) > > Why are they disabled? > Tests attempt to write to the read-only file-system. I'll add a comment explaining this. Is there a way to correct patches without having to send all over again? Is it possible to fix the mistakes by adding more patches to the series on top of the existing ones? Greetings, Thomas