From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QIPuG3x0z2KMFgEAbAwnHQ (envelope-from ) for ; Thu, 14 Jul 2022 03:42:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SGvWG3x0z2J4eAEA9RJhRA (envelope-from ) for ; Thu, 14 Jul 2022 03:42:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BBA238BCA for ; Thu, 14 Jul 2022 03:42:19 +0200 (CEST) Received: from localhost ([::1]:51722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBnru-0006FM-RE for larch@yhetil.org; Wed, 13 Jul 2022 21:42:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBnre-0006Ef-W6 for bug-guix@gnu.org; Wed, 13 Jul 2022 21:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBnre-0007UZ-Nq for bug-guix@gnu.org; Wed, 13 Jul 2022 21:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBnre-0007mK-L1 for bug-guix@gnu.org; Wed, 13 Jul 2022 21:42:02 -0400 Subject: bug#55936: dockerd fails to start on boot Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Thu, 14 Jul 2022 01:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 55936 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Oleg Pykhalov Cc: 55936-done@debbugs.gnu.org Mail-Followup-To: 55936@debbugs.gnu.org, maxim.cournoyer@gmail.com, luciano@laratel.li Received: via spool by 55936-done@debbugs.gnu.org id=D55936.165776287629824 (code D ref 55936); Thu, 14 Jul 2022 01:42:02 +0000 Received: (at 55936-done) by debbugs.gnu.org; 14 Jul 2022 01:41:16 +0000 Received: from localhost ([127.0.0.1]:48051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBnqs-0007kx-Qj for submit@debbugs.gnu.org; Wed, 13 Jul 2022 21:41:16 -0400 Received: from mail-qv1-f41.google.com ([209.85.219.41]:34775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBnqf-0007k7-4M for 55936-done@debbugs.gnu.org; Wed, 13 Jul 2022 21:41:13 -0400 Received: by mail-qv1-f41.google.com with SMTP id mi10so473383qvb.1 for <55936-done@debbugs.gnu.org>; Wed, 13 Jul 2022 18:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HOxU/X+T6JXv9XSt9Rl34d+x67J20tZ0jFiu1OnOCT8=; b=n7iHC1brATf48gM8WU0Srz2viRx7PcZlLSzWTJ8PgpFSNsHL93yw1HUMU5se31zqBI Y+kZX4dcAuNqfPNMOx1x38GT8Y5n7uAwl0ilj5tLsyGwGjaw/Xugmau5+6/S9DWZ5WHn Vy0QAlf3nx0BYwHUMA1Rxo9JlPfOu+DeQeuKWPzXxPaC9bI7FzP5iTKQCQj8FftMZhGI 7oXKHRdXeKMu+azf3Ak+x5OKqP25DAmR3Tb057kAypLXaQlkzTVzyESssu0djeUV8Cik gYzgECdsW+Btkkbxex4DdS+btO54149sz/nBszIgl6OAdbk1N2xzjAe1AG7WQIdkm8Mx eAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HOxU/X+T6JXv9XSt9Rl34d+x67J20tZ0jFiu1OnOCT8=; b=dwfZSz3cyQk2jHRiAAVV50BsUowPHsZ6rbBZq+ro1pMUfjmznBL/hM+cKp1/sjuiRb 4K/Yel9l4HwvtmTXw2rXwlJ4/GzND/1qD63CDP5D/RSZlq5cigrEkHSerV+zhXVNTod8 ZBdxOanuK42iuYrR7fQMzN3KKdPBErPNS/+xmNdpikO8cp6+YqmlxT6feyVMseLaRAIx /5D/0sFcPnRCugqVYVQWX+z4WWVX9x7cyS+/cQV+pSwN/s7ljHXZKnEuWSs5wDlwLxFS WcYDfuNDyb5L9piNx0zm0+KunNDyTO5d/jIM4hd+P/PhIEQbFCD6V4oJePNgVNSNfBwN trcQ== X-Gm-Message-State: AJIora8QurWB4xiwia0Ne9zSt66Yb9Oso0ou6IUh0mtDelcqKVpzDBhj 9BW7dbFh50rbUiypBR+D61UEJRtWmG8pcmjl X-Google-Smtp-Source: AGRyM1uanvZ+f/grpaWv7CHMRSNGwADRr356F6ydYOKoVP07p77mgXw4pBbP2+/8/eQ7ShgN2aEkSQ== X-Received: by 2002:a05:6214:d81:b0:45a:e07e:6bcb with SMTP id e1-20020a0562140d8100b0045ae07e6bcbmr5787176qve.29.1657762855244; Wed, 13 Jul 2022 18:40:55 -0700 (PDT) Received: from hurd (dsl-10-133-49.b2b2c.ca. [72.10.133.49]) by smtp.gmail.com with ESMTPSA id ez12-20020a05622a4c8c00b0031eb0bb5c3csm374001qtb.28.2022.07.13.18.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 18:40:54 -0700 (PDT) From: Maxim Cournoyer References: <20220702104106.16997-1-go.wigust@gmail.com> <878rp1ft82.fsf@gmail.com> <87wncgyb67.fsf_-_@gmail.com> Date: Wed, 13 Jul 2022 21:40:53 -0400 In-Reply-To: <87wncgyb67.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Wed, 13 Jul 2022 17:06:56 -0400") Message-ID: <877d4g1nfe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657762940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HOxU/X+T6JXv9XSt9Rl34d+x67J20tZ0jFiu1OnOCT8=; b=sGZGPH/pl9YJQjYyEPbqf1Eel693SF9mYb665cCZVc9sW7f4Sg3eLv0nhqN83II+q+uKSx vprwvzLkES5M+VOK21hLDv0H4JKonbdEpjlddqWYfImLYXOC8c3IhWE36fqIIkjz3mI19k 7Gt3aQb9PWVf2zuKCMjEQg5ynpihlJntIzSCGL+l5UWSasAzgVlKNUIw93gyyTc5LsWVSi M29K2rCbpFPK80obYp/DLFQ8xy5jqr1C/z7g5Rtrt6n5Vf8NcAWFP1YF2gQs45CJR9lTdv QqUnTt5jIu22KE+odnZsRmp9rcNI7kVLhNkYxNOMsc38V+NxMl/NWFsYs8Ddzw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657762940; a=rsa-sha256; cv=none; b=Mi7AxI6KPJADMWdh7nEh++sdCYTYZN3suqeY7G2fA9npKxl8sbWWNpQI+2gqcznPTVquIy UKKVm6EhCjlppW2kp55uFRsYo4GBHowj9QW07LDn0xU0vUqqtVLsD7FtqaawtUeSy+2R9z GBQ0MBBRG07h7KD0trCfQn1m1ATaSPOXUCtWUvtFgKssi8UDm1KoWqSi/YWRNZB+0pzldO l5vbyP+e4i4QJOVgUpPhSRdLgMk7oloeDZeM4ZQlYvH2bl/tPl4F57UzFSo54L1NoYk6/S ff6MQU1yu5p3k71CO3KhoQK7GBoDejSFtT4ibALLwBBqeeAQ2B9DwV4rgW1IqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=n7iHC1br; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=n7iHC1br; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1BBA238BCA X-Spam-Score: 5.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: gdVhwKDqHPaF Hi Oleg, Maxim Cournoyer writes: > Hi, > > Maxim Cournoyer writes: > >> Hi Oleg, >> >> Oleg Pykhalov writes: >> >>> Fixes . >>> >>> * gnu/packages/patches/containerd-create-pid-file.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add this. >>> * gnu/packages/docker.scm (containerd)[source]: Add this patch. >>> * gnu/services/docker.scm >>> (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. >>> * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. >> >> Thanks for this, it looks promising! [...] > All that to say that I shall be reviewing your patches shortly :-). Now done; it all looks good to me! I've run the docker system test, and installed it on my machine, rebooted, confirmed it was up, restarted containerd a couple times and checked the PID content matched its actual PID, and it seems to behave as expected! Pushed as b33e1a183f6756514e6b6a3b84054a232dbddad4. Thank you! Maxim