From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id gOFLKtwa2WLTWQEAbAwnHQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 21 Jul 2022 11:22:36 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id GNtBKtwa2WLUzQAAauVa8A
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 21 Jul 2022 11:22:36 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 6DCAB38A41
	for <larch@yhetil.org>; Thu, 21 Jul 2022 11:22:36 +0200 (CEST)
Received: from localhost ([::1]:60042 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1oESOB-0003Pm-CN
	for larch@yhetil.org; Thu, 21 Jul 2022 05:22:35 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:56352)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oESNe-0003OK-HT
 for guix-patches@gnu.org; Thu, 21 Jul 2022 05:22:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46975)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1oESNe-0006Eh-8W
 for guix-patches@gnu.org; Thu, 21 Jul 2022 05:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oESNe-0001U5-4w
 for guix-patches@gnu.org; Thu, 21 Jul 2022 05:22:02 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when
 deleting specific items.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Thu, 21 Jul 2022 09:22:02 +0000
Resent-Message-ID: <handler.51427.B51427.16583952895663@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 51427
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 51427@debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>,
 maxim.cournoyer@gmail.com, zimon.toutoune@gmail.com
Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.16583952895663
 (code B ref 51427); Thu, 21 Jul 2022 09:22:02 +0000
Received: (at 51427) by debbugs.gnu.org; 21 Jul 2022 09:21:29 +0000
Received: from localhost ([127.0.0.1]:36724 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1oESN6-0001TF-Js
 for submit@debbugs.gnu.org; Thu, 21 Jul 2022 05:21:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43332)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1oESN5-0001T3-4H
 for 51427@debbugs.gnu.org; Thu, 21 Jul 2022 05:21:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48790)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1oESMz-0006Bw-IG; Thu, 21 Jul 2022 05:21:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=OaQQrXxACRGNms3AcH8ZwKaPML6jyNvTEcS1PA4HG4M=; b=cO5T0mgDpXgrg/fpcpUm
 AWPxKurjUbFzw0y1hUzn7o3inbh/207ZHcejjGvJKGKwdAHVD4z+YsFL3XZa0l3IaXuFxtIorEMgq
 PE1Duzk3NpXMHokAyt4JpH6BbKdPOZhR0W1DwLlhxVooekUHJncnNbitnB2+io8MMaSNTOp7rqIXP
 YTvlR+wcmOC5cHK0NIkP/foz0/n4J+RqS0q9c0/7ejtmBhKeCmaLNrhAPwVSn0ncHB3MszMcupmdT
 Kn3PXXZx8OKdaTbaLXKo2yCFdM3Mk2/Z9GYtU27pnTlKD3zKuLK2shRntHeG68GB41kdeke84/uKH
 j9yRYyIMAu9YAQ==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=33322 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1oESMy-0003yd-Ai; Thu, 21 Jul 2022 05:21:20 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20211027034918.4591-1-maxim.cournoyer@gmail.com>
 <87o8795j61.fsf@gnu.org>
 <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com>
 <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com>
 <87ee7tmdbd.fsf@gnu.org> <86k0hhnqss.fsf@gmail.com>
 <871r3f2j7y.fsf@gnu.org> <867dd7roi2.fsf@gmail.com>
 <87o7xmy14l.fsf_-_@gnu.org>
 <2441c768fea8faee800947a17aef896c35173845.camel@gmail.com>
 <87sfmxv6ue.fsf@gnu.org>
 <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@gmail.com>
 <877d48lx41@nckx>
Date: Thu, 21 Jul 2022 11:21:18 +0200
In-Reply-To: <877d48lx41@nckx> (Tobias Geerinckx-Rice's message of "Tue, 19
 Jul 2022 21:25:24 +0200")
Message-ID: <877d46n7n5.fsf_-_@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1658395356;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=OaQQrXxACRGNms3AcH8ZwKaPML6jyNvTEcS1PA4HG4M=;
	b=CX0KxzlPE5ppF0ttdiKSAVkYGArDOyGup3AMl310FREaij+QLk6CIyO/p7inc+yUdhUf60
	35V6rKElfzkCyyuzLcy779Cqoo7lacQAHnFJ2F2EESENpvUn2sZd5JdyUAg8sZMxQJh+LE
	Fin3BCjd7MmJwIUmKuCfJ49ECHpvhIgA2f2oM3qITQZ/rpM3sC8HHN3tKrkT0WyypB6sph
	7s5xO/F7qLx+kLTdL/KWs0DaBLVs4sIa7SJt9nI7ZqEl3Cv4FGlRpCl6VR+O7ENTI//tDf
	rcVvv5VuA9ZF+SJ1QdQjml0S1UVyA+xXyPl8A2yC7liy42x/ZnybbMWmcH7auQ==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658395356; a=rsa-sha256; cv=none;
	b=jNWRlCw0cfbTTJtBf97nNmZ0CvZKNXr3/Kt9ewiRDBtNu0GAhbbOeYdJOg+abwqpmheB5L
	iU6+cVp5Upd0mtv1wKVlbJa7/wdMbLhfv07odFJp2Ulit5fFR4neuDgPO14IrwNgXEnFHi
	jzBMT9k1VKncCPmkPrc9lxyMn9h0iO7tR3soJCG2kb3bScjZbA0LwaAnDyMtLbU5r0LUcA
	RBw5aX7yAMCX0AL4iNT7mXTBsmhtCMZ+bI1N54H33Vd5/EMHz0fOTu6sP6PvmCXmLwjT2W
	LpzfxxDqewD6xLBWcjS+mWnBpGLQP0PNBhfX8YUDETY9i4LFb+gfNDaNo5Eq0A==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cO5T0mgD;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -2.33
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cO5T0mgD;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 6DCAB38A41
X-Spam-Score: -2.33
X-Migadu-Scanner: scn1.migadu.com
X-TUID: vj+y4jMyV1oZ

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Liliana Marie Prikler =E5=86=99=E9=81=93=EF=BC=9A
>> scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links"))
>> $1 =3D 213027
>> ;; 1417.872747s real time, 28.514293s run time.  1.284866s spent in
>> GC.
>
> [=E2=80=A6]
>
>> So yeah, assuming that scandir scales linearly
>
> =E2=80=A6your rotational drive is beyond ridiculously slower than mine (an
> ST1000DM010-2EP102):
>
> athena.tobias.gr:~ =CE=BB echo 3 | sudo tee /proc/sys/vm/drop_caches 3
> athena.tobias.gr:~ =CE=BB guix repl
> [=E2=80=A6]
> scheme@(guix-user)> ,use (ice-9 ftw)
> scheme@(guix-user)> ,t (length (scandir "/gnu/store/.links"))
> $1 =3D 164437
> ;; 7.081361s real time, 2.569773s run time.  0.199963s spent in    GC.

It=E2=80=99s crazy that there are two orders of magnitude of difference bet=
ween
these two hard disks.

Liliana, is your hard disk old or low-end?

I agree that we should strive to have good performance on that kind of
hardware too, but I don=E2=80=99t know how to get there.

Ludo=E2=80=99.