From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EGReAHUtbmM/OAAAbAwnHQ (envelope-from ) for ; Fri, 11 Nov 2022 12:09:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iOkbO3QtbmPF6wAAG6o9tA (envelope-from ) for ; Fri, 11 Nov 2022 12:09:40 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A71C3B807 for ; Fri, 11 Nov 2022 12:09:40 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otRuC-0003KS-L6; Fri, 11 Nov 2022 06:09:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otRuA-0003K4-Gc for guix-patches@gnu.org; Fri, 11 Nov 2022 06:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otRuA-0006Vk-83 for guix-patches@gnu.org; Fri, 11 Nov 2022 06:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otRu9-0005yo-QC for guix-patches@gnu.org; Fri, 11 Nov 2022 06:09:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59003] [PATCH v2 6/6] installer: Report known-unsupported PCI devices. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Nov 2022 11:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59003 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59003@debbugs.gnu.org Received: via spool by 59003-submit@debbugs.gnu.org id=B59003.166816492722966 (code B ref 59003); Fri, 11 Nov 2022 11:09:01 +0000 Received: (at 59003) by debbugs.gnu.org; 11 Nov 2022 11:08:47 +0000 Received: from localhost ([127.0.0.1]:45175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otRtv-0005yM-8v for submit@debbugs.gnu.org; Fri, 11 Nov 2022 06:08:47 -0500 Received: from relay.yourmailgateway.de ([185.244.194.184]:48115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otRtt-0005yD-I5 for 59003@debbugs.gnu.org; Fri, 11 Nov 2022 06:08:46 -0500 Received: from relay01-mors.netcup.net (localhost [127.0.0.1]) by relay01-mors.netcup.net (Postfix) with ESMTPS id 4N7wth188Yz8tQc; Fri, 11 Nov 2022 12:08:44 +0100 (CET) Received: from policy01-mors.netcup.net (unknown [46.38.225.35]) by relay01-mors.netcup.net (Postfix) with ESMTPS id 4N7wth0lCLz8CCP; Fri, 11 Nov 2022 12:08:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at policy01-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy01-mors.netcup.net (Postfix) with ESMTPS id 4N7wtg11yTz8sXK; Fri, 11 Nov 2022 12:08:41 +0100 (CET) Received: from florianrock64 (ip5b40a50f.dynamic.kabel-deutschland.de [91.64.165.15]) by mxe217.netcup.net (Postfix) with ESMTPSA id 696B09EBCA; Fri, 11 Nov 2022 12:08:40 +0100 (CET) From: "pelzflorian (Florian Pelz)" References: <20221103191756.16265-1-ludo@gnu.org> <20221109215637.22445-1-ludo@gnu.org> <20221109215637.22445-7-ludo@gnu.org> Date: Fri, 11 Nov 2022 12:08:38 +0100 In-Reply-To: <20221109215637.22445-7-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 9 Nov 2022 22:56:37 +0100") Message-ID: <877d01katl.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 696B09EBCA X-Spamd-Result: default: False [-5.60 / 15.00]; BAYES_HAM(-5.50)[100.00%]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ZERO(0.00)[0]; ASN(0.00)[asn:3209, ipnet:91.64.0.0/14, country:DE]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: hiTGuBOMrPEEhvGOWGysWi8L/esI7fbmvk8vxjHwQr+jpwREieFRcnae X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668164980; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=7D90RZbA4XDlNeNqTRym3VbpYSgoJkWrno9o520wlZ0=; b=hlVyve7gBaOsihkOFImdN35era4vfGpxGRpbXphRwX750kTesCOr+9lslQUCB2XryoStCF jE3sndzNTosdImUhtiUEjlaMFAIYJkh5twaAtg/N3e9EBmV08Wymqa4YUOej1Qqryt7g1C nr9MBXB3jwS15s4Lhp817u+ACqghx1mcZ49X12p47COVzCL5nkH/b0pJjUGY7GWLmV56CU Ox8mm+tyT9NfdYcQ9JeJX2jnkVQJqia+L6KBRusD6wvAo+TImXSMy5zrpOLviN5+r8eHYL dUYl2T3iEPB5+ippga4h3mluxh+rBp8r6nvZOG8syADbFYrs+By41GpyC3ToPw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668164980; a=rsa-sha256; cv=none; b=TJK0uLlCYTVF7timxZ6ZeRhS/PDyy77R5ic11Jo484b4sy4ubaGw4YlMIfikP8+VtTCnIU pat0dPJTCzNP0Wfqi7Xhbz70ZcW5vaWbxPH+56CU2ATNpT1hwFsHOj0oxtUOpSdcr42djV JDh+cfRADi9I+F7kN8NbSwP/VUbdulT5cNloHbUUohht3W3YsG4tRTogNDJQu/e9s50h5b z0TDFTVy0x2zPmLDxQO3gKBx9E2gJm/1kD/dUqf8Kiz2FH9Ayjch5Y3oN7P9gwuy3BWIRU sUBTvccUbUUA2E7zpa8Pp9C/dtPrIFLt38jQjkPg0vATnFbVjAS5rkabrl0/9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8A71C3B807 X-Spam-Score: -4.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: px97hMlBFVPi Okay, the blame on the hardware manufacturer is fine as is. I tested again by creating a dummy gpg key, locally adding it to guix-authorizations and changing guix/channels.scm=E2=80=99s %guix-channel-introduction. Ludovic Court=C3=A8s writes: > +(define %unsupported-linux-modules > + '([=E2=80=A6] > + ;; Graphics. > + "amdgpu" > + "radeon" Yes, this is fine, I think, even though AMD users will have also gotten the uvesafb warning before and even though allegedly some AMD devices work okay without firmware (except for 3d, according to h-node). Also with the previous v1 patch revision (I had missed that), and now testing on a PC with non-working AMD graphics, when I first select shell-based install, I get the warning, then switch back to the installer with Alt-F1 and select graphical installation, after first seeing the uvesafb warning, the installer crashes. installer-backtrace is this: In ice-9/boot-9.scm: 1752:10 19 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In ice-9/eval.scm: 619:8 18 (_ #(#(#(#)) #>)) 626:19 17 (_ #(#(#(#)) #>)) In gnu/installer/utils.scm: 353:14 16 (call-with-server-socket _) In ./gnu/installer/steps.scm: 150:13 15 (run () #:todo-steps _ #:done-steps _) 148:23 14 (run ((locale . "en_AG.utf8")) #:todo-steps _ #:done-steps _) In ./gnu/installer/newt/welcome.scm: 118:18 13 (run-menu-page "GNU Guix install" "Welcome to GNU Guix system = installer!\n\nYou will be guided through a graphical installation program.\= n\nIf you are familiar with GNU/Linux and you=E2=80=A6" =E2=80=A6) 118:18 12 (run-menu-page "GNU Guix install" "Welcome to GNU Guix system = installer!\n\nYou will be guided through a graphical installation program.\= n\nIf you are familiar with GNU/Linux and you=E2=80=A6" =E2=80=A6) 152:36 11 (check-hardware-support #f) In ./gnu/installer/hardware.scm: 80:19 10 (pci-device-description #f) In gnu/build/linux-modules.scm: 561:14 9 (load-pci-device-database _) In unknown file: 8 (open-file #f "r0") In ice-9/boot-9.scm: 1685:16 7 (raise-exception _ #:continuable? _) 1780:13 6 (_ #<&compound-exception components: (#<&assertion-failure> #<= &origin origin: #f> #<&message message: "Wrong type (expecting ~A): ~S"> #<= &irritants irritants: ("string" #f)> #<&except=E2=80=A6>) In ice-9/eval.scm: 619:8 5 (_ #(#(#(#) wrong-type-ar= g (#f "Wrong type (expecting ~A): ~S" ("string" #f) (#f))) #> # =E2=80=A6)) 626:19 4 (_ #(#(#(#) wrong-type-ar= g (#f "Wrong type (expecting ~A): ~S" ("string" #f) (#f))) #> # =E2=80=A6)) In ./gnu/installer/dump.scm: 58:4 3 (prepare-dump wrong-type-arg (#f "Wrong type (expecting ~A): ~= S" ("string" #f) (#f)) #:result _) In ice-9/ports.scm: 433:17 2 (call-with-output-file _ _ #:binary _ #:encoding _) In ./gnu/installer/dump.scm: 60:27 1 (_ #) In unknown file: 0 (make-stack #t) ./gnu/installer/dump.scm:62:36: Wrong type (expecting string): #f Regards, Florian