From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OKzjDyx0jGOJCgAAbAwnHQ (envelope-from ) for ; Sun, 04 Dec 2022 11:19:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iPjiDyx0jGMfDQEA9RJhRA (envelope-from ) for ; Sun, 04 Dec 2022 11:19:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2D593D158 for ; Sun, 4 Dec 2022 11:19:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1m5Q-0000AW-KU; Sun, 04 Dec 2022 05:19:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1m5P-0000AL-CF for guix-patches@gnu.org; Sun, 04 Dec 2022 05:19:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1m5O-0006jA-OZ for guix-patches@gnu.org; Sun, 04 Dec 2022 05:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1m5O-0001J9-1b for guix-patches@gnu.org; Sun, 04 Dec 2022 05:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 10:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54379 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 'Brendan Tildesley , 54379@debbugs.gnu.org Cc: Kevin Boulain , Maxime Devos Received: via spool by 54379-submit@debbugs.gnu.org id=B54379.16701491025016 (code B ref 54379); Sun, 04 Dec 2022 10:19:01 +0000 Received: (at 54379) by debbugs.gnu.org; 4 Dec 2022 10:18:22 +0000 Received: from localhost ([127.0.0.1]:56717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1m4j-0001Iq-Rv for submit@debbugs.gnu.org; Sun, 04 Dec 2022 05:18:22 -0500 Received: from jpoiret.xyz ([206.189.101.64]:40178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1m4h-0001Ik-MM for 54379@debbugs.gnu.org; Sun, 04 Dec 2022 05:18:20 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id EB4251851E7; Sun, 4 Dec 2022 10:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1670149096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h/sRqQTrabhNkQjEM8LUCm3A0aeGz/10UUafpd8EFnE=; b=ef+BShltl0Jo5/RQeZHc2CNdHUYHOix9glBMQX5DdaHGQ+WXaul8PVbvy/OS9ydceAbVff xBAFjj78gPhIFnA9nyEauUkv6QgqmmP7oodHgBNTNHshrQcxI2Kz6vgNVV+ivMOWu9nGOo RDGs0k2fe2YfZErHQAlLaSZB8XUFuR8uWMVg86wX1W0KpWjjfV0xU9ycn5y6TOcQRrLC8I X8+efV/QAyuwBvU/RZ3VmUbqTAwLsjLfK9xAZEc3fpyTQYT8+apA9fNHmeAmITsgBCpn2L W/M5VMiD2D1LvRImmh6FPKBDA/HSPG6sfLznkXPDJAkWXL06XahK2/eFBpxVOg== In-Reply-To: <20221009091232.25885-1-mail@brendan.scot> References: <20220313223533.9632-1-kevinboulain@gmail.com> <20221009091232.25885-1-mail@brendan.scot> Date: Sun, 04 Dec 2022 11:18:14 +0100 Message-ID: <877cz71nh5.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670149164; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=h/sRqQTrabhNkQjEM8LUCm3A0aeGz/10UUafpd8EFnE=; b=FlvqgZNOX3Lm7nLYHBxBUxC7oGBB69fTB2jUbedjVH84SduFR6oLnRO/pxjOVUynpbMAew okm9nWxLKjzkhpk44l2EGSpsUNewUVpEo4I1krXNs0HXu0/q9XvRTB+Mj5FmZjVAqC1llW Wgj0CNSWl0BZrwvmmbzPNY4UfC2XfjGL+bC8iCLXuNem7hhLQYk4fT/93ptLY1oXZT18WV keUC2bFzpRu1X76TIm/fG+7BP9AMCvniKM2wwc75au+/K29d1q9mPLClA6FZrtusyeWpDh CLGdkcZ/8288tX3fOBwmldcK33mXB01BGMMh/pRAKw/d27tDwOpS8meGz/Hpzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670149164; a=rsa-sha256; cv=none; b=diElAG+4JcDhPBzTMZaFQ/eymQCHaAZLQraE89b+8jMzVLdlsfpgXV09Pt9+G+pvbRnmlz nnvmI5Q5ZgPgwEs9MNcFyWDODfH5PMs+Kb+VP5JuYuzPJTek5r/P5CxlOIN+nI7Z2tJjG3 jSykb6oPtimYa9Roux0xhaY4CFa7zRnEqOXLd9UiADQ/VKWmTzmXlICksj0syX94uJ9oSf 3qfszIhI8pHKVsQnSnysWuYwU9oub5EjmBADL33R5eFZkiCZIxTHfHPk2nE7p8Dnhc13uM Q2abGQWNt2/BeZ9spNjC+cqJVFIWu4ZN9x8UacMIyrqJ39YddxsOVL6j+q+dnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=ef+BShlt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=ef+BShlt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B2D593D158 X-Spam-Score: -3.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: pTx/XRCO4jzT Hi Brendan and Kevin, 'Brendan Tildesley writes: > Same as v3 but uses PREFIX instead of DESTDIR for libfreeaptx. This patch totally flew under my radar before, but now that I wanted to add aptX support I finally found it (after writing the libfreeaptx definition myself first :p). Looks good overall, I'm using it without any issues, but I have a couple of very small nitpicks: * First of all, patch 1 doesn't cleanly apply on master anymore (which is normal). To make it easier for maintainers to merge your patches, you should specify base-commit in your patches using the --base option, so that they know what patch this was supposed to cleanly apply on; * in patch 5, you apparently left an entry in the commit message about the `/etc` change, even though you separated it into its own commit; * while we're at it, there's a small typo in patch 1's commit message, `theinput` -> `the input`; * if you're inheriting patches from someone else, you should consider either leaving them as the primary author if you're keeping their changes as-is, or putting them in the commit message as Co-authored-by:. It's not really an issue here I think, but something to remember. Best, -- Josselin Poiret