From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6Jb1HPuM42P8JQAAbAwnHQ (envelope-from ) for ; Wed, 08 Feb 2023 12:52:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GGUCHPuM42OZfQEAG6o9tA (envelope-from ) for ; Wed, 08 Feb 2023 12:52:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DD4D2E1E0 for ; Wed, 8 Feb 2023 12:52:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPizj-0008T4-Ds; Wed, 08 Feb 2023 06:52:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPizb-0008Rg-30 for guix-patches@gnu.org; Wed, 08 Feb 2023 06:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPiza-00078y-Nf for guix-patches@gnu.org; Wed, 08 Feb 2023 06:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPiza-0006eb-Dl for guix-patches@gnu.org; Wed, 08 Feb 2023 06:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Feb 2023 11:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60905 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Katherine Cox-Buday Cc: paren@disroot.org, 60905@debbugs.gnu.org X-Debbugs-Original-Cc: "\(" , 60905@debbugs.gnu.org, "\( via Guix-patches via" Received: via spool by submit@debbugs.gnu.org id=B.167585708825522 (code B ref -1); Wed, 08 Feb 2023 11:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Feb 2023 11:51:28 +0000 Received: from localhost ([127.0.0.1]:54932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPiz1-0006da-Jy for submit@debbugs.gnu.org; Wed, 08 Feb 2023 06:51:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:51728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPiz0-0006dR-7A for submit@debbugs.gnu.org; Wed, 08 Feb 2023 06:51:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPiyz-0008PO-Vj for guix-patches@gnu.org; Wed, 08 Feb 2023 06:51:25 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPiyy-0004gJ-Dk for guix-patches@gnu.org; Wed, 08 Feb 2023 06:51:25 -0500 Received: from localhost (unknown [185.201.63.253]) by mira.cbaines.net (Postfix) with ESMTPSA id 70A5516121; Wed, 8 Feb 2023 11:50:07 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9bcad4f9; Wed, 8 Feb 2023 11:49:56 +0000 (UTC) References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> <87mt5pxv8u.fsf@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Wed, 08 Feb 2023 12:47:38 +0100 In-reply-to: <87mt5pxv8u.fsf@gmail.com> Message-ID: <877cws74wr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675857147; a=rsa-sha256; cv=none; b=n+bvZI/cfyPQA4M+TWW7u2QfbCkSskdWv0q0erdRrsdrnSQiaxHjLcDwICCsc2OPIBEXun at7CtnJm3Clw2OL6pXNlAML0Xj/mZtxahIYTOniyekJX1pHwO6b1Ds6HXaTHqq8WTgBozh 1QIGdR/Xz3pMDc1gOTmaQ26v1z5J67IokmShnznmM3ZBcNXOu3hot5WnGZnER0YmL8KHmL ttB6BeHOjfsojMDOf7oSI6LmI9diYe8u+3PS+j8jpjcVcpsyFSGj01KnbFvaXKpnyn1qoQ mN9u19HNkSWcQY957JWfZaVgiuW4b2MCQ7dAQ1t/+pIdCm/IiOuFcciC/jRK5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675857147; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=IPnQzZdMmOsmn2k6rNCFlaYd0OEF8RsQIcKS4B78fW4=; b=RDcm5C/zmRv5EsnFPf/+STkiiD14DoZ8KZhxF2tPObD/9oWA7hln2Eu42NEX+Q/SKVLrMx uLExDGLl2ltzJkU2MuU3mI2+wmvSP3HAtVFwblPNbSobpZkCRDdyw8ARWbrc0xRR5BxYD9 Uc0bYLcGCtywvZaDJWQ5FRensz01l+Jx9zrB2oZ6vhTa9cX3k99Gxv10JBfeYvIz9DdImy f/dI03gjtPGxSCA3X0Z6IG7Uer/EhvOBgSgEqXuLF4JiflgO3Gnk68SkucI6PeqxHaOIe+ 9cc9XiCHeL4k3nL1pFbdQ+42GN95Kls1afwBIFnpRAjgcbNF/H7GQljWTjRCfQ== X-Migadu-Spam-Score: -5.40 X-Spam-Score: -5.40 X-Migadu-Queue-Id: 3DD4D2E1E0 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: cScC4mWCXZ2I --=-=-= Content-Type: text/plain Katherine Cox-Buday writes: > "( via Guix-patches" via writes: > >> * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to >> 0.0.0-20210226163009-20ebb0f2a09e. >> >>> --- a/gnu/packages/golang.scm >>> +++ b/gnu/packages/golang.scm >> >>> @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtures >> >>> + (package >>> + (name "go-github-com-pkg-diff") >>> + (version "0.0.0-20210226163009-20ebb0f2a09e") >> >> As Chris said, don't use this kind of version string :) > > Ah, I actually have (what I think) is a valid reason for this. In Go, > when a module is in development, this long string, including the SHA, is > the actual version[1] of the module, and carries semantics for Go > developers, i.e. "Signals that the module is still in development and > unstable. The release carries no backwards compatibility or stability > guarantees." > > It's how it will be referenced by other Go modules, and so I thought it > best to make the version field reflect the actual version. The previous > iteration of this package had an incorrect version: upstream did not > assign it a 0.0.1 version; that's something we did. > > I agree that this is confusing for Guix maintainers, and causes > duplicate information in the version and commit fields. > > What are your opinions on this? I guess I'm not that fussed if a long version has some use. What I would say is that as long as the version incorporates the commit in some way and the commit is used in the package source bit, I'd use the (let ((commit ... pattern to avoid duplicating bits of the commit hash and make tweaking the commit easier. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPjjGRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe1cg//VMgthrE21DVF60JWLFe0SUY6JZbHOggi /fT0iEDnrkW4Tr1r7OwBWlZ2BRHoLia44zlZWG08+e7rGJqzbxaVcZGRUv+Dk5Gu 53Vy6OpGttOgldMfRvmpVzciNGVlVuR7BIPN+qjZgWClnq99InTWU0lJ8rxmSCqc XKShr7OuCYtqwMu4LLyz1z3J2h9+Nq7Kq2sSVRuwTFqXmKZK9POjdmODXD4Vuarx 5Cp268KFKB2RAIxGpYv3nzTcBTNobDDDwEyFVrvClAXo9GffrHiT1C0Np2w3AAP1 URjr8/Jgu7Q5Xmk0y7ddq/4z9VqppEaqi6/paC3+iXt/5nofnH3A9pOT6HiaZO0i RJQzBBfBpxoE4WHFCl1ExehzPFyvpcwBGuu1hAjSOsGQc02P4RDCO8nhvYXUuqlJ EIpYifMf9Nz/Pd/lBvFXZtjLT9mtqgKQkJot6NGtmYxR0z5RHkz7Z9kYddFfDqVG 9AgiGSUMVBngHzH/myZsFehvCGvjNPm4ykJqTtVJzerVxoK35VhGG0Rx3G3yUzx5 jOLZyAZjmS23s7RV7xFeNMuOEsMDBNGCHnEVTn7Y/TE6WLNfW1uGsUVXlInA+8zK tNeqpvZb4ipmINcWMekviPDgFyigSVtL2BHNwP9/Z2rcS+jNrO5TVGS3GHHd57/R gMWCzFbPmyM= =2yqj -----END PGP SIGNATURE----- --=-=-=--