From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uEdgGL426WO5JwEAbAwnHQ (envelope-from ) for ; Sun, 12 Feb 2023 19:58:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sBlaGL426WMqAgEA9RJhRA (envelope-from ) for ; Sun, 12 Feb 2023 19:58:06 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D627BB272 for ; Sun, 12 Feb 2023 19:58:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRHY3-0005xY-L4; Sun, 12 Feb 2023 13:58:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRHY2-0005x9-2e for guix-patches@gnu.org; Sun, 12 Feb 2023 13:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRHY1-0007jH-QX for guix-patches@gnu.org; Sun, 12 Feb 2023 13:58:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRHY1-0005Km-NS for guix-patches@gnu.org; Sun, 12 Feb 2023 13:58:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61255] [PATCH 0/5] Add support for the RPM format to "guix pack" Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Feb 2023 18:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61255 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 61255@debbugs.gnu.org Received: via spool by 61255-submit@debbugs.gnu.org id=B61255.167622827920496 (code B ref 61255); Sun, 12 Feb 2023 18:58:01 +0000 Received: (at 61255) by debbugs.gnu.org; 12 Feb 2023 18:57:59 +0000 Received: from localhost ([127.0.0.1]:46766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRHXz-0005KV-FT for submit@debbugs.gnu.org; Sun, 12 Feb 2023 13:57:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRHXx-0005KF-OU for 61255@debbugs.gnu.org; Sun, 12 Feb 2023 13:57:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRHXs-0007id-Bf; Sun, 12 Feb 2023 13:57:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=O1TpdhidQXMx3ItmO6b4bn6sgUq/rc+Ns4LR9/YFYTc=; b=dDQ+L8rJjpipHUo4XkPB EyQlWA/pIQVRw1MhYPzZDnd6Cq8F9dktovFQZ0S/qnwpxyyeJV0srOAfXmQWMn6khpfZIfoZoaf44 BJsOP6voFV479SO0xAPy0FjEU8Xk6Qe5o5OBiol22Gw2cskbEeHMM9B9YU3k4uemZ/KI8NyaiL5GF 7laE6anZIYxPWIIbFKN21xv8fBd4XfIC9GVrPuipFjT90VcWnsLCgoCwxVJxFYciHmwcczgcUB4jF Fgi2DxpfVuhfjTE+PavS70ox8IK7wJNuCQI5F0uS6GmtTxbl+RtbueBGUPL0rc7Ap0RWyJ92qP9WS 2+oT+oIZrlztAQ==; Received: from [185.228.228.230] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRHXr-0004hf-Ne; Sun, 12 Feb 2023 13:57:52 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230203161926.26886-1-maxim.cournoyer@gmail.com> <20230203221409.15886-2-maxim.cournoyer@gmail.com> Date: Sun, 12 Feb 2023 19:57:48 +0100 In-Reply-To: <20230203221409.15886-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 3 Feb 2023 17:14:04 -0500") Message-ID: <877cwmk8yb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676228286; a=rsa-sha256; cv=none; b=h+bNygx11CtgbLLa2fgRCd15c9jt6EZOEeNAWRXBkJCUT3tydsK178q5LrZpIwBd619YN1 zUbmEKiOpLH5s+NZyDYRNy1X9BRRo0kxylXSbgeFsBj9laVqiYUtviqmlSVMURMLB4PDdm S1hQ0UylmiH3OgtJhJfbwJ5qs3RCadaCsTX3VgcY+0C/rSsMyGwFSZza8GYoH2TUpBsm/a fSQwy0pbRVINcr2ts2aWNPMmAbAYLAUmoLW0EBuoSxk5FQ1SHjZbOT8zqDVBztZeu9CEqD vNFr9C+4wVeXVAmIO4TQK8ooCwrn3zdgZdhnCSiu9SxCOXkhKs/z/mbSi6k6Hg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=dDQ+L8rJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676228286; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=O1TpdhidQXMx3ItmO6b4bn6sgUq/rc+Ns4LR9/YFYTc=; b=pDLNhpT3GsO5EOWc+A60fNo8R0KYRS11vKltg3IxDWnQHI9lx6eB12/JVDiL2nQLyvSVJE 6bbrnrgafkNfSXvjgjkAYMDJs4vqp8Pe2/LsMZ5+XtNGkrUXsr1TUcx8lkJXHsxVNFtBWj 4UrgIGn3X3sdYei7C+ZAiHE6dGh3lICA/yYspnxhau14sjm3q/10V3aQauZbrXWhoCQrM9 qVkbrxB24k3VnDkxHpSa1foGPzES7VaNlBV+DUNTJ6nijMA0Uq8O306Y0IOl0O6UeW5Hvu Sk7KjvmO20F5lWqw5PMt/KYJFa3eakLrfrmOaKHfKsxrYYxFA3h/W3P7hLlywg== X-Migadu-Spam-Score: -2.52 X-Spam-Score: -2.52 X-Migadu-Queue-Id: D627BB272 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=dDQ+L8rJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: xwfCYrAFL6eM Maxim Cournoyer skribis: > Rationale: the upcoming rpm-archive builder will also use it. > > * guix/scripts/pack.scm: > (keyword-ref): New top-level procedure, extracted from... > (debian-archive): ... here. Adjust usages accordingly. Commit aeded14b8342c1e72afd014a1bc121770f8c3a1c added #:extra-options, which is why we need =E2=80=98keyword-ref=E2=80=99 now. I=E2=80=99m thinking a different option would be to use #:allow-other-keys = in all the image build procedures. That way the deb and rpm build procedures would get their extra arguments, which would be automatically bound without requiring manual =E2=80=98keyword-ref=E2=80=99 calls. Sounds= a bit nicer maybe? If we skip to the current approach, we should consider using =E2=80=98let-keywords=E2=80=99 from (ice-9 optargs) instead of adding =E2= =80=98keyword-ref=E2=80=99. Anyway, not a blocker IMO, but something to keep in mind. Ludo=E2=80=99.