From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aNnWKEiK92OIHgEAbAwnHQ (envelope-from ) for ; Thu, 23 Feb 2023 16:46:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MKmoKEiK92PRFAEA9RJhRA (envelope-from ) for ; Thu, 23 Feb 2023 16:46:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6AE593C2B7 for ; Thu, 23 Feb 2023 16:46:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVDnI-0007JE-8N; Thu, 23 Feb 2023 10:46:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVDnG-0007Ip-KT for guix-patches@gnu.org; Thu, 23 Feb 2023 10:46:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVDnG-00012d-Du for guix-patches@gnu.org; Thu, 23 Feb 2023 10:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVDnF-0000a7-SW for guix-patches@gnu.org; Thu, 23 Feb 2023 10:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61255] (%guile-for-build) default in =?UTF-8?Q?=E2=80=98computed-file=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Feb 2023 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61255 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 61255@debbugs.gnu.org Received: via spool by 61255-submit@debbugs.gnu.org id=B61255.16771671022160 (code B ref 61255); Thu, 23 Feb 2023 15:46:01 +0000 Received: (at 61255) by debbugs.gnu.org; 23 Feb 2023 15:45:02 +0000 Received: from localhost ([127.0.0.1]:35020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDmI-0000Yl-0q for submit@debbugs.gnu.org; Thu, 23 Feb 2023 10:45:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDmG-0000Y0-Al for 61255@debbugs.gnu.org; Thu, 23 Feb 2023 10:45:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVDm9-0008DR-Fw; Thu, 23 Feb 2023 10:44:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3UzwHy8EinxyHPlSzawyIExd9uUHcyPKbZnezqjed3w=; b=fUZje+A4K76siCJ4lwdB cxwasYy1EH71e69gAy84M6o3D6vMWXigIUK60TS+/pOyWQ4Xjmh5qCFmU1k/2Ik4PDvAv7Qmsge4b KINeeG3Y7ZgFgvWk4dkukXhe8iBWrjmqagk30oYluVFRYKLhst1KSPNfqOrYg77EE//8k/nvcECFb MlM0J9+BpBMAFGBL5/iK3fc1XzxNcWzf4MHEOrc6BIBPR+2Eruwer03DZjKVn78eQHqOvSwdCX/Bt hX97BVQL+GiFX5xMlQg7tnusRh4gTpyNcBr3kTUU2+QexqSF+NOMkNEX9gY5BhxMj2M/xTbhwFak4 YfYCb8/VDK8juQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVDm8-0004WL-K9; Thu, 23 Feb 2023 10:44:52 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230203221409.15886-2-maxim.cournoyer@gmail.com> <20230203221409.15886-3-maxim.cournoyer@gmail.com> <877cwyw7yc.fsf@gnu.org> <87h6w2p02y.fsf@gmail.com> <87a61ilpi6.fsf_-_@gnu.org> <87fsb5wso1.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 =?UTF-8?Q?Vent=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Bouc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 23 Feb 2023 16:44:49 +0100 In-Reply-To: <87fsb5wso1.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 16 Feb 2023 10:12:30 -0500") Message-ID: <877cw85qtq.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677167176; a=rsa-sha256; cv=none; b=F7dtcoZDZ2JIhrtVwZ9lCUxfPOnyD7s1SlVv8NlhCZEnLK2NzfOctxxiDQptCOxjKVZEu2 jgf6Il2JqBSLzdrcBu8lB3IWjXW+bqEzOv+YvnSBOZ1PNcUmMI+WTNG6GNn2f/tr+1l2Yg ltv1q3s1HXhyIjEnn5aoq7U4jNn7nSv7eo3ipdzIuvw1IVietjuILcMRVApQbUT1WmrVu5 jzRlgtiWExCtdKmQQupZdNKaAXrhgrAD7Uln7GeVEHC9g511R+3B6EkLPXRA4/TOzDWLsO mL26MEsoS5zBmQbpXTD/+ori8MvRJOkXShynV/FR+A8+IgYzGcfKBC7BNYOo6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fUZje+A4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677167176; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3UzwHy8EinxyHPlSzawyIExd9uUHcyPKbZnezqjed3w=; b=hued4ouF+1Dur8ZhroNO1xB5nk/zeMl9AMg/irfrppfoLpeyiDYfoUapr4GNtLJhkJ2D74 5NlKd5GixqAOV+75eM4v/rBa1QPa901DZ5xxWwDDX/6qa6G0p6goRtVPEKbcJrd/7vRArh fZNUyyLSagG2pQ3SH7SjadiEXAyq8UtlJ5ZcWWIGqU1LEOLZntHPI99uWhr2KmHfLoet9+ kn2LKxCk4gOjrfQhLf61tmPsd8xWzpxS+0CGY6gPC1GNHJ9N9QD1iUFHtePbWVrjtPfxal LsZb0M2yO+eHVbSdtsU2Kj3798I3k3cW2sMdmTOnQA8mi1B2/LJe+Jxk+4wtTg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.07 X-Spam-Score: -1.07 X-Migadu-Queue-Id: 6AE593C2B7 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fUZje+A4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: Za8uXZFBgnJm Hello! Maxim Cournoyer skribis: > Hi Ludovic! > > Ludovic Court=C3=A8s writes: > >> Hi Maxim, >> >> Maxim Cournoyer skribis: >> >>> Ludovic Court=C3=A8s writes: >>> >>>> Hello! >>>> >>>> Maxim Cournoyer skribis: >>>> >>>>> * guix/gexp.scm (computed-file): Set the default value of the #:guile= argument >>>>> to that of the %guile-for-build parameter. >>>> >>>> [...] >>>> >>>>> (define* (computed-file name gexp >>>>> - #:key guile (local-build? #t) (options '())) >>>>> + #:key (guile (%guile-for-build)) >>>>> + (local-build? #t) (options '())) >>>> >>>> I think that would lead =E2=80=98computed-file=E2=80=99 to pick (%guil= e-for-build) at >>>> the wrong time (time of call instead of time of lowering). >>>> >>>> Commit ab25eb7caaf5571cc9f8d6397a1eae127d7e29d1 made it #f such that >>>> =E2=80=98gexp->derivation=E2=80=99 gets to resolve it at the =E2=80=9C= right=E2=80=9D time. >>> >>> I see! I think you are right. Would making the change in the >>> associated gexp compiler do the right thing? Currently it ignores the >>> %guile-for-build fluid as set in the tests/pack.scm test suite for >>> example. Something like this: >> >> I don=E2=80=99t fully understand the context. My preference would go to= doing >> like the =E2=80=98computed-file=E2=80=99 tests in =E2=80=98tests/gexp.sc= m=E2=80=99, where we explicitly >> pass #:guile %bootstrap-guile. > > With the refactoring done in patch 3/5 ("pack: Extract > populate-profile-root from self-contained-tarball/builder."), a > computed-file is used in the factorized building block > 'populate-profile-root'. Without this patch, the tests making use of it > would attempt to build Guile & friends in the test store. > >> That said, it seems like patch #5 in this series doesn=E2=80=99t actuall= y use >> =E2=80=98computed-file=E2=80=99 in =E2=80=98tests/pack.scm=E2=80=99, doe= s it? > > It does, indirectly. > > I hope that helps! I=E2=80=99m really not sure what the impact of 68775338a510f84e63657ab09242d79e726fa457 is, nor whether it was the only solution to the problem. One thing that probably happens is that (default-guile) is now never used for , contrary to what was happening before. The spirit is that (default-guile) would be used as the default for all the declarative file-like objects; gexp compilers refer to (default-guile), not (%guile-for-build). Importantly, (%guile-for-build) is a derivation, possibly built for another system, whereas (default-guile) is a package, which allows =E2=80=98lower-object=E2=80=99 to return the derivation for the right syste= m type. Overall, I think this change should be reverted but of course, we should find a solution to the problem you hit in the first place. I hope this makes sense to you. Ludo=E2=80=99.