[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Roman Scherer]

[-- Attachment #1.1: Type: text/plain, Size: 2185 bytes --]


Hi Guix,

I'm trying to build Icecat on an aarch64-linux based Guix system. I got it
working with the patches attached to this mail. I would like to include this
into Guix but I am not sure about the following issues:

1. jemalloc

I'm using the kernel configuration from the Asahi Linux project which uses 16K
as the kernel page size. Because of this I get an "Unsupported system page
size" error from the jemalloc package when building Icecat.

I fixed this issue by setting the page size in the jemalloc package to 16K,
when building for an aarch64-linux system. I got this from the PKGBUILD [1] of
ARM Arch Linux.

I'm new to ARM and now I'm wondering:

- What is the default kernel page size on an aarch64-linux system?

- If there is none, is there one that is most commonly used?

- Why does ARM Arch Linux default to 16K and should we too?

- Which kernel page size is used on CI to build jemalloc and Icecat on the
  aarch64-linux builders?

- Did Icecat ever built on aarch64-linux on CI?

I also updated the version of jemalloc to 5.3.0, because I thought they also
addressed this issue for my particular aarch64-linux system [2]. This new
version sets the page size also to 16K, but only when building for an
aarch64-apple-darwin system, and not for aarch64-linux systems. So I'm not
sure only updating the version would fix the kernel page size issue here.

More than 5000 packages depend on jemalloc, so this should probably go into
the core-updates branch? The changes to jemalloc caused my world to rebuild
locally, but I ended up with a working Icecat.

2. Disable EME on aarch64-linux

I removed the --disable-eme option on aarch64-linux because the configure
script failed an error saying this option is not supported on this
architecture. Since EME stands for Encrypted Media Extensions and is a
JavaScript API for playing DRMed video content in HTML, I'm not sure if this
is ok, or what to best do here?

Could someone please review the patches and give me some advice on how to
proceed with these issues?

Thanks, Roman.

[1] https://archlinuxarm.org/packages/aarch64/jemalloc/files/PKGBUILD
[2] https://github.com/jemalloc/jemalloc/blob/dev/configure.ac#L1733


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-jemalloc-Update-to-5.3.0.patch --]
[-- Type: text/x-diff, Size: 1280 bytes --]

From 87b3983e2981fc433b4b7e24f6d3b13f17d90c56 Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sun, 22 Jan 2023 19:30:12 +0100
Subject: [PATCH 1/3] gnu: jemalloc: Update to 5.3.0.

* gnu/packages/jemalloc.scm (jemalloc): Update to 5.3.0.
---
 gnu/packages/jemalloc.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/jemalloc.scm b/gnu/packages/jemalloc.scm
index 2e25780257..354f07a838 100644
--- a/gnu/packages/jemalloc.scm
+++ b/gnu/packages/jemalloc.scm
@@ -75,7 +75,7 @@ (define-public jemalloc-4.5.0
 (define-public jemalloc
   (package
     (inherit jemalloc-4.5.0)
-    (version "5.2.1")
+    (version "5.3.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -83,7 +83,7 @@ (define-public jemalloc
                     version "/jemalloc-" version ".tar.bz2"))
               (sha256
                (base32
-                "1xl7z0vwbn5iycg7amka9jd6hxd8nmfk7nahi4p9w2bnw9f0wcrl"))))
+                "1apyxjd1ixy4g8xkr61p0ny8jiz8vyv1j0k4nxqkxpqrf4g2vf1d"))))
     (arguments
       (substitute-keyword-arguments (package-arguments jemalloc-4.5.0)
         ;; Disable the thread local storage model in jemalloc 5 to prevent
-- 
2.38.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-gnu-jemalloc-Build-with-large-page-size-on-aarch64.patch --]
[-- Type: text/x-diff, Size: 913 bytes --]

From ff4f0076185143436058315a9d8ae74830c84eff Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sun, 22 Jan 2023 19:31:37 +0100
Subject: [PATCH 2/3] gnu: jemalloc: Build with large page size on aarch64.

* gnu/packages/jemalloc.scm (jemalloc): Build with large page size on aarch64.
---
 gnu/packages/jemalloc.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/jemalloc.scm b/gnu/packages/jemalloc.scm
index 354f07a838..877b026fda 100644
--- a/gnu/packages/jemalloc.scm
+++ b/gnu/packages/jemalloc.scm
@@ -58,6 +58,8 @@ (define-public jemalloc-4.5.0
        '(,@(match (%current-system)
              ((or "i686-linux" "x86_64-linux")
               '())
+             ("aarch64-linux"
+              (list "--with-lg-page=14"))
              ("powerpc-linux"
               (list "--disable-thp" "CPPFLAGS=-maltivec"))
              (_
-- 
2.38.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.4: 0003-gnu-icecat-Fix-disable-eme-option-on-aarch64.patch --]
[-- Type: text/x-diff, Size: 973 bytes --]

From 71bf3cf7187de92f7974bedc2d0291a78a0754bc Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sun, 22 Jan 2023 19:33:13 +0100
Subject: [PATCH 3/3] gnu: icecat: Fix --disable-eme option on aarch64.

* gnu/packages/gnuzilla.scm (icecat): Fix --disable-eme option on aarch64.
---
 gnu/packages/gnuzilla.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 23249791bb..95c8be5f1b 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -756,7 +756,8 @@ (define-public icecat
          "--disable-tests"
          "--disable-updater"
          "--disable-crashreporter"
-         "--disable-eme"
+         ;; The --disable-eme option is not available on aarch64.
+         #$(if (target-aarch64?) "" "--disable-eme")
 
          ;; Building with debugging symbols takes ~5GiB, so disable it.
          "--disable-debug"
-- 
2.38.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

[bug#61009] [PATCH v2] Building Icecat and jemalloc on aarch64-linux

[Roman Scherer]

[-- Attachment #1.1: Type: text/plain, Size: 381 bytes --]


Hi Guix,

here is another approach to this. This patch series updates jemalloc to
v5.3.0 and does not disable transparent huge pages on aarch64-linux,
similar to what we do on i686-linux and x86_64-linux. So I think this
would support now building binaries for Rust and Icecat on CI for 4K but
also larger kernel page sizes.

Could you please review the patches?

Thanks, Roman.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-jemalloc-Update-to-5.3.0.patch --]
[-- Type: text/x-patch, Size: 1279 bytes --]

From ae69696267b0651fb2be40e4b31584d1c84647b6 Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sun, 5 Feb 2023 10:57:15 +0100
Subject: [PATCH 1/3] gnu: jemalloc: Update to 5.3.0.

* gnu/packages/jemalloc.scm (jemalloc): Update to 5.3.0.
---
 gnu/packages/jemalloc.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/jemalloc.scm b/gnu/packages/jemalloc.scm
index 2e25780257..354f07a838 100644
--- a/gnu/packages/jemalloc.scm
+++ b/gnu/packages/jemalloc.scm
@@ -75,7 +75,7 @@ (define-public jemalloc-4.5.0
 (define-public jemalloc
   (package
     (inherit jemalloc-4.5.0)
-    (version "5.2.1")
+    (version "5.3.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -83,7 +83,7 @@ (define-public jemalloc
                     version "/jemalloc-" version ".tar.bz2"))
               (sha256
                (base32
-                "1xl7z0vwbn5iycg7amka9jd6hxd8nmfk7nahi4p9w2bnw9f0wcrl"))))
+                "1apyxjd1ixy4g8xkr61p0ny8jiz8vyv1j0k4nxqkxpqrf4g2vf1d"))))
     (arguments
       (substitute-keyword-arguments (package-arguments jemalloc-4.5.0)
         ;; Disable the thread local storage model in jemalloc 5 to prevent
-- 
2.38.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-gnu-jemalloc-Build-with-transparent-huge-pacges-on-a.patch --]
[-- Type: text/x-patch, Size: 969 bytes --]

From c228faf06983c1e36f633bad6a015dfe177a1702 Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sun, 5 Feb 2023 10:59:06 +0100
Subject: [PATCH 2/3] gnu: jemalloc: Build with transparent huge pacges on
 aarch64.

* gnu/packages/jemalloc.scm (jemalloc-4.5.0): Build with transparent huge pacges on aarch64.
---
 gnu/packages/jemalloc.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/jemalloc.scm b/gnu/packages/jemalloc.scm
index 354f07a838..6c6ba0f568 100644
--- a/gnu/packages/jemalloc.scm
+++ b/gnu/packages/jemalloc.scm
@@ -56,7 +56,7 @@ (define-public jemalloc-4.5.0
              #t)))
        #:configure-flags
        '(,@(match (%current-system)
-             ((or "i686-linux" "x86_64-linux")
+             ((or "aarch64-linux" "i686-linux" "x86_64-linux")
               '())
              ("powerpc-linux"
               (list "--disable-thp" "CPPFLAGS=-maltivec"))
-- 
2.38.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.4: 0003-gnu-icecat-Remove-unsupported-disable-eme-option-on-.patch --]
[-- Type: text/x-patch, Size: 1004 bytes --]

From 0311f5812ab091dabb0686a6373c0d17e006e0c5 Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sun, 5 Feb 2023 11:01:17 +0100
Subject: [PATCH 3/3] gnu: icecat: Remove unsupported --disable-eme option on
 aarch64.

* gnu/packages/gnuzilla.scm (icecat): Remove unsupported --disable-eme option on aarch64.
---
 gnu/packages/gnuzilla.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index b507ec0406..ad051e71f7 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -756,7 +756,8 @@ (define-public icecat
          "--disable-tests"
          "--disable-updater"
          "--disable-crashreporter"
-         "--disable-eme"
+         ;; The --disable-eme option is not available on aarch64.
+         #$(if (target-aarch64?) "" "--disable-eme")
 
          ;; Building with debugging symbols takes ~5GiB, so disable it.
          "--disable-debug"
-- 
2.38.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Leo Famulari]

On Sun, Jan 22, 2023 at 09:06:43PM +0100, Roman Scherer wrote:
> 2. Disable EME on aarch64-linux
> 
> I removed the --disable-eme option on aarch64-linux because the configure
> script failed an error saying this option is not supported on this
> architecture. Since EME stands for Encrypted Media Extensions and is a
> JavaScript API for playing DRMed video content in HTML, I'm not sure if this
> is ok, or what to best do here?

Guix adheres to the Free System Distribution Guidelines, which
explicitly forbids browsers with EME support:

https://guix.gnu.org/en/about/
https://www.gnu.org/distros/free-system-distribution-guidelines.en.html

Unfortunately, I don't know the answers to your other questions.

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Roman Scherer]

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]


Hi Leo,

thanks for your reply. Ok, I understand. I try to see if I can disable
it in some other way then. Are you familiar with this? Do you have any
tips to share?

I think the v2 patches about transparent huge pages for jemalloc could
still be an improvement, if it's a compatible change. It would enable
the use of rust substitutes that depend on jemalloc on aarch64 that run
with kernel pages > 4K.

Roman

Leo Famulari <leo@famulari.name> writes:

> On Sun, Jan 22, 2023 at 09:06:43PM +0100, Roman Scherer wrote:
>> 2. Disable EME on aarch64-linux
>>
>> I removed the --disable-eme option on aarch64-linux because the configure
>> script failed an error saying this option is not supported on this
>> architecture. Since EME stands for Encrypted Media Extensions and is a
>> JavaScript API for playing DRMed video content in HTML, I'm not sure if this
>> is ok, or what to best do here?
>
> Guix adheres to the Free System Distribution Guidelines, which
> explicitly forbids browsers with EME support:
>
> https://guix.gnu.org/en/about/
> https://www.gnu.org/distros/free-system-distribution-guidelines.en.html
>
> Unfortunately, I don't know the answers to your other questions.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Leo Famulari]

On Mon, Feb 06, 2023 at 08:52:43PM +0100, Roman Scherer wrote:
> thanks for your reply. Ok, I understand. I try to see if I can disable
> it in some other way then. Are you familiar with this? Do you have any
> tips to share?

No, I don't have any specific knowledge about IceCat or aarch64.

Mark Weaver is the primary maintainer of our IceCat package.

It seems like a mistake that IceCat would require EME on a particular
architecture. Maybe the name of the configure option has changed.

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Roman Scherer]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]


Alright, thanks Leo!

Leo Famulari <leo@famulari.name> writes:

> On Mon, Feb 06, 2023 at 08:52:43PM +0100, Roman Scherer wrote:
>> thanks for your reply. Ok, I understand. I try to see if I can disable
>> it in some other way then. Are you familiar with this? Do you have any
>> tips to share?
>
> No, I don't have any specific knowledge about IceCat or aarch64.
>
> Mark Weaver is the primary maintainer of our IceCat package.
>
> It seems like a mistake that IceCat would require EME on a particular
> architecture. Maybe the name of the configure option has changed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]


Roman Scherer <roman.scherer@burningswell.com> writes:

> Alright, thanks Leo!
>
> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Feb 06, 2023 at 08:52:43PM +0100, Roman Scherer wrote:
>>> thanks for your reply. Ok, I understand. I try to see if I can disable
>>> it in some other way then. Are you familiar with this? Do you have any
>>> tips to share?
>>
>> No, I don't have any specific knowledge about IceCat or aarch64.
>>
>> Mark Weaver is the primary maintainer of our IceCat package.
>>
>> It seems like a mistake that IceCat would require EME on a particular
>> architecture. Maybe the name of the configure option has changed.

I've pushed one of these patches now as
72ec11d24f34104efce0d91050a3faba4e2c7242. I missed any other patches
that were sent to this issue.

I think removing the --disable-eme option is OK on aarch64 as it's
probably not an option since I'm guessing EME isn't available on
aarch64. Anyway, Icecat looks to add these disable options by default so
I'm not sure we need it for any architecture in the guix package.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Roman Scherer]

[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]


Hi Christopher,

thanks for applying the patch and for the explanation.

Not sure what you meant by "missed". But, I sent an improved version of
the jemalloc patches as a separate issue a while ago. They are here:

https://lists.gnu.org/archive/html/guix-patches/2023-02/msg00698.html

Without the jemalloc patches, Icecat and all other packages using
jemalloc crash with the error `<jemalloc>: Unsupported system page size`
on aarch64 systems that run with kernel page sizes > 4K.

If you are familiar with this, I could need some help here as well ;)

Thanks, Roman.

Christopher Baines <mail@cbaines.net> writes:

> [[PGP Signed Part:Undecided]]
>
> Roman Scherer <roman.scherer@burningswell.com> writes:
>
>> Alright, thanks Leo!
>>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Mon, Feb 06, 2023 at 08:52:43PM +0100, Roman Scherer wrote:
>>>> thanks for your reply. Ok, I understand. I try to see if I can disable
>>>> it in some other way then. Are you familiar with this? Do you have any
>>>> tips to share?
>>>
>>> No, I don't have any specific knowledge about IceCat or aarch64.
>>>
>>> Mark Weaver is the primary maintainer of our IceCat package.
>>>
>>> It seems like a mistake that IceCat would require EME on a particular
>>> architecture. Maybe the name of the configure option has changed.
>
> I've pushed one of these patches now as
> 72ec11d24f34104efce0d91050a3faba4e2c7242. I missed any other patches
> that were sent to this issue.
>
> I think removing the --disable-eme option is OK on aarch64 as it's
> probably not an option since I'm guessing EME isn't available on
> aarch64. Anyway, Icecat looks to add these disable options by default so
> I'm not sure we need it for any architecture in the guix package.
>
> [[End of PGP Signed Part]]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

[bug#61009] [PATCH] Building Icecat and jemalloc on aarch64-linux

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]


Roman Scherer <roman.scherer@burningswell.com> writes:

> Hi Christopher,
>
> thanks for applying the patch and for the explanation.
>
> Not sure what you meant by "missed". But, I sent an improved version of
> the jemalloc patches as a separate issue a while ago. They are here:
>
> https://lists.gnu.org/archive/html/guix-patches/2023-02/msg00698.html
>
> Without the jemalloc patches, Icecat and all other packages using
> jemalloc crash with the error `<jemalloc>: Unsupported system page size`
> on aarch64 systems that run with kernel page sizes > 4K.
>
> If you are familiar with this, I could need some help here as well ;)

Sending the jemalloc patch seperately sounds good. I'm going to mark
this issue as done since that's tracked separately.

I've replied to that separate issue, but I think that these changes may
already be in place on core-updates. I'm going to have a go at merging
master in to core-updates which should allow for testing icecat in
core-updates with the changes I've merged in master.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]