From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oMV2ClUMB2Qx1wAASxT56A (envelope-from ) for ; Tue, 07 Mar 2023 11:05:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OE1/ClUMB2TdHwEA9RJhRA (envelope-from ) for ; Tue, 07 Mar 2023 11:05:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1CBD12D5D for ; Tue, 7 Mar 2023 11:05:08 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MxoMwg+5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678183508; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9qj/3TSTJx+m8Qjpxut5rsT1hEPhxfpsfpc+WysE/GM=; b=pxKPaTQ475hmZm9CfhedZpHNSoYOKxQhhhQAebuXQopBoRU3KAY6t2vwqTDu541RcmjNcb NsjeUDgqoNNzR6ppIPu3cDuCYvJFhlNjMT6RMLVB5rr1Upji6oeDyU1YXdhmKiwgWpgHDJ eoRET8JrBZnmSt9T+JkImXBu2fVXi+MC5xxjGXFUyIxhjWs7dXjf5xlUZFu5oSAitRMI32 dTYd8w21CKSrCwPuAVcAA2mps0/GpmcE1jukqxS2sASexpzMXwYe7RmDT6ERGAHwGpZOi4 1yVEtHeBw9ydYwdLxixdRx4nYyDXHX57bSJNSVyLxQngXSAP25d8Zr2Hfu8ZhA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678183508; a=rsa-sha256; cv=none; b=jLuLV+zOctqpxwCBYFzcunq6kCtvu1CcX+DGErFGFLkCZ0TvVXsWC4vG4TaRRKn5Rapq81 qKxHM/IUajXaoPYfO8ihMEXv19uzpyisDq2Yuf46QbJp75Gp7Yf0NjTlCGW1dvQQ3hJX3w WgaMvMgXwSsOdQLGSBB/W0ufqyj0/kog87+irZ7Xlcm35ODBH7JIEyGbLvvfR9/+zEnWoA tsHPGXrVVXmvkTV4noW+RE6CpSyImXPfTJ4vaAVEonzV8P+iemMTh1ETlDzZvnPApXxndO wOF+9G9OV/vxttjmXijheo49DwfGdZGstteO7lUpes9LYpaYBUCRH40jQ+r4OA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MxoMwg+5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZUBs-0001nA-5X; Tue, 07 Mar 2023 05:05:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZUBq-0001n0-Rh for guix-patches@gnu.org; Tue, 07 Mar 2023 05:05:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZUBq-0000TW-E7 for guix-patches@gnu.org; Tue, 07 Mar 2023 05:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZUBq-0003uO-96 for guix-patches@gnu.org; Tue, 07 Mar 2023 05:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61587] [PATCH 0/8] networking services refactoring Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Mar 2023 10:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 61587@debbugs.gnu.org Received: via spool by 61587-submit@debbugs.gnu.org id=B61587.167818348114985 (code B ref 61587); Tue, 07 Mar 2023 10:05:02 +0000 Received: (at 61587) by debbugs.gnu.org; 7 Mar 2023 10:04:41 +0000 Received: from localhost ([127.0.0.1]:44515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZUBV-0003td-4i for submit@debbugs.gnu.org; Tue, 07 Mar 2023 05:04:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZUBT-0003tO-7s for 61587@debbugs.gnu.org; Tue, 07 Mar 2023 05:04:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZUBO-0000RP-1A; Tue, 07 Mar 2023 05:04:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9qj/3TSTJx+m8Qjpxut5rsT1hEPhxfpsfpc+WysE/GM=; b=MxoMwg+5/HMPTYYnwI41 Z+MAGFCbfJrvgrSf/XVikg7yB0np9d15FVBVWKR1eg9dLlgJVyqFmcSSZUZUws7cXQDD4P4yTF0lG mBafGIAso36tRNb6NzmvUdS2Npbf7ndrOgSM2D993GLkOrOcxFS8bQfs6XU7DBqAgcN+4dDf3ihXN dx3kcR4Xd2xDnQ26TeBbDhFX0OViygm3Ey7H9Wt+XK7fZvomQTBKti2gEg2XtQO3x1Q74RX3b9Tp3 HY4ercEiftXQU+zpoHswSkWJzMV1TQYzmbyvLJor5vaU+0f6iW+ugt6XLDEp14GYsu8wHv/2+XZhk 7QAEIBoV0CC01Q==; Received: from [193.50.110.138] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZUBN-00025H-IO; Tue, 07 Mar 2023 05:04:33 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87bkl4ev7p.fsf_-_@gnu.org> Date: Tue, 07 Mar 2023 11:04:32 +0100 In-Reply-To: <87bkl4ev7p.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 07 Mar 2023 11:01:30 +0100") Message-ID: <877cvsev2n.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: A1CBD12D5D X-Spam-Score: -4.01 X-Migadu-Spam-Score: -4.01 List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: QAQjG4+dDIah Hi, Ludovic Court=C3=A8s skribis: > Bruno Victal skribis: > >> Note: This also makes wpa-supplicant an optional requirement. >> >> * gnu/services/networking.scm () >> [shepherd-requirement]: New field. >> (network-manager-shepherd-service): Honor it. >> (network-manager-configuration-shepherd-requirement): Export accessor. >> * doc/guix.texi (Networking Setup): Document it. > > [...] > >> +@item @code{shepherd-requirement} (default: @code{()}) >> +This option can be used to provide a list of symbols naming Shepherd se= rvices >> +that this service will depend on, such as @code{'wpa-supplicant} or >> +@code{'iwd} if you require authenticated access for encrypted WiFi or E= thernet >> +networks. > > For clarity, I=E2=80=99d write the list: @code{'(wpa-supplicant)}. > >> + (shepherd-requirement network-manager-configuration-shepherd-requirem= ent >> + (default '())) > > [...] > >> - (requirement (append '(user-processes dbus-system loopback) >> - (if iwd? '(iwd) '(wpa-supplicant)))) >> + (requirement `(user-processes dbus-system loopback >> + ,@shepherd-requirement >> + ,@(if iwd? '(iwd) '()))) > > To preserve backward compatibility and to provide a reasonable default > (with working WiFi), I think the default for =E2=80=98shepherd-requiremen= t=E2=80=99 > should be '(wpa-supplicant) rather than the empty list. The rest of the patch series (v2) LGTM. You can send an updated version of the patch above or I can fix it up on your behalf. Thanks! Ludo=E2=80=99.