From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KSxtA3Bzj2RUpwAASxT56A (envelope-from ) for ; Sun, 18 Jun 2023 23:13:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GBKdAXBzj2QZ3gAAG6o9tA (envelope-from ) for ; Sun, 18 Jun 2023 23:13:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF4AC3ECB0 for ; Sun, 18 Jun 2023 23:13:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAzhv-0001HC-5n; Sun, 18 Jun 2023 17:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzhn-0001GG-6f for guix-patches@gnu.org; Sun, 18 Jun 2023 17:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAzhm-0006PU-Ue for guix-patches@gnu.org; Sun, 18 Jun 2023 17:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAzhm-0007yd-P5 for guix-patches@gnu.org; Sun, 18 Jun 2023 17:13:02 -0400 Subject: bug#62642: [PATCH] services: certbot: Fix nginx crash when certbot is used without domains Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 18 Jun 2023 21:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62642 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Saku Laesvuori Cc: 62642-done@debbugs.gnu.org, Bruno Victal Mail-Followup-To: 62642@debbugs.gnu.org, ludo@gnu.org, saku@laesvuori.fi Received: via spool by 62642-done@debbugs.gnu.org id=D62642.168712272630592 (code D ref 62642); Sun, 18 Jun 2023 21:13:02 +0000 Received: (at 62642-done) by debbugs.gnu.org; 18 Jun 2023 21:12:06 +0000 Received: from localhost ([127.0.0.1]:55099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzgs-0007xM-4H for submit@debbugs.gnu.org; Sun, 18 Jun 2023 17:12:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzgq-0007wV-E9 for 62642-done@debbugs.gnu.org; Sun, 18 Jun 2023 17:12:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzgk-0006Go-GI; Sun, 18 Jun 2023 17:11:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=b9VZY6jRdFyo5PFw1K/nCO2iBZBd7d0RBdHpKl2lQmY=; b=ShHEBHJ4yBVdZ7Kgqeyt rLpKF22EROuaHfJEx1pKRj6aRaeswGoAGkbwlK2EXNgFaZnfKrzM4dbSMwzyssBLC2c/fhPdgbNW2 T+XbSUo5isuPKVQi4ZKYxNcrwuSyAAzOU2a0PpZoPfiKB3/OIZDubIEPOkOukM2q1CSfv70lkYMYI KKkfY54wFHemDgGuZNgWR+f61UIg7LYmcyJ5UAD4qyX2Tej5UeVK8fYqWE6NYIG9zGHtdrdK0Y1N5 h8TjX4kucuzOtr2L3+pdF6nNWU++Hn+CXOSvmAsc9yPZ65irZh8ntw4PIdBQOmyCk5eWt/23eX3yb KWdg8DgvBrTxzA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzgk-00066u-4C; Sun, 18 Jun 2023 17:11:58 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230403133241.14760-1-saku@laesvuori.fi> <66755b58-1cb1-eae6-a4ac-69c174ed58aa@makinata.eu> <20230403180659.zhbtbfnn2uhgplgc@X-kone> <84bb2e1c-db0c-ac08-9275-ffcc0f828b1c@makinata.eu> <20230404204346.urftnbdrquetm7jw@X-kone> Date: Sun, 18 Jun 2023 23:11:56 +0200 In-Reply-To: <20230404204346.urftnbdrquetm7jw@X-kone> (Saku Laesvuori's message of "Tue, 4 Apr 2023 23:43:46 +0300") Message-ID: <877cs0pjab.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687122799; a=rsa-sha256; cv=none; b=QQHmRJur/6bt6UrolKP2wkuP+LPdYCkMfNqjgtrjvhkD273tgLEZBzGmcR0Rxq5P2wJBaN PgbpZM107LQ0Vg0m0IzMLcZTZrnk1u2rtCNxmbcILfr3+ax3d5HKSo5PXLIyKw8bYVIL93 KHtwNPGb3K6wtiNGWsiwO2EOeb+v9YgRX1IdRJvESryymsIXo8/icRgZeAfUFYEH+J/Wdb 6tHoNaJjnyicxAaQfK5PG43nuLBOeM0Pyrwhd6d6MUVZTSTTQNtG6s3gsHXS81Jk6AFhfe xWJS5iL1Z71f2Im6KjBzhWeow4LY0sFo94EtE6/61fnB6P1lR63t0rA26CUugg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ShHEBHJ4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687122799; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b9VZY6jRdFyo5PFw1K/nCO2iBZBd7d0RBdHpKl2lQmY=; b=TUdXlc10C3nfofuyGmnPoSjlg2afDvTBhmDdR/rcKLzrjpnLHloZfn0+zgZ5vExqHQWaap lb8UYK/WuxURbtPvYcKN17Gzqp6ajCcmK7R8xCNbfFdYkZRPzwSSR5t4LgL/9XvEEt8JxN nnrrE/7JSagfninEpE8+LSNu9Ubd70Ew5lnRkj8pHnDMr0tLXDF4/iNOj+dLzPZWg4PjR8 BzEsVXv5vm5DMeUpuNk/kmTb4h/eFy7OdIn9BbC4/O0gliQZQS4+LLy+OtLKXRmTO+GKNA ozjy+PMg2AiLuRtenIpZXcXxfWH6SC/7c/c9deOzBkvbBMqlXvy1j/03KBbZNw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ShHEBHJ4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.75 X-Spam-Score: -4.75 X-Migadu-Queue-Id: BF4AC3ECB0 X-TUID: pnLt+l5C51NF Hi Saku, Saku Laesvuori skribis: > * gnu/services/certbot.scm (certbot-nginx-server-configurations): > Don't return a broken nginx-server-configuration with empty server_name > when no certificate domains are configured. Instead add a separate > server for every certificate, so 0 certificates adds 0 servers. Finally applied. Thank you, and thanks to Bruno for reviewing! Ludo=E2=80=99.