From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eMP7J9C+sWTn8QAASxT56A (envelope-from ) for ; Fri, 14 Jul 2023 23:32:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gHoGJ9C+sWRFtwAAG6o9tA (envelope-from ) for ; Fri, 14 Jul 2023 23:32:00 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 596C152F3D for ; Fri, 14 Jul 2023 23:32:00 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=JnmvCZXv; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=protonmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689370320; a=rsa-sha256; cv=none; b=uDJE0E/+x2b8lgyQ2EP7dgMyH5hoHWMTh0cuLf+T1JEkWwqUD+erzO9jpGmvsNa8bdN8bm bDLpW7yLva7feghhPwe7WtiCc7Z+6jeYLynP/HR9oRMPCgL/AqAi0VetC6J6FcEFzG6tfM sA95sSoDum21gM83t9esT3yuh+FPfN/J6svyrk2p1qTPOu+4vi5Wc2mvJ/331sMZLPCt56 QgxxPpgHbich4P/fheNL8G0XCYFaDDWowLtVzW1OkzcAJg8aoSSS9K+Llk9wDb4ivhIYzw E5SfUlUX+El2BuKIEYcv7Jj4rgLTNRfxkj77f+MblfJ+8vN6p8QAwIcKk3CvMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=JnmvCZXv; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=protonmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689370320; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/GF1u8gnpYkTeKczuWutdfhj6FenrhyegDVgjyBqHoA=; b=HW7RJT5fhxS+3WBCmpBucfiwQe4plMo7TAxQdrcz7zCziD1Tq/FLoZnUujQIBnJsozZBW5 ScumIj0hLVb9+lwLIzsPQGn/swF69RofxQ42Mbt0YXwhIiybkZwJMbJjL/zvA4EQZviuMC Uk/wDOoxlZZaenv4lhCrJroDAl3BULb5jlO+ddeGODIQv7VLG1Ysuy0hIXkNh9TvzUYf5U /UfItSUDaUqnWwdaA1G9wjidTz6LzNNLMA2/oXAS2LNPacfc55BSGuQpBFR7LVFTJGfOwD ijDVY6c1bi51UhezSBflu2Cqh7MlKNa9PDPxkbQHKvwZYgpTynaRRyReRC1ZzQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKQO9-0002v0-V4; Fri, 14 Jul 2023 17:31:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKQO8-0002uq-2h for guix-devel@gnu.org; Fri, 14 Jul 2023 17:31:44 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKQO5-00079r-Uc for guix-devel@gnu.org; Fri, 14 Jul 2023 17:31:43 -0400 Date: Fri, 14 Jul 2023 21:31:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1689370299; x=1689629499; bh=/GF1u8gnpYkTeKczuWutdfhj6FenrhyegDVgjyBqHoA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=JnmvCZXvrI0nBdrmQ88Y1pvB5kvZeDNftuJ9Gh+ZBoFoxHp5NIYI5C2jf7G4iEMxK dQVAp2r5zoO969E1TX2rFskkVDSwpSrG7NJ+zILZ5Svf48TPLCSIeYQJRRz6UcfZRx eyciasL7eSH7mWp4WtSOSJ8XpvB+qqOd052e9Pn4Mu2qPSSnCfAcqGpSDBB+pf8lC5 PfLImNVttLxFYsbZW5W6KZKdBH3qLOhNR/ynAPwAEoJMevW1WnBfhSuEuF6EPFdbrd F4jvzgzlIOYsO89ec+/6nUZ3oVWytJk/jrjpIr65XiTQTosf74oFkdRlSC+JRoRzHA Pzp2ECgGxom6w== To: Pierre Langlois From: John Kehayias Cc: guix-devel@gnu.org, Andreas Enge Subject: Re: Core-updates merge Message-ID: <877cr218pe.fsf@protonmail.com> In-Reply-To: <87y1jibbmv.fsf@gmx.com> References: <87edla1md1.fsf@protonmail.com> <87y1jibbmv.fsf@gmx.com> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.22; envelope-from=john.kehayias@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -9.54 X-Spam-Score: -9.54 X-Migadu-Queue-Id: 596C152F3D X-TUID: 38aM1Vj3sEo7 Hi Pierre! On Fri, Jul 14, 2023 at 07:12 PM, Pierre Langlois wrote: > Hi John! > > John Kehayias writes: > >> Bringing back up an old thread, but >> >> On Fri, Apr 28, 2023 at 05:55 AM, John Kehayias wrote: >> >>> Dear Andreas and fellow Guix-ers, >>> >>> On Tue, Apr 25, 2023 at 04:09 PM, Andreas Enge wrote: >>> >> [...] >>>> Each and every package is not yet in shape; please feel free to submit >>>> patches for your favourite packages that fail to build. In particular: >>>> - python-yubikey-manager does not build currently; work to correct thi= s >>>> is underway. >>> >>> I've just submitted which does a bi= t >>> more than just fix that package and would be good for a Python feature >>> branch. I'll send the cover letter to this list for wider visibility, >>> though the Python team was cc'ed on the series. I suppose I should add >>> myself to the team after this. >>> >> >> Thanks to Pierre Langlois python-yubikey should now finally be fixed >> on master, without all the big python build changes. (Poetry is still >> broken.) This was via . Unfortunately >> I managed to clobber the author line in the git log after editing and >> testing locally, sorry about that! (Anything that can be done to fix >> that?) > > Thank you for picking up the series! I admit I had forgotten I had sent > it, I don't have too much time for Guix these days I'm afraid. > Attribution is always nice of course, but mistakes happen, especially > with git, so I wouln't worry about it in this instance! At least > personnally I don't mind :-), just happy that the patches went in. > Thanks for the patches! I was so caught up in all the other python stuff I ran into at the time that I never looked to pull out the fixes for python-yubikey-manager (which I use and had been using from my local branch). I appreciate the understanding! We do have your copyright lines in these additions. Given the overlap and complementary nature of both patch series (I hadn't done your cleanup but did other things) I should have just had us both as co-authors clearly from the start. I'll give myself a slight pass since I think this was the first non-trivial thing I pushed for someone else (working on a separate branch locally, rebasing several times to make fixes, etc.). Hopefully that means the next ones will be smoother and I can get rolling on helping out with reviews and pushing our many great patches we have waiting. Thanks again for the work and understanding and Guix is always happy to have your contributions! John