From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iFVHHFM5A2VLfwAA9RJhRA:P1 (envelope-from ) for ; Thu, 14 Sep 2023 18:48:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iFVHHFM5A2VLfwAA9RJhRA (envelope-from ) for ; Thu, 14 Sep 2023 18:48:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EC765523C for ; Thu, 14 Sep 2023 18:48:19 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VQ492IGL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694710099; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=1M2c4YFkz+HNZWP3TrTXIJ4ruwX+eMjqo+LpOaCJqb0=; b=Mm2XyWW9VUQR4v+ZExxxFDC0BaeQVmP1uBmeJMpQHBPUPwUlGHmeFn0NTYdGnKkUCHuug+ QdfLbjV4Gd9WrAnLG33pEMLcTFHMQrCDoJBN3E4hSUzfTeSCykoOJ/X4JCXtvRKwznh1Cr T1N6pqHThsNUIF3uPeZp3sRfCIjwlUkpYhYi8WR2dmkFjkMCzvZ1RozTYoJ/p7He9CHvzs YDogdqZGRj3lhMxU8iJ2/RhAnLrOKLbPCryHsUVimuypQs1cKXTOr1IEpPXSUa4lFr+l+C 230zzR+WBnaId3YhUnxOjDeE8z7QEdaRrRcDTmWTt8E3mlVIuV1trKNNiIlfxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694710099; a=rsa-sha256; cv=none; b=UxbW37+Os0INEbYCugwNlBnw6gOz1E2NJzpXIBRK6v3BUQrdP59krZ4S3mM33J7EerHFEs y/DcgT3/hhIVlM3YSx4DlcOKjHPxBkwQ0+4jNH8Zg4vxOoz1ZF+8ZokGC9bqBlAcx50CLa dJJRJyk7XdxAAwhXtOKZnqUy+BMR63bPXsuPu3z8Qd592NoylZjBvur3dX2cEIyXGS+6az XsorHGXT7m8Ah26R7kcLD3MA/g4z1+UrtWjFIGQgz+HWP9VTtJMx7SPQ28LPs2Puw0Tw2H 3v5hEfcX4Q/9JWOtUshQK2Rv7YkyN40kbre0VSqSu8O2VtNc40fCIFnMFgiiyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VQ492IGL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgpV8-0002Kn-Vw; Thu, 14 Sep 2023 12:47:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgpV4-0002K7-Ip for guix-devel@gnu.org; Thu, 14 Sep 2023 12:47:30 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgpV3-0003DA-12; Thu, 14 Sep 2023 12:47:30 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40471c054f9so2334595e9.0; Thu, 14 Sep 2023 09:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694710047; x=1695314847; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1M2c4YFkz+HNZWP3TrTXIJ4ruwX+eMjqo+LpOaCJqb0=; b=VQ492IGLnuRFshQuBFlnZ7+9jpguJBqdA73iL/MPnoUgvcu0FE2NlGMBnmRGphNf8k xmnVMUL/L1ZZxzkwYR+aIxiPN6vjRFNmk02Ib2eqUQEhVs5fFEGXobRyDyUETeqLNtf2 f3IeFvu1/im1PYNNi1MXyMEkmhXTnDh8AzxwZkfTTa06kDMlYHComNy8nJMu3CG9BjX6 FyoYQg1yX9DTR2JUZUF7nr0kcBevJ9MiGtlwqsQ1QETtKDxyQftsISFJl1hIfaV9U8Wa X1n+TWXEETgVcinAy9FN8F78tUyOIPsafA6F5KIcfTNJpXwxerXtVx/7abNVbYQXpwM9 w9YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694710047; x=1695314847; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1M2c4YFkz+HNZWP3TrTXIJ4ruwX+eMjqo+LpOaCJqb0=; b=wMFMG1DgmrlF6LMK7dqT9hIYjomlyE/7oIDUcZ47FvzjEuBdN4uBO1Xn9dxQKr4R11 iU7ckvClP7RAdjgHR7IDP31ZPdXHLZMF2Hs5a28PiJtYto58Yer8zzv96mn4p9FIqM+h iGadeUrT60ab83bCqGRivAxXwfmVdjYSXO1hrlb2FSqk96PnZ3tsO55xieK9zFRS+29T Fcvuneiuw1RPp9b1w/dP9tVrVIlMWJ2ZcW1DnPyc44PHc0Uy/dqdmscG+OcUZ2+iWjiH akNsItumbOUuUp13WnyW5eL7HPUtLBqRWlA/OJV3fPysGC2fSxBUkZ0ZXsAlnbDxWcFw 8VNg== X-Gm-Message-State: AOJu0Yybv/rITySOt+2ob2XvuCMwFKo6pju8r2pOQ7X9xuHy9q+YObgw CL/7rpGYGzXOkay4oDKoRKhvIdbTZDY= X-Google-Smtp-Source: AGHT+IECgt5gM884/W0UKtXio6IF4GEfad9ZqgDUZ5b54nhWf03cXaTjQ+7txQbLBNPC5uqqPoSuNg== X-Received: by 2002:a05:600c:1c0d:b0:401:c07f:72bd with SMTP id j13-20020a05600c1c0d00b00401c07f72bdmr5192071wms.4.1694710046716; Thu, 14 Sep 2023 09:47:26 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f13-20020adff44d000000b0031c79de4d8bsm2192988wrp.106.2023.09.14.09.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 09:47:26 -0700 (PDT) From: Simon Tournier To: Giovanni Biscuolo , Liliana Marie Prikler , Maxim Cournoyer Cc: Vagrant Cascadian , guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: <87cyyl9hi7.fsf@xelera.eu> References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> <87h6nyw0su.fsf@gmail.com> <86zg1pwwmw.fsf@gmail.com> <87cyyl9hi7.fsf@xelera.eu> Date: Thu, 14 Sep 2023 14:25:37 +0200 Message-ID: <877cotdjr2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.98 X-Spam-Score: -2.98 X-Migadu-Queue-Id: 2EC765523C X-Migadu-Scanner: mx0.migadu.com X-TUID: NBMZKttS3EtW Hi, On Thu, 14 Sep 2023 at 12:27, Giovanni Biscuolo wrote: > Please can you expand what troubles do you see in automatically adding > 'Change-Id:' using a hook-commit-msg like > https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.= html > ? 1. The hook must be installed. 2. The hook must not be in conflict with user configuration. 3. The generated Change-Id string can be mangled by some user unexpected action. 4. etc. Many things can rail out on user side. For an example, base-commit is almost appearing systematically in submitted patches almost 3 years later. The patches of some submissions are badly formatted. Etc. Whatever the implementation, I am not convinced that the effort is worth the benefits. And I am not convinced it will help in closing the submissions when the patches have already been applied. That=E2=80=99s said, I am not against the proposal. I just have mixed feel= ings and before deploying I strongly suggest to review if the proposal covers the intent. Cheers, simon