From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eHSCLK9fRGU1LAEAauVa8A:P1 (envelope-from ) for ; Fri, 03 Nov 2023 03:49:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eHSCLK9fRGU1LAEAauVa8A (envelope-from ) for ; Fri, 03 Nov 2023 03:49:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 97ECC132B1 for ; Fri, 3 Nov 2023 03:49:19 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=bayesians.ca header.s=protonmail2 header.b=CbpnY+gI; dmarc=pass (policy=quarantine) header.from=bayesians.ca; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698979759; a=rsa-sha256; cv=none; b=hrJHGIQGkckzVSQm0c/gZ5+dRG4oyDFK9RLPqjbiNgNwM+H+c31fDT0lAnG9pJ78F3PiUV 4GpvVwZlXal8gcJZaY1KvU/qnWmNN9L5NK9pMbptOSGthsBijn9FbUNzfYnp41SnZ0OqFI /yuoV9H3Ab/TrzDuHuVUCbMUo+pQ7MPgd6K3JitNtnV4hy36TLsi/AUYK/4NvIlEBiATNo 0UnX5s4yAuVtlDOc5O/OUwOdAD+rmopO/NA7AWqIuoka8oBuSNPWqpnYOtgNwFqr8b2U17 VjRqidaiUdbkf5hFSY4yyoBwhq31y1Fn8arjx7ZjQkpywi1Ctqqnoga0R4ZNXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698979759; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=y5q6P5Xgeoy6JDXWbcrn0puw+Hb7q6hkd20w/xbc7aw=; b=L8a8XaXen2WTTtupz+qx0Y1csV9e85EHI+wWbqR6y2zahd1anZQbudxHyGRMFNNXMrGkoL rYyu9zKRQnfFPwg5hWU5OtbZ98ohxSyunOLeaHw9KuiKmf2Dayq0rmEYF45atWN2zMsahy QYyixc4/BX5PVg/z6oM053siDRWXq3dyEfRKyoIU9ahH7LASEFYMuk2Nf2eof4vpmn9RJd 8LsUK/ZJKlV/apz4Hp+y9/bLgsp6hmr1RNydvSihazISYaw0wZoUbRkG14jjp16etx4Fgb clkdCHUN6L6/82tBGhCv5tJG5wbuT9XNPG7w3lBXk0F1w6mJeONsSM/N9gmaLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=bayesians.ca header.s=protonmail2 header.b=CbpnY+gI; dmarc=pass (policy=quarantine) header.from=bayesians.ca; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qykEh-0001TX-0x; Thu, 02 Nov 2023 22:48:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qykEg-0001TM-3Y for guix-devel@gnu.org; Thu, 02 Nov 2023 22:48:38 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qykEc-0002pi-HF for guix-devel@gnu.org; Thu, 02 Nov 2023 22:48:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bayesians.ca; s=protonmail2; t=1698979710; x=1699238910; bh=y5q6P5Xgeoy6JDXWbcrn0puw+Hb7q6hkd20w/xbc7aw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=CbpnY+gIOu22tgEcs1eShnIq6VZnSyNVlPCUOyH8M9O6z8wLliX38lY97e4CPVjFe sisYeToqf2aUYPVRzGY9kZtG1caQ07HkozWnDHyq2sYw0KIRFpkshmzFbb0uDn2x9L UruT+jGSnmrqGa+PpZs9x69WpoqKFrFa+mx3xdHqshA0oYKnIlq17hEi2NEhRNpZUh 1/ng48o26uIi2iQ3+F/7rkrVKJvWEZAp6o5O7WB6LZP6wl0j7mDwQzg91qjWuvyk+t RJl76BbfreLzJYE3Q14netShTUlXT2lwbOiIRV5lo48n5hXznK638Q15tQ40BRX72O XKrUl7qneIyog== Date: Fri, 03 Nov 2023 02:48:20 +0000 To: Christopher Baines From: Suhail Cc: Suhail , guix-devel@gnu.org Subject: Re: August/November update on qa.guix.gnu.org and related things Message-ID: <877cmzd027.fsf@> In-Reply-To: <87pm0ropfw.fsf@cbaines.net> References: <87pm0ropfw.fsf@cbaines.net> Feedback-ID: 38691229:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.17; envelope-from=suhail@bayesians.ca; helo=mail-4317.proton.ch X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -7.19 X-Migadu-Queue-Id: 97ECC132B1 X-Migadu-Spam-Score: -7.19 X-TUID: HeGq12vH4+TF "Christopher Baines" writes: > There isn't much documentation for QA Understood. Is the preferred place to ask questions regd the QA service this mailing list? > I think it's fair to say that these shouldn't be styled the same as > failed builds, so I've changed the styling now. The neutral blue works better; thank you. On a related note, the specific build status on data.qa.guix.gnu.org for the "now blue" entries is "Scheduled". Why does that get presented as "Unknown" in QA? IMO, either "Scheduled" or "Pending" (in case it's important to maintain a distinction from the build status of individual jobs as on data.qa.guix.gnu.org) would be clearer than "Unknown". > I've also added a new issue status for when QA is waiting on builds to > happen to provide more information. This being "Investigate"? Out of curiosity, and in a similar vein as above, why not simply "Scheduled" or "Pending"? Or is it that it has had "Scheduled" build jobs for far too long and thus requires someone else with more privileged access (than myself) to investigate the cause? I.e., Investigate is a verb and thus makes me wonder what the object is (what needs to be investigated) and who the subject is (by whom)? Shouldn't the QA issue status be an adjective instead? > So yeah, QA isn't currently pointing out anything for you to do on > this issue. Okay, thank you for the clarification. > There's also some content in the manual that might be useful when > reviewing patches: > > https://guix.gnu.org/en/manual/devel/en/html_node/Packaging-Guidelines.= html > https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.ht= ml Perhaps linking to these from the "Mark patches as reviewed" section on QA would be helpful? > But there's no pre-requisites to reviewing Guix patches, so the best > way to learn is to start looking to review things. I imagine some of the "common things to check" will get automated in the near future (e.g. whether or not the changes are adding to the lint warnings), whereas some others will stay manual (e.g. are things "well written"). Personally, for such subjective measures (i.e., the latter) I find having some examples of "what good looks like" readily available quite helpful. In case the intent is to make it easier for newcomers to the project (i.e., those who've not yet internalized this knowledge) to contribute, providing such prototypical examples by linking to commits, descriptions etc in the existing source tree would help. --=20 Suhail This email is not an offer capable of acceptance, does not evidence an intention to enter into an agreement, has no operative effect until a definitive agreement is signed in writing by both parties, and that no party should act in reliance on the email or any representations of the sender until a definitive agreement is signed in writing by both parties. This email may contain information that is privileged, confidential and/or exempt from disclosure. No waiver whatsoever is intended by sending this e-mail which is intended only for the named recipient(s). Unauthorized use, dissemination or copying is prohibited. If you receive this email in error, please notify the sender and destroy all copies of this email.