From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aAy5Nt8ZzmVzKAAAqHPOHw:P1 (envelope-from ) for ; Thu, 15 Feb 2024 15:04:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id aAy5Nt8ZzmVzKAAAqHPOHw (envelope-from ) for ; Thu, 15 Feb 2024 15:04:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=apatience.com header.s=protonmail2 header.b=i5CcCB8K; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708005855; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2q8/PQg/hAWlYtpKZXiUt0J4s4X39tv04+eRqfiXzOA=; b=LUmGVJxpXJmmteybE+a/ipv3/14PnQdMhg2luOGPBdhIExlLGY4fHL8Xa0/Nj0leBYdDPS PDh2CCDTGDcu/XIgcZEl5ZiR06wTxguUg1Vkwc2trzpiak4s7DbVJj6fH47nDaqT7hwPHN IZdnC6o8cFI+8ul8MXladh33QPP8FMmvCcTlGTmjcEsfanbc/MmfuSk6irLyqufTWrdIuB ghYN2vdgOIbum6A39ZUOo69G/6A+MdOfFYX4FVCgvUgfCRl6w+7Nq+SZ9oixyaxnyOjWum OM3DC9LQ13YWX9FxCEMoKtYRYrGOFQTJuZsuQC/P8h1KXU420MohfFzNXnEvPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=apatience.com header.s=protonmail2 header.b=i5CcCB8K; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708005855; a=rsa-sha256; cv=none; b=tGnhisCPuA3udVN3/4soDOPYtc6OwRWF+SKTDCSiJIB9mjyT6jOYwNBX8MT8pa9IkPZA8D gHvc+O9Tvto4dGBxEu+OX6XlwAYgchNvRqXd8LFS9UA5RL9OkczfpD/aCIjAMWkZsFmD8R mKpDHo81MFoEYWnA+J8v3gE48BfhDVxgGpGreWpmGpibUNJYX52CacmeUbiYvHMf2qIggM a14JYHIwM9SPfqO6hB9Tg9FqaFZ3Ty2/A5yyGyUmCwacRt0ZPNfz+aUl/5yekNRYdYxBsN rvvRLUfRzPW1Iu2f5YebL5J2TkqhbWjC2JND7IwB7RvIImxucoQp8J2TG+qzIw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3ABA3C964 for ; Thu, 15 Feb 2024 15:04:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1racL5-00069t-AT; Thu, 15 Feb 2024 09:03:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1racL1-00069L-TP for guix-patches@gnu.org; Thu, 15 Feb 2024 09:03:43 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1racL1-0004Wi-Kz for guix-patches@gnu.org; Thu, 15 Feb 2024 09:03:43 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1racLK-000743-2d for guix-patches@gnu.org; Thu, 15 Feb 2024 09:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69126] [PATCH 1/2] gnu: Add debug-assert. Resent-From: "Paul A. Patience" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Feb 2024 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Skyler Ferris Cc: 69126@debbugs.gnu.org Received: via spool by 69126-submit@debbugs.gnu.org id=B69126.170800581127116 (code B ref 69126); Thu, 15 Feb 2024 14:04:02 +0000 Received: (at 69126) by debbugs.gnu.org; 15 Feb 2024 14:03:31 +0000 Received: from localhost ([127.0.0.1]:54709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1racKo-00073H-Nv for submit@debbugs.gnu.org; Thu, 15 Feb 2024 09:03:31 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:18833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1racKk-00072w-LW for 69126@debbugs.gnu.org; Thu, 15 Feb 2024 09:03:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1708005780; x=1708264980; bh=2q8/PQg/hAWlYtpKZXiUt0J4s4X39tv04+eRqfiXzOA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=i5CcCB8K1lrIVE7s05gppfRsuGs9ANr51hjsmnPnMgeI1qTRzb6CZNH0NqWRB3QqT yU2G6WbH0lj6GM+nLDz3LpumRlbQA3gpI3HttRVxRxMeZdSSB6+CtjmSKtOJofYDYc 0CtO1D4Ld4nWWWgMtYXFtL+ezVbSqEJ21nWEA6hhcZep4D0nNZfRytd9Zfg85CqZXz xWC//fO7g+kchCttMswkCZVCM9wutPSmyXfM37r4YLZVVkkVAR4XulP8d5lIL6EAFX sYAVotzrr4i0gNMi8Zkq6NcaaoTcP/As3Sbb8JmIsv7FoicnhELNkiVNa6FoPJp4hn Ay5BGqB7pf5Qw== Date: Thu, 15 Feb 2024 14:02:42 +0000 From: "Paul A. Patience" Message-ID: <877cj5n7uq.fsf@apatience.com> In-Reply-To: <3bee2280-c098-4c23-9161-6d3c5a487768@protonmail.com> References: <0191a95edf076b5cd24326d49e54ce13f2bdb0d4.1707924715.git.paul@apatience.com> <3bee2280-c098-4c23-9161-6d3c5a487768@protonmail.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.48 X-Spam-Score: -5.48 X-Migadu-Queue-Id: A3ABA3C964 X-Migadu-Scanner: mx11.migadu.com X-TUID: oQe+xstOehYS Hello, Thanks for reviewing my patches. On 2024-02-14 16:29:05-05:00, Skyler Ferris wrote: > `guix lint` issues a warning that the beginning of the description > starts with a lowercase letter. IMO this is reasonable because the first > word is the name of the project, and it is a common convention for > project names to remain lowercased (the README in the project follows > this convention). However I am not sure how the Guix maintainers > consider this. I was aware of the issue, and I share your opinion. Sometimes project authors write the project name lowercased but in a fixed-width font, in which case I use either @samp{} or @code{}, which guix lint does not raise an error for. However, this author does not, so I left it as such. For what it's worth, I counted a few hundred instances of a lowercased project name without @samp{} or @code{} in the first line of the description across the Guix codebase. I will leave it to the discretion of the committer. > The arguments form is attached to a comment saying that there are no > tests, but it looks like the repository does contain a test in the > `test_package` directory with a separate CMakelists.txt file. I haven't > spent much time with the cmake build system in Guix, would it be > reasonable to replace the check phase with a procedure that uses the > file in this directory? If not then it might be helpful to replace the > comment with one explaining that, while tests exist, it is not feasible > to run them for some specific reason. The test_package directory seems to test the installation of debug_assert with the Conan package manager, so there is nothing to do here. Best regards, Paul