From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +GTjHgq7QWarCQEAqHPOHw:P1 (envelope-from ) for ; Mon, 13 May 2024 09:02:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +GTjHgq7QWarCQEAqHPOHw (envelope-from ) for ; Mon, 13 May 2024 09:02:34 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715583754; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+jNlGFtCQXKN6oAGcLVOazFpO0vfydZkU4phe6q+GOE=; b=WufsFjY3mfrjpg21QIsfX1KGSX74MUTnmMnt20IkF7yibxNigjGeK5Pw/1rx4Yx6oClCvj EVKlkvjxO3A5FHLSIzJphHyvqYsjQwaI3DJn/IIdNSwhHe5d69+2Dt1F8x5UWwrE5qJuyg qvBlmPCqjLFIO88Uzr5sB0P/mGmtSXvl5MaeBtDngjJpuVvqKBvabCQ1UxQslDBhi98JYp d5rq8pMbZcUsU8QaQiEUA2UR5lM/0KLlccxIxojq/3tMNlxZMhP+VColK+ZlEGTAygAgMi glRVkip40RZpyS2tQe77STdikFed/HuOgQIXehpYHzzf4En5mmuJFaee+dbt3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715583754; a=rsa-sha256; cv=none; b=Oz3DRIJE48NHgqiM+/x4IubP9cy0xbqjgai+JRx6dnVKaZxMEpegEKKChn9jOIR6fvJ2kd szwtV0kqWQQrh0lH/xb4clg4qiQg2Q25z+Z2c/voRsIIWu5eBf0AGcmYuk2BE0V7uIdVkN HLCfZ7gag2bjg/4CufFOml2TjahKKtXA09u1KaGijZIwxtKxFPVkylaPbIzOzAeVulKJMu OhlVt04c0sHOOE4oGuejTNIeXAoqn0svQI28O5r8riYEj31sNS0V7A3C++JePasm1kNcgn /c8yYe7/o00L0FmHQ7qiTqGLW4wXZMClnCbnruh0nehSUgb0rEu2jhiNp9XOHw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA5586E815 for ; Mon, 13 May 2024 09:02:33 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6PhE-0004iN-IM; Mon, 13 May 2024 03:02:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6PhC-0004i6-Ho for guix-patches@gnu.org; Mon, 13 May 2024 03:02:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6PhC-0001fn-8k for guix-patches@gnu.org; Mon, 13 May 2024 03:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6PhC-0003Lb-Bb for guix-patches@gnu.org; Mon, 13 May 2024 03:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70563] QA review for 70563 References: <356e77d1fbad51a042ebb8eaae2804bb74a30c9b.1714036907.git.atai@atai.org> In-Reply-To: <356e77d1fbad51a042ebb8eaae2804bb74a30c9b.1714036907.git.atai@atai.org> Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 May 2024 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70563 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: control@debbugs.gnu.org,70563@debbugs.gnu.org Received: via spool by 70563-submit@debbugs.gnu.org id=B70563.171558371412860 (code B ref 70563); Mon, 13 May 2024 07:02:02 +0000 Received: (at 70563) by debbugs.gnu.org; 13 May 2024 07:01:54 +0000 Received: from localhost ([127.0.0.1]:58949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Ph4-0003LM-4F for submit@debbugs.gnu.org; Mon, 13 May 2024 03:01:54 -0400 Received: from 9.mo550.mail-out.ovh.net ([178.32.108.172]:51781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Pgy-0003L3-AE for 70563@debbugs.gnu.org; Mon, 13 May 2024 03:01:51 -0400 Received: from director6.ghost.mail-out.ovh.net (unknown [10.108.9.167]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4Vd9QL0PKsz1RBf for <70563@debbugs.gnu.org>; Mon, 13 May 2024 07:01:46 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-p287t (unknown [10.108.54.3]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 880391FE8C; Mon, 13 May 2024 07:01:45 +0000 (UTC) Received: from ngraves.fr ([37.59.142.96]) by ghost-submission-6684bf9d7b-p287t with ESMTPSA id 2utRGtm6QWahxCsAi4XVJw (envelope-from ); Mon, 13 May 2024 07:01:45 +0000 X-OVh-ClientIp: 80.214.128.58 Date: Mon, 13 May 2024 09:01:44 +0200 Message-ID: <877cfyci07.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 13463792562812936715 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdegfedgudduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeujeelieeljeffhfelteejtdeljeehveduffelvefgudefkeehgfdvvdevgeevfeenucfkphepuddvjedrtddrtddruddpkedtrddvudegrdduvdekrdehkedpfeejrdehledrudegvddrleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejtdehieefseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -5.37 X-Migadu-Queue-Id: DA5586E815 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.37 X-TUID: j9lpEEfMoE0r user guix usertag 70563 + reviewed-looks-good thanks Guix QA review form submission: The description probably needs a little bit more precision. In particular, it would be good to include the statement "PKCS#11 is the de-facto standard to access cryptographic devices." or something like that. Otherwise LGTM. Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests -- Best regards, Nicolas Graves