all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: control@debbugs.gnu.org,70563@debbugs.gnu.org
Subject: [bug#70563] QA review for 70563
Date: Mon, 13 May 2024 09:01:44 +0200	[thread overview]
Message-ID: <877cfyci07.fsf@ngraves.fr> (raw)
In-Reply-To: <356e77d1fbad51a042ebb8eaae2804bb74a30c9b.1714036907.git.atai@atai.org>

user guix
usertag 70563 + reviewed-looks-good
thanks

Guix QA review form submission:
The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that. 

Otherwise LGTM.

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests

-- 
Best regards,
Nicolas Graves




  parent reply	other threads:[~2024-05-13  7:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25  9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
     [not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
2024-04-30 19:21   ` [bug#70563] Acknowledgement ([PATCH] gnu: Add pkcs11-helper.) Andy Tai
2024-05-02 21:21 ` [bug#70563] Andy Tai
2024-05-13  7:01 ` Nicolas Graves via Guix-patches via [this message]
2024-05-13 12:34   ` [bug#70563] QA review for 70563 Ludovic Courtès
2024-05-13 14:09     ` Andy Tai
2024-05-16  5:42 ` [bug#70563] [PATCH v2] gnu: Add pkcs11-helper Andy Tai
2024-05-22  5:34   ` Z572
2024-05-22  6:16     ` Andy Tai
2024-05-22 17:31 ` [bug#70563] [PATCH v3] " Andy Tai
2024-05-23  5:34   ` bug#70563: " Zheng Junjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cfyci07.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=70563@debbugs.gnu.org \
    --cc=control@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.