From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uHwGKZ9JkmaBTwEA62LTzQ:P1 (envelope-from ) for ; Sat, 13 Jul 2024 09:32:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id uHwGKZ9JkmaBTwEA62LTzQ (envelope-from ) for ; Sat, 13 Jul 2024 11:32:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ZFq9fIgf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720863135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2pcgyGlKn21FBPcaYqHvPUxUqhoK3qNB/E5ND1Wl45M=; b=orCWWgNF0+ioWkQETxdmkAkfIpPqHPI54ueeyZTgeneK18gfZEb50IXxRnrlGBJQ7P0SLt JNB2x5MGzSLtf7PtllXg9/dkvqR8BmhN+dyPhJtk9Vdxjdz+jVpelpW9hKXHgCnyeAicW+ LWy7NyjWGKhor5CkoKWjR8EwLUrcCy9yHV9GIbKCGM1vAcVpyVxLreqB7OoZdHSiucdLUY +puEv2dI37CNEzw1hYIBNkjsddRfL++h3hwsFjpm+chiPBEroSu4VKOaKHCStelH2ZBwxN ovdDpWhMy5hXs260dAzFaZXjaXsa1Q3SYcA7NBSOuFuhFHFQVjTzpRvbT4s2Bw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ZFq9fIgf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720863135; a=rsa-sha256; cv=none; b=HzWnzzThmvkt0B5CB6+TNSXaNfJw1Hrrh88j3/pvRbKGVM4GrjJWAH1mqcOLawOCGIZ7G9 NdDcsYmHMTOT+9/UZdnH5+s+dXjLz9TzAb7ckGN372RS47hCKj8/b2JJ/GqZQSYqUqIK/C 121IvtlxXmxPgDvwLn6sCAMopTJy64XsYVhOKSwEozg40E1LOupX/QAAOUmGgkVNwArfFh boAPwHx4/pIBhKStJEK4yED47xaIWTj9kRNDgSGa2FwZxmUccyG/F8ZLua9DeQfNUHIDVK GyjaZluuc4RpOexKSVa5rRqCPcBYnIIaaGFggtgdFUx2zD9n30aR3QS0u0BuUQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42256212D2 for ; Sat, 13 Jul 2024 11:32:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSZ6o-0004GB-M7; Sat, 13 Jul 2024 05:32:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSZ6n-0004Fn-DR for guix-patches@gnu.org; Sat, 13 Jul 2024 05:32:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSZ6n-00011j-4d for guix-patches@gnu.org; Sat, 13 Jul 2024 05:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSZ6n-0000NX-QN for guix-patches@gnu.org; Sat, 13 Jul 2024 05:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70880] [PATCH v2 4/8] gnu: libigl: Update to 2.4.0. Resent-From: "Artyom V. Poptsov" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Jul 2024 09:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Maxim Cournoyer Cc: 70880@debbugs.gnu.org Received: via spool by 70880-submit@debbugs.gnu.org id=B70880.17208631211447 (code B ref 70880); Sat, 13 Jul 2024 09:32:01 +0000 Received: (at 70880) by debbugs.gnu.org; 13 Jul 2024 09:32:01 +0000 Received: from localhost ([127.0.0.1]:55110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSZ6m-0000NH-Io for submit@debbugs.gnu.org; Sat, 13 Jul 2024 05:32:00 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:60536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSZ6j-0000N2-E7 for 70880@debbugs.gnu.org; Sat, 13 Jul 2024 05:31:58 -0400 Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52e9f788e7bso3255175e87.0 for <70880@debbugs.gnu.org>; Sat, 13 Jul 2024 02:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720863050; x=1721467850; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2pcgyGlKn21FBPcaYqHvPUxUqhoK3qNB/E5ND1Wl45M=; b=ZFq9fIgfRk+TqBvi8n2OCXINbStUcqxor6uroVCM0vXNjpWcHb1srgaN6/LYqujBo2 4vtKtPmD5kPkMNwMfhDKBQrDM5/Pf/Nzl8nxKT3YkLiKI4RRJJzLNipRd+YGcZJjFXah d2liCgmTav/wTRILnXZWPPWxg7J40mmhMIL+mx2h9Hysl3u3WuNgdVr/Qnmqz1bLY5xk zYqoCMGmTKmu0f9Q+zCX1YnFXo8pTGB4HqM2RZwYdYAL6Q1LqN9wlLauh8/4kW88LqiJ lkTMo60XonvRqe94bXdmIzvuamq3q5ppPXTXfD6441HVS4mKZUjIlWj1wcrt3FyKUYX/ V1ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720863050; x=1721467850; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2pcgyGlKn21FBPcaYqHvPUxUqhoK3qNB/E5ND1Wl45M=; b=GcFsoMjB4hKO4NUuCkCpYUtqIRBruOdZ9dDhfcgPyQFDpnBbxg9OeLuwLN6uN/zTyu Hyh0sbuunnYzV5FSkT8P2Wzmyt9O+WRsy/J1lvIItJwLIwd/7oXL+BeSLB2OKl94i7Kc 9Zp+UZr87BndUJWmNwLQoAD1dfysm9PRipmh1Aj/QkZk01c0Pp0aSqC5HhMTwUlG1VEY Q9ESw15l5nsagXVCjLCBMBnG/sQXKQHYrFrf0Po56WdUb9on03cswiL69Cu55go66hbZ /C4E1BHSb5eiotqLSEGGSEao7PeyYanMui2d8fGYtHiJYMa2dYhz8m9cLFTSA1jf0MYZ 5yFA== X-Gm-Message-State: AOJu0YwuVp+E8Euo7O3/NmCA0p9ZZnYJ8rfTKr/SLsP+z/AeoBK/AO9a e5ngQ94Y80lTjwbAiiy/+/VsbxxicPTNfPeZAucs7RZ60V2XHDdDwmdDVw== X-Google-Smtp-Source: AGHT+IFx402CE4qqMUvexIW2OaRY7znGhy8o1bbAMHnT1KnSM9ORfUWSM4lDnvfBJeaxzsb5GaKq6A== X-Received: by 2002:a05:6512:4011:b0:52e:9d28:c288 with SMTP id 2adb3069b0e04-52eb9991705mr10256474e87.24.1720863049486; Sat, 13 Jul 2024 02:30:49 -0700 (PDT) Received: from elephant ([95.79.4.1]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ed25398d2sm125126e87.287.2024.07.13.02.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jul 2024 02:30:48 -0700 (PDT) From: "Artyom V. Poptsov" In-Reply-To: <875xtevvgl.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 09 Jul 2024 22:20:42 -0400") References: <09e99660acf1973e62ba21b25e5d3e2cceaa5921.1719853592.git.poptsov.artyom@gmail.com> <875xtevvgl.fsf@gmail.com> Date: Sat, 13 Jul 2024 12:30:37 +0300 Message-ID: <877cdpabb6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 1.00 X-Migadu-Queue-Id: 42256212D2 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 1.00 X-TUID: kEz9DK2CZDd+ --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello! > Nitpick: no need for hanging indents in GNU ChangeLog messages. Okay, fixed that. > You'll want to break these long lines; we aim to limit line width below > 80 columns. 'guix lint' should complain. Done. > All these FetchContent substitutions could perhaps be unnecessary if > they were referring to the right package name and with the use of the > -DFETCHCONTENT_TRY_FIND_PACKAGE_MODE=3DALWAYS configure flag, which forces > CMake to look at the packages from the system and fail if they aren't > found instead of fetching their source and building them. Unfortunately it seems that it does not work. I checked it and cmake wasn't able to to find libraries. I'd prefer keep this as it is. Maybe I'll figure out how to do it in a more effective way later. > The rest LGTM, although it'd be nice to modernize the definition to use > gexps and remove the input labels. Not sure how to properly handle things like this without input labels: =2D-8<---------------cut here---------------start------------->8--- ("libigl-test-data" ,(origin (method git-fetch) (uri (git-reference (url "https://github.com/libigl/libigl-tests-data") (commit "19cedf96d70702d8b3a83eb27934780c542356fe"))) (file-name (git-file-name "libigl-test-data" version)) (sha256 (base32 "1wxglrxw74xw4a4jmmjpm8719f3mnlbxbwygjb4ddfixxxyya4i2")= ))) =2D-8<---------------cut here---------------end--------------->8--- I'd prefer to keep input labels for now as it is more stylistic change and does not affect the build. =2D avp =2D-=20 Artyom "avp" Poptsov Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJNBAEBCgA3FiEEAf2F9Bp7f4IFgwalk16+BzbchX4FAmaSSUMZHHBvcHRzb3Yu YXJ0eW9tQGdtYWlsLmNvbQAKCRCTXr4HNtyFfnpIEACAp8RA3R442ChLliuMDk8x kb6bs56wvtJzcRyIEgA/Fj3mUuVHIehWxugxn72w1DYmbPQDH6EqTjzFyaJR8BMi b/Vp7CcCJzMglZ5DvavucaSCDLFXyvgC2is/R9YOv2b5GcskK0en+m0tL7dctD7v +RSnQvgjFw/rL0eiXpAYwAgNPrCKs01tJSI1LFw3VwvTgYY6cfZuV3MikytBZ5vn xMetIRZG29wP3gSy1nUf6T2FZMn0S4+/za17DiDBExzcENmZYy8u1WMDC6+HFH7A p5SbROg6HB0le3LQ9hhbaLlShh95dhbYxPiw1Nkz1h5QUP8BktS54I9rGHibycWq 06GrxsIeInClxaOGgzFNYVw0Q0y2PoZJFqO9X1GWfvoJLSiQXYqxtHxHLU9wep/o 1VUB/kFL7bRSMPejt5Qdkbyy1CnaDrTDQob6qSSApfVWgcKsp4Q+6v3uJizCqYUB goRTsrEDMFc6GfXwTAtMcz1nl3sN0zExkAdWJzd3n6gn984bWzOKMKhmVzBKABtf DUTM2xy2GrLNDrb/QRLGlj/b0nQbN75OfZ4DCuGTzBoI5telsaexiRCLOvz6CWbX 5GKl2WtYagLFE0qFw38ibzhCxVBhlMxJMM9ur3A5A4nEVsmIDr/mcXWYf0lIVD/n UXcammV90CoxMRbOWDskTA== =If/4 -----END PGP SIGNATURE----- --=-=-=--