From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sNF4AK6FmmbYFgEA62LTzQ:P1 (envelope-from ) for ; Fri, 19 Jul 2024 15:26:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id sNF4AK6FmmbYFgEA62LTzQ (envelope-from ) for ; Fri, 19 Jul 2024 17:26:38 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=FFanmKNA; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721402795; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ml13MDcCOqAaaNN177PrmRZgUYke9F90VvO4sw0/e/o=; b=JCkNmWkYCH/LwCK0VV3RzQ//VtG67cKd+nIVGzqMDsTSdI2/oWmp6tGMvYCRYjgDmk4ooZ LQ8RE5ZaP+0iDfOt+Ao7rEnF8uIYqjTTcQJphTA+qk5zrbbZm3+aN4Gdqro6njiSMcYU93 xXNvr1Ckuu6lRWrfJL8LYFpSzYA2ZQ6/zZ/K6pHhWmIvEauTli6vdYziTDYnaEkkozgp94 7QpsIuVepWrH4kRw4H5lDfbkS1i2kx+UjajuRS0Ct9kzTXYgJzQVLgZOOISRfg/sgi2Qpa OToi8egHJmntCUsWrubKM9QY7rQhVt4YsdA+s6M65BBajHwK5dzqZGpFrDVOwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=FFanmKNA; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721402795; a=rsa-sha256; cv=none; b=U5lDv91jwQsb5Ncu5jyFQOkNo9k3pguY4F7Zghg+mDfEt6f2gaHM3Bw+8VCZhr1w3pvosz zB9JNJ3qTl2sfiiTL4sDO5qpx83xnHDu7xyqGHmsaY37t3VyVALVVlrv4rKK33m82kM0mn 1lq6T1b4q/1A6+vOiKpJ2aSNU61LqubsGvoSTamefoabayli9vA/UaFESSRnDWPiwHyvCZ LLy567uP7TaN3prCpMs/f0g26bCQRxXbb0j9DK99UZe4vYTUO1wPo2a8o4GtQLUd3yBbMo Ajt17FRwsLFUJFux9VTR9z+JqB9xSGXiUbbv4KLuFjHpv4uf0GxRLkeoA4Xk0g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83BB56BB68 for ; Fri, 19 Jul 2024 17:26:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUpUi-0006Yo-R3; Fri, 19 Jul 2024 11:26:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUpUh-0006YW-EY for bug-guix@gnu.org; Fri, 19 Jul 2024 11:26:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sUpUh-0001sh-6X for bug-guix@gnu.org; Fri, 19 Jul 2024 11:26:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sUpUg-0001No-5Q for bug-guix@gnu.org; Fri, 19 Jul 2024 11:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#72045: [PATCH v2 1/2] gnu: Add system test for Emacs. Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 19 Jul 2024 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72045 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 72045@debbugs.gnu.org, Suhail Singh Received: via spool by 72045-submit@debbugs.gnu.org id=B72045.17214027165265 (code B ref 72045); Fri, 19 Jul 2024 15:26:02 +0000 Received: (at 72045) by debbugs.gnu.org; 19 Jul 2024 15:25:16 +0000 Received: from localhost ([127.0.0.1]:50201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUpTw-0001Mr-8u for submit@debbugs.gnu.org; Fri, 19 Jul 2024 11:25:16 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:38979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUpTt-0001Me-M7 for 72045@debbugs.gnu.org; Fri, 19 Jul 2024 11:25:14 -0400 Received: by mail-qk1-f193.google.com with SMTP id af79cd13be357-7a05c23970fso3815285a.0 for <72045@debbugs.gnu.org>; Fri, 19 Jul 2024 08:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721402649; x=1722007449; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ml13MDcCOqAaaNN177PrmRZgUYke9F90VvO4sw0/e/o=; b=FFanmKNAGu7aVdVL5mQKpHQkfPvqpBanzGK9ksft0xea8XG9s4Lyyy8Le9pbNfI7g6 Nh1HbWnZHytaChp6rdh5FaRkc6ZxW03uZ1y7B4B8HzUfErRqZAcRunAVVX/rfGpIHrLx F16+dwjDOm94P/X5Y9VgoKPXEaOQwqLMiygRYFPS0wG+tWgpLCIPzX2suW45Clo0scUR /vZeIThXO9y7iJK5krH5uXSHmZxn+3z9p3xYiLdGYlrH7+9jfwZl3JiM49l+P24fexAC zxVxPriWvBBbqbD3RTKB4SR7iyIdbQdccRUKZG3obif6M3o1PuWe9SyGvSaexJi9+s4R DRBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721402649; x=1722007449; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ml13MDcCOqAaaNN177PrmRZgUYke9F90VvO4sw0/e/o=; b=wHUrXJOpcMLN35kWqr7PduFJyqdzE1G4P8dlTybuBeu8pYKrQXIUX5ddwdLQJGyYvr pnnlWk8i5LphdgH9TAVaItQ1ZNMe6nVOxgIw814p9gJhdyXRmecHSF/hu7rEkS0fDI+e ClOwDjK8K1MQNaDC8PcMoMVVFLH1D4RSyYMDgSoOJ2JbGk/qxeb11iYx1svjr92+VMuX ey7IqZdHrjHfD2JRs/C7tmgVR9XzGzDOKKOeoE6vlsPyVxgGV9BwbfS0IkNXA0kpYNr5 Ngc153PoDE8uuTf6oFCyRpaj2qAldZBLDbphDEUfP5QIoPvI+hEuDXNY02lSYDu2+NCW I1ZQ== X-Gm-Message-State: AOJu0YwAnxfzOAUsgSxpz4eREKCfjaSxrSYAYShzX0KuzpWKxhX3tLk0 tJFM/H8ZwVAZ+O3e0mT2lU9p2Por4pV5A5T1FMf3EV44S65kG5Bh X-Google-Smtp-Source: AGHT+IEb/cMr8hlISMlXH+zN2QWYfBGhfHi2rs3O4IrVSbR6dcvyBrPnvIMNU7VqoGfBIOMn0bLYQw== X-Received: by 2002:a05:620a:404b:b0:79e:f8e5:3523 with SMTP id af79cd13be357-7a1a132c186mr13246985a.3.1721402648725; Fri, 19 Jul 2024 08:24:08 -0700 (PDT) Received: from gnus ([65.93.169.47]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a198fbfb73sm94705885a.46.2024.07.19.08.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 08:24:08 -0700 (PDT) From: Suhail Singh In-Reply-To: <6c20a4fd1a6225f062b019d79e090399785470ea.1721377800.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Fri, 19 Jul 2024 09:35:34 +0200") References: <6c20a4fd1a6225f062b019d79e090399785470ea.1721377800.git.liliana.prikler@gmail.com> Date: Fri, 19 Jul 2024 11:23:57 -0400 Message-ID: <877cdhv20i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.59 X-Migadu-Queue-Id: 83BB56BB68 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.59 X-TUID: OKpj58F+VJYW Liliana Marie Prikler writes: > + (test-equal "native-comp-dir" > + (emacs-native-comp-dir > + #$(file-append old-emacs "/bin/emacs")) > + (emacs-native-comp-dir > + #$(file-append new-emacs "/bin/emacs"))) I like that there is a test that focuses on the native-comp-dir directly. Having only a test that focuses on ABI_VERSION wouldn't have been sufficient IMO. Minor nitpick: However, there may still be some utility in either having an additional test for ABI_VERSION or adding a comment that a successful evaluation of the above test also implies that the ABI_VERSION matches. > + (test-assert "old emacs has hierarchical layout" > + (file-exists? > + (string-append #$new-emacs "/lib/emacs/" > + (emacs-effective-version old-emacs-bin) > + "/native-lisp/" > + (emacs-native-comp-dir old-emacs-bin) > + "/preloaded/emacs-lisp/comp.eln"))) Should that say #$old-emacs instead of #$new-emacs ? > + (test-assert "new emacs has hierarchical layout" > + (file-exists? > + (string-append #$new-emacs "/lib/emacs/" > + (emacs-effective-version new-emacs-bin) > + "/native-lisp/" > + (emacs-native-comp-dir new-emacs-bin) > + "/preloaded/emacs-lisp/comp.eln"))) Do we need to additionally ensure that the new emacs' "hierarchical layout" matches the old emacs' "hierarchical layout" in some way (over and above both having them)? > +(define %test-emacs-native-comp-replacable > + (system-test > + (name "emacs-native-comp") > + (description "Test whether an emacs replacement (if any) is valid.") > + (value (run-native-comp-replacable-test > + (package-without-replacement emacs) > + emacs)))) Ah! So that's how it's done. I am not qualified to review this part, but this looks to be in the right spirit. Hoping this is merged soon.=E2= =84=A2 --=20 Suhail