From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QLMFAr+Nm2aJLwEA62LTzQ:P1 (envelope-from ) for ; Sat, 20 Jul 2024 10:13:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QLMFAr+Nm2aJLwEA62LTzQ (envelope-from ) for ; Sat, 20 Jul 2024 12:13:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721470398; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=slFTogcEBa1OlkQ2qrnV0PVpDkZyXLIhWVtbg1oSGcI=; b=VyCwwy0g3rS53JtvDzzN8bjTM47Yw3nb3CeZnyGrFe5rHg+6cZ5SFea4rhV+Iv/jh+XJgJ 4PRqiDoRuXr8XVCmuAZp3QlScnE95jYEMqFL59cUz9xOYkYAxfjXL61Hkw8UTa7BprJ5sY scAiRyTSvqCplkkCpKqOTLiwrqZvKK8jUpindzFIpYkinSJFIiVWhpX7I8MNh8VAH6D0Ss vRjP0iWb80LX4swcQLFKpmlc7jD+ikTJRxLcEiXLwTezXmXXV4q2TaOVePeXTxSascXApk 4EE0fw0TKI2dxWNP9QzuLm3L3e2oyFawNcJj7KTll6VyLMYsG+921quMzzQ9hA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721470398; a=rsa-sha256; cv=none; b=CuAntRlHIZo5MCJQvnNbhIlI3JD5IEnhsn73dxWpIBq8zxsrdc6BFKbMbfSdhrG/KpbBnc W6Dv/oTX50z63L77nJqFOO/DZATOeV3bR28/PJ8OzI70i3u1AMb2yQjy2CBJnmXJXRNzZa wN3DX5ssvPgIlWNI7G6fjcf6SZfpgx3DhNhRqe8ibSbiFpmPz1Zapz/VVv36Ki9UUw/YrT 92Uqc7eElWHrAFDfZfgsaFaBs/UnD6DDigb859SL9338Y8Aii4oJwveTjREmjQca4ibSFJ EChnn0ckTSUg8FVW7YtKkjuPbu4Okl2vNwCLTUVTLk88SLd99UT53N4qLbKsmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D33C56AA40 for ; Sat, 20 Jul 2024 12:13:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sV75M-0000lJ-Pl; Sat, 20 Jul 2024 06:13:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV75L-0000iV-Dy for guix-patches@gnu.org; Sat, 20 Jul 2024 06:13:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sV75K-0007BU-MP for guix-patches@gnu.org; Sat, 20 Jul 2024 06:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sV75K-0003OH-OH for guix-patches@gnu.org; Sat, 20 Jul 2024 06:13:02 -0400 Subject: bug#72082: [PATCH v2] gnu: gpxsee: Update to 13.22. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 20 Jul 2024 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72082 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan Smith Cc: 72082-done@debbugs.gnu.org Mail-Followup-To: 72082@debbugs.gnu.org, ludo@gnu.org, Morgan.J.Smith@outlook.com Received: via spool by 72082-done@debbugs.gnu.org id=D72082.172147034212929 (code D ref 72082); Sat, 20 Jul 2024 10:13:02 +0000 Received: (at 72082-done) by debbugs.gnu.org; 20 Jul 2024 10:12:22 +0000 Received: from localhost ([127.0.0.1]:51843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV74f-0003MS-Q1 for submit@debbugs.gnu.org; Sat, 20 Jul 2024 06:12:22 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:36004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV74e-0003MA-3k for 72082-done@debbugs.gnu.org; Sat, 20 Jul 2024 06:12:20 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CAFE1B57; Sat, 20 Jul 2024 12:11:43 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f79mKTMuQIIQ; Sat, 20 Jul 2024 12:11:43 +0200 (CEST) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 580592A5; Sat, 20 Jul 2024 12:11:43 +0200 (CEST) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Morgan Smith's message of "Thu, 18 Jul 2024 19:09:44 -0400") References: Date: Sat, 20 Jul 2024 12:11:42 +0200 Message-ID: <877cdgqso1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D33C56AA40 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.91 X-Spam-Score: -6.91 X-TUID: 58e6L49eye68 Hello, Morgan Smith skribis: > * gnu/packages/gps.scm (gpxsee): Update to 13.22. > Use qt-build-system. Use qt6 instead of qt5. > > Change-Id: I9101a6f763be198549aca8e5aea95987b14e58e4 > --- > Ludovic Court=C3=A8s writes: > >> >> In general we avoid disabling tests. Could you investigate a bit as to >> why tests are failing? Then the usual approach is to tweak or skip >> individual tests, and only as a last resort use #:tests? #f. In either >> case, there should be a comment explaining why we=E2=80=99re doing this. >> >> Thanks, >> Ludo=E2=80=99. > > I added a comment explaining that there are no tests. I greped the sourc= e code > for "test" and "check" and found nothing of interest. The project does h= ave > some continuous integration stuff but all it does is build. It does not = run > tests. OK, that makes sense to me. I applied it (it did not apply cleanly but with a bit of help it was fine). Thanks! Ludo=E2=80=99.