From: "Ludovic Courtès" <ludo@gnu.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: 72082-done@debbugs.gnu.org
Subject: bug#72082: [PATCH v2] gnu: gpxsee: Update to 13.22.
Date: Sat, 20 Jul 2024 12:11:42 +0200 [thread overview]
Message-ID: <877cdgqso1.fsf@gnu.org> (raw)
In-Reply-To: <CH3PR84MB34242B68E327C92D5A2AB451C5AC2@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM> (Morgan Smith's message of "Thu, 18 Jul 2024 19:09:44 -0400")
Hello,
Morgan Smith <Morgan.J.Smith@outlook.com> skribis:
> * gnu/packages/gps.scm (gpxsee): Update to 13.22.
> Use qt-build-system. Use qt6 instead of qt5.
>
> Change-Id: I9101a6f763be198549aca8e5aea95987b14e58e4
> ---
> Ludovic Courtès <ludo@gnu.org> writes:
>
>>
>> In general we avoid disabling tests. Could you investigate a bit as to
>> why tests are failing? Then the usual approach is to tweak or skip
>> individual tests, and only as a last resort use #:tests? #f. In either
>> case, there should be a comment explaining why we’re doing this.
>>
>> Thanks,
>> Ludo’.
>
> I added a comment explaining that there are no tests. I greped the source code
> for "test" and "check" and found nothing of interest. The project does have
> some continuous integration stuff but all it does is build. It does not run
> tests.
OK, that makes sense to me.
I applied it (it did not apply cleanly but with a bit of help it was
fine).
Thanks!
Ludo’.
prev parent reply other threads:[~2024-07-20 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 19:30 [bug#72082] [PATCH] gnu: gpxsee: Update to 13.22 Morgan Smith
2024-07-18 15:06 ` Ludovic Courtès
2024-07-18 23:09 ` [bug#72082] [PATCH v2] " Morgan Smith
2024-07-20 10:11 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cdgqso1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=72082-done@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.