all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Timotej Lazar <timotej.lazar@araneo.si>
Cc: 72205@debbugs.gnu.org, 宋文武 <iyzsong@envs.net>
Subject: [bug#72205] [PATCH 1/4] gnu: Add kdsingleapplication.
Date: Wed, 31 Jul 2024 15:05:21 +0900	[thread overview]
Message-ID: <877cd2xfj2.fsf@gmail.com> (raw)
In-Reply-To: <ffde2cc6327776cb3372b66970242ac6c1d68884.1721458149.git.timotej.lazar@araneo.si> (Timotej Lazar's message of "Sat, 20 Jul 2024 08:57:25 +0200")

Hi,

(I got notified for this 1/4 patch due to touching qt.scm; I haven't
checked the rest of the series).

Timotej Lazar <timotej.lazar@araneo.si> writes:

> * gnu/packages/qt.scm (kdsingleapplication): New variable.
>
> Change-Id: I08407da35712d465f9573f6bf1de0cc2e8435cb1
> ---
>  gnu/packages/qt.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 0138fd3dbf..c150dca78b 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -5214,6 +5214,32 @@ (define-public libdbusmenu-qt
>  and import their menus over DBus.")
>      (license license:lgpl2.1+)))
>  
> +(define-public kdsingleapplication
> +  (package
> +    (name "kdsingleapplication")
> +    (version "1.1.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/KDAB/KDSingleApplication")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1w7wg9w4mifrkpn7hhw1nnnwh1vhnf8i4wgfxvh44nacwslbwsb2"))))
> +    (build-system qt-build-system)
> +    (arguments
> +     (list
> +      #:qtbase qtbase
> +      #:configure-flags
> +      #~(list "-DKDSingleApplication_QT6=true" "-DKDSingleApplication_TESTS=true")))

That's a nitpick, but my impression was that ON/OFF as boolean value for
CMake were more common (or YES/NO).

> +    (inputs (list libxkbcommon vulkan-headers))
> +    (home-page "https://github.com/KDAB/KDSingleApplication")
> +    (synopsis "Qt helper class for single-instance policy applications")
> +    (description "KD SingleApplication is a helper class for single-instance
> +policy applications.")
> +    (license (list license:bsd-3 license:expat))))

Is it dual licensed? Or which files/section of the source is covered by
which? A comment is needed.

-- 
Thanks,
Maxim




  reply	other threads:[~2024-07-31  6:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20  6:49 [bug#72205] [PATCH 0/4] Update nheko Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 1/4] gnu: Add kdsingleapplication Timotej Lazar
2024-07-31  6:05   ` Maxim Cournoyer [this message]
2024-07-31 12:28     ` Timotej Lazar
2024-07-31 18:57     ` [bug#72205] [PATCH] gnu: kdsingleapplication: Improve package Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 2/4] gnu: mtxclient: Update to 0.10.0 Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 3/4] gnu: mtxclient: Switch to new package style Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 4/4] gnu: nheko: Update to 0.12.0 Timotej Lazar
2024-07-25  5:15 ` bug#72205: [PATCH 0/4] Update nheko Zheng Junjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cd2xfj2.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=72205@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=timotej.lazar@araneo.si \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.