[bug#72566] [PATCH] services: mcron: Fix home version not respecting user PATH variable.

[bug#72566] [PATCH] services: mcron: Fix home version not respecting user PATH variable.

[Sergio Pastor Pérez]

Without this fix, deploying `home-mcron-service-type' will strip user's PATH
variable from it's environment. This means that, programs such as `notmuch',
which use hooks which usually invoke `notmuch' from path, would need to be
updated with full paths; which makes it very inconvenient to use.

* gnu/services/mcron.scm (mcron-shepherd-services): respect user PATH variable.

Change-Id: I104aa0a818ad6c3266b2b8f73a9609bfb36e314d
---
This patch makes `home-mcron-service-type' respect user's PATH environment
variable, allowing to write jobs which refer to programs in PATH, instead of
relying on writing the absolute path to those programs. Although jobs can be
GEXPs, which facilitates writing those absolute paths, the programs they invoke
can rely on the PATH environment variable to invoke other programs; for example,
`notmuch' hooks.

 gnu/services/mcron.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index e907d364da..0e0d07d252 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -182,9 +182,12 @@ (define (mcron-shepherd-services config)
                            ;; set a sane value for 'PATH'.
                            #:environment-variables
                            (cons* "GUILE_AUTO_COMPILE=0"
-                                  "PATH=/run/current-system/profile/bin"
-                                  (remove (cut string-prefix? "PATH=" <>)
-                                          (environ)))
+                                  #$(if home-service?
+                                        '(environ)
+                                        '(cons*
+                                          "PATH=/run/current-system/profile/bin"
+                                          (remove (cut string-prefix? "PATH=" <>)
+                                                  (environ)))))
 
                            #:log-file #$log-file))
                  (stop #~(make-kill-destructor))

base-commit: de714bcb46d61922e0efc10783ea23fb0202f583
-- 
2.45.2

bug#72566: [PATCH] services: mcron: Fix home version not respecting user PATH variable.

[Ludovic Courtès]

Hello,

Sergio Pastor Pérez <sergio.pastorperez@outlook.es> skribis:

> Without this fix, deploying `home-mcron-service-type' will strip user's PATH
> variable from it's environment. This means that, programs such as `notmuch',
> which use hooks which usually invoke `notmuch' from path, would need to be
> updated with full paths; which makes it very inconvenient to use.
>
> * gnu/services/mcron.scm (mcron-shepherd-services): respect user PATH variable.
>
> Change-Id: I104aa0a818ad6c3266b2b8f73a9609bfb36e314d
> ---
> This patch makes `home-mcron-service-type' respect user's PATH environment
> variable, allowing to write jobs which refer to programs in PATH, instead of
> relying on writing the absolute path to those programs. Although jobs can be
> GEXPs, which facilitates writing those absolute paths, the programs they invoke
> can rely on the PATH environment variable to invoke other programs; for example,
> `notmuch' hooks.

Applied, thanks!

Ludo’.