[bug#74223] [PATCH 00/11] gnu: Add hyprland.

[Hilton Chain via Guix-patches via <guix-patches@gnu.org>]

Hi Noé,

On Thu, 07 Nov 2024 02:07:00 +0800,
Noé Lopez wrote:
>
> Hi,
>
> Thanks for this patch, hyprland works great as far as I tested it :)
>
> grimblast and hyprpicker didn’t work for me, and then gnome crashed
> losing my mail progress.  Maybe I’m not supposed to run two wayland
> sessions at once 🤔

hyprpicker is for wlroots-based compositors, and grimblast depends on Hyprland
at runtime, I guess you were running them on GNOME?

> Anyways, here are a few suggestions, I don’t have commit access so
> don’t take them too seriously :P

Don't worry!  Any review counts and helps :)

>
> >+      (native-inputs (list autoconf automake libtool python-minimal-wrapper))
> >+      ;; Fork of https://github.com/vmt/udis86
> >+      (home-page "https://github.com/canihavesomecoffee/udis86")
>
> Comments should end with a dot.

Ahh, forgot about this URL :(

> >+    (inputs (list pixman))
> >+    (home-page "https://github.com/hyprwm/hyprutils")
> >+    (synopsis "C++ library for utilities used across Hyprland ecosystem")
> >+    (description
> >+     "This package provides a C++ library for utilities used across Hyprland
> >+ecosystem.")
>
> A « the » is missing before « Hyprland ».

I stripped it by intention, does it break the sentence?


Thanks