From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kC2wAJXqQ2dTvgAAqHPOHw:P1 (envelope-from ) for ; Mon, 25 Nov 2024 03:10:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id kC2wAJXqQ2dTvgAAqHPOHw (envelope-from ) for ; Mon, 25 Nov 2024 04:10:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=u8RIKl2a; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=f7TfpWrO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732504212; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=UPZ0eXxqk44uQ8dF08PZdg+1llIbKLN6coRPvnKShAQ=; b=WtH+HKcVuvydlSmUiL9EjyKnvP/dnszhM9dSnSv96UT1CoG0sv9tHkNKswbL0EWbtgKo2j EutUEdOWlgZ9bD7NDaq4G6adM6zNvTmXovgSjPq/sEzgg9KaQ3GlsjqaKZkv9siWzGrDXV wTGAHUU6uth8obCOPTzeXxxwPZjAxwW3QHe30hJWK3Sf5bhkMXkcuen78Q35++VYJ7j/k0 eZZqYZswi9WUd9thQnQFf36uaEeqr8++OW9D2MN2hF+Ro8bbykbhp3WtQIC+HvC13AeqAX oSLL7OGIpOuON023MSFqUcYEX5a1yvOIjDHZ6uS+UdZ27zqXVuSSVvNlwHPF1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=u8RIKl2a; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=f7TfpWrO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732504212; a=rsa-sha256; cv=none; b=GOM8cy4NKZivUsfuqVrTWW01OUrwici3noNDUzd8pvHt1afDTMduAvo6s5//2H8GQcbOIB /1xHNfGTBj7SR5xKSlCL7u8PV9xDQaPNx2WJG/5EWSXAPhRBL+udYH6cJfGAT1Rb+Acezr FFwOh1XrYjFOkSzsz/nD1NgNga5JktKefSuDsE20BJATK08idCaGihdtuy9wgHYHq4jsuf sQttbEjE/NMJDTstleSJlTCLgtB+i8CulcdQFNuAWJ2GATRR03YiDKlBBjFiPAsVjRXYuU F8EDUQP8BJ2meGrBC8QrIcQIEVTpZ03QNNisYAdJusa0lFeRUkLVpsBowbh/yQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 558EB79341 for ; Mon, 25 Nov 2024 04:10:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFPUD-0005QJ-Rc; Sun, 24 Nov 2024 22:10:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFPUB-0005OG-Fr for guix-patches@gnu.org; Sun, 24 Nov 2024 22:10:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFPUA-00042y-7R for guix-patches@gnu.org; Sun, 24 Nov 2024 22:10:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=UPZ0eXxqk44uQ8dF08PZdg+1llIbKLN6coRPvnKShAQ=; b=u8RIKl2a1cqRiWnPJ2xMuOy/8oNtaOdffMbAEoEByjlDkDFgJvbCdUUxphbfy0ugV2HzsaoQuNyEgtSlplsB3C7hrr8J3W678JblphYjsNPrBztFbHGgmaE8IfLA3DsmI+qHtJrY3nkOB6A/38oYb/AP+PlpUsrcwcaI3+3Piq0rZVR9Fg09GwIGoZVgyFbXU5Bv+AY8TNl/4mgJ2sHdNH1j3kKnpXy9H9jFDDbcacEXoLxZmhiq4LLolx1SWU2zAN7EzuJdgPUBf/OkHHK3OTB83MNOG5bbCo9kK3YK6p918goiBVmYAjCcJJRufq0eBWK3Dx0J419/7D8OMBXseQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFPUA-0003dJ-1q for guix-patches@gnu.org; Sun, 24 Nov 2024 22:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74517] [PATCH 3/8] gnu: Add zbar-minimal. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Nov 2024 03:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74517 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 74517@debbugs.gnu.org Received: via spool by 74517-submit@debbugs.gnu.org id=B74517.173250416513903 (code B ref 74517); Mon, 25 Nov 2024 03:10:02 +0000 Received: (at 74517) by debbugs.gnu.org; 25 Nov 2024 03:09:25 +0000 Received: from localhost ([127.0.0.1]:36919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFPTY-0003cA-Le for submit@debbugs.gnu.org; Sun, 24 Nov 2024 22:09:25 -0500 Received: from mail-pg1-f174.google.com ([209.85.215.174]:50681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFPTW-0003c2-Vb for 74517@debbugs.gnu.org; Sun, 24 Nov 2024 22:09:23 -0500 Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7ee51d9ae30so3034458a12.1 for <74517@debbugs.gnu.org>; Sun, 24 Nov 2024 19:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732504102; x=1733108902; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UPZ0eXxqk44uQ8dF08PZdg+1llIbKLN6coRPvnKShAQ=; b=f7TfpWrOBYsSYFnzS5qaTfLu5rrwz4B0objv8pfvXQSXBScEc9jGmH6elgTCu/JTxa HVZ/sG0/X/3PzBvzSUx4Q5lBVygRSEzLR0w4zXTkJQnT/YempsaEmpIg23vgwIkFMmIt SURZvkvmDwlK+o7lm5sQxJMNL/QiKmWJbvkWfDelzFfW9EFXA6wdHnFfkC0aZLJv8ttR ePT+InyE6av9iHXt1uLnkdCBu+qyWgOSRTNo/+Ilc5LiXfvzmUDsgmTyjoqoq4dS1HHk MFZ3XuGUt+DFT2tRAaemHFSDj0JO07f7q8pg47KEgsDJIqI9cJq5B4Btur+YpF9dEgf6 puxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732504102; x=1733108902; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UPZ0eXxqk44uQ8dF08PZdg+1llIbKLN6coRPvnKShAQ=; b=kM5W48/2DXh7b9jVU1VDiNlwiT3IO+wGFO/P08F2b5oN8T/mjfEQHEk0ZId+cQzhnj 28XyoPblzIKWCM8GmgfVQ4DFujiWWvy8naII5MGKaNYFS+B3gqL2YJgc7qxEY9CNqkyv VmkbKUlehinuocBQhhj+1TsxxvPGRS/8w5KV2gLqCl8hhaVxO4eIurMSbb1tBxw6JDbR JQ5LPgGig2Hhr16JV87jealoyAVPaSYrppYlXDXhaLZgg3XA2L8kDWp8RDaRR4BAH0rQ QMcI5QowpJEFpYYJfRPqpBG3w8KsfdU9HJzseSDxLLI+7NI7Ro8O/CLDKemwQZ8FJV0g gcdQ== X-Gm-Message-State: AOJu0YyoQ4YhFCbg0mUDTWX1zFPBPXGLdlbn5aCe5lKg8ymFUi4HwF+u b4fj/FwI4ovc31sJyDJ4RRFkdyyn83PZrXGJhuJkv8yEyGNdIetag5N5hOxB X-Gm-Gg: ASbGncvfu3q5fs77ObP5FpAH/s3/AcNMuHQG0c2Ud3VWkjeVpCv86gmmK+Hof3Yy+Mg 8HuIx0cfKsdfPKlj6wFSJVxx+bCQXmEzj7UPsBEH3qTjVIlX1cFJ6iPVn5tHOc2wYzsT/DrrPdO /ORsRl4JX1xWja/WyMS2IHKizpGpgs2hLdUerSdDWSRITStXCQg0kSfy6ph1nDqKG3NNrcKHqXK frUKyy0ZgjAQ8q8eEfkdbrmyF+rToMGPCOc2Qg2lQF6Ww4= X-Google-Smtp-Source: AGHT+IEujhhgbZA74AQMUcYyaFHjp0k7plGIArQp6WYVnR1c5s7TmW/Z9sSgHZ1PKI+3CFFRcfxoZA== X-Received: by 2002:a05:6a20:c797:b0:1db:eccc:9249 with SMTP id adf61e73a8af0-1e09e6552bamr16489951637.43.1732504101849; Sun, 24 Nov 2024 19:08:21 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724fba15121sm2503605b3a.94.2024.11.24.19.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2024 19:08:21 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <20241124222934.524-3-ngraves@ngraves.fr> (Nicolas Graves's message of "Sun, 24 Nov 2024 23:29:10 +0100") References: <20241124222934.524-1-ngraves@ngraves.fr> <20241124222934.524-3-ngraves@ngraves.fr> Date: Mon, 25 Nov 2024 12:08:12 +0900 Message-ID: <877c8sm2n7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 3.55 X-Spam-Score: 3.55 X-Migadu-Queue-Id: 558EB79341 X-TUID: 8TT+bjP/ANTQ Hi Nicolas, Nicolas Graves writes: > * gnu/packages/aidc.scm (zbar-minimal): New variable. > --- > gnu/packages/aidc.scm | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/aidc.scm b/gnu/packages/aidc.scm > index 281f87dc78..58b5b9a6f6 100644 > --- a/gnu/packages/aidc.scm > +++ b/gnu/packages/aidc.scm > @@ -46,7 +46,8 @@ (define-module (gnu packages aidc) > #:use-module (gnu packages video) > #:use-module (guix build-system cmake) > #:use-module (guix build-system gnu) > - #:use-module (guix build-system glib-or-gtk)) > + #:use-module (guix build-system glib-or-gtk) > + #:use-module (guix build-system trivial)) > > (define-public zxing-cpp > ;; Use the master branch as it includes unreleased build system improvements > @@ -277,6 +278,30 @@ (define (move-output-file target file) > (home-page "https://github.com/mchehab/zbar") > (license license:lgpl2.1+))) > > +(define-public zbar-minimal > + (package > + (inherit zbar) > + (source #f) > + (name "zbar-minimal") > + (build-system trivial-build-system) > + (arguments > + (list > + #:builder > + (with-imported-modules '((guix build utils)) > + #~(begin > + (use-modules (guix build utils)) > + (copy-recursively #$(this-package-native-input "zbar") > + #$output) > + (substitute* (string-append #$output "/lib/pkgconfig/zbar.pc") > + (("^prefix=.*") > + (string-append "prefix=" #$output "\n"))))))) > + (outputs '("out")) > + (native-inputs (modify-inputs (package-native-inputs zbar) > + (prepend zbar))) > + (inputs (modify-inputs (package-inputs zbar) > + (delete "qtx11extras"))) > + (propagated-inputs '()))) I see; the previous commit neatly organized dependencies on gtk/qt in separate outputs, and this variant ensures any reference to these output is severed, without any rebuild. It's a researched approach, but I'm a bit worried about long term maintenance/correctness; I feel a classic variant rebuilt without the problematic inputs would be both easier to understand and maintain in the long term. Also, same earlier comments hold about package/inherit and using #:disallowed-reference along with an explanatory comment. -- Thanks, Maxim