[bug#73963] [PATCH] gnu: povray: Fix test run requiring interaction.

[bug#73963] [PATCH] gnu: povray: Fix test run requiring interaction.

[Ivan Vilata i Balaguer via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

The test render required pressing a key after it was done, which caused the
package build to get stuck.  Also disable the render display window, which
did not cause issues but was pointless.

* gnu/packages/graphics.scm (povray)[args]: Patch test render not to pause nor
display a window.

Change-Id: Ia9527b3a67896972b399464b97dda464365d41ea
---
 gnu/packages/graphics.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index c12516383b..8d309cac33 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -37,6 +37,7 @@
 ;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
 ;;; Copyright © 2023 Eric Bavier <bavier@posteo.net>
 ;;; Copyright © 2023, 2024 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+;;; Copyright © 2024 Ivan Vilata-i-Balaguer <ivan@selidor.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1656,7 +1657,9 @@ (define-public povray
               (setenv "HOME" (getcwd))
               (with-directory-excursion "unix"
                 (substitute* "prebuild.sh"
-                  (("/bin/sh") (which "sh")))
+                  (("/bin/sh") (which "sh"))
+                  ;; Make test run non-interactive.
+                  (("biscuit.pov -f \\+d \\+p \\+v") "biscuit.pov -f +v"))
                 (invoke "sh" "prebuild.sh"))))
           ;; The bootstrap script is run by the prebuild script in the
           ;; "run-prebuild" phase.

base-commit: b8f8699a1f6e23fec46be7e086abde1270331ac9
-- 
2.46.0


-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#73963: [PATCH] gnu: povray: Fix test run requiring interaction.

[Ludovic Courtès]

Ivan Vilata i Balaguer <ivan@selidor.net> skribis:

> The test render required pressing a key after it was done, which caused the
> package build to get stuck.  Also disable the render display window, which
> did not cause issues but was pointless.
>
> * gnu/packages/graphics.scm (povray)[args]: Patch test render not to pause nor
> display a window.
>
> Change-Id: Ia9527b3a67896972b399464b97dda464365d41ea

Applied, thanks!