From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2A50DgK0cGcBBAEAe85BDQ:P1 (envelope-from ) for ; Sun, 29 Dec 2024 02:29:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2A50DgK0cGcBBAEAe85BDQ (envelope-from ) for ; Sun, 29 Dec 2024 03:29:22 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=SP8881Pu; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RIKMdQMw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735439362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wLTS6GPAFUFzHrjyHzOKQICnrs5g05GckRHkBZAhLbg=; b=O2+ooqd4mGFlpEpp9kuKVl0wxc4BZw9TBF7Lrx1fwNClnQL3a2Iuhsi8zZpPwBhAdh5Rdj BaqhqU4ms1z7mpjlSKfGp6EHgS5jz8WiYY6J1xSMKnNkBIeYUeqKVWtdBRWsn61Q/la4pp b3OoW/6FFOS1r/N5iN8cMSnFS16KQTic1hBTl6zLQp4zKCHaCUsIeq6aXMeYbIFd35NyQL 5Og9mnWxsXNQFt02E1hy9KqE/vZfg0lqFgPpediDxjwyjCgtX4zeh/dofOJ8yXI+oDXLIa OxrBPErptnFC+RvLuGeJwypyl+K8ztwoQEeMa8lm9vGOmIJ7TUoYst8QwQvyzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=SP8881Pu; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RIKMdQMw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735439362; a=rsa-sha256; cv=none; b=sO8miEzdr5d2D7Vod1MuajmGowlgP7kSA/bCA/W1NYnFcLyL/UcEolbKHnLDq8Q5W3rTme DpAxmVQcmAgSrWnWJ0/+duOK/ggGnINgg7RAxwVgQT+uxsSX4U3s6uklpod0eGESbeaHQs vOWfbqRI466L/VYY63a1TWgHzagX516HqfXDpHqo1G3Cc07l9U7G/o8k9G+zfivSoizPMO aOWXRyBEeSsvzUJXMHzcBt3yuSpxEyzY954fPLzdLR3GGK+IQuxNQBuTVfhNroOmzwFZPv 0ENCzX9rfkNrMaAcRTpdqzuQr7nzB67gf2aSXFtSprs63MoquyzxZTaE9ryIig== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0CA3953859 for ; Sun, 29 Dec 2024 03:29:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRj3A-0001pn-4C; Sat, 28 Dec 2024 21:29:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRj38-0001pb-Jd for guix-patches@gnu.org; Sat, 28 Dec 2024 21:29:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRj38-0006gZ-82 for guix-patches@gnu.org; Sat, 28 Dec 2024 21:29:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wLTS6GPAFUFzHrjyHzOKQICnrs5g05GckRHkBZAhLbg=; b=SP8881PuxgH68o9G4coo4IfHuZwcV4LHD64BuC3Z5I/mt5pY283npthgc7heqwj9qDAitCqrea+4ch683bOC1omZ1xLw8S4+/NDhDziJYJwfd/EDfn6cZBci8E9BmP/+EpHG2d1xsI/0qxa2b01ldv1yhkYltk1UZOKE3s85K2H27d7SPxhTeq8JxxT4z3YULooVmR+6PMKXoXHCdBbCOi4xXu/M+of8ZOQuQwRHtp+uw6x9Kx4vdyqaaJHnBBAKHWdib5xc2rdYDAmBsUp3hgcsVIAJe2YvS5etM+N6fmAraU2Sf7mvwbAZVKqpqXsrinuH2gQe0qJyv2tlZ1c9EQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRj38-0000rD-1t for guix-patches@gnu.org; Sat, 28 Dec 2024 21:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74962] [PATCH v3 4/5] etc/guix-install.sh: Remove 'which' commands from requirements. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Dec 2024 02:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74962 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Simon Josefsson , Josselin Poiret , Mathieu Othacehe , 74962@debbugs.gnu.org, Janneke Nieuwenhuizen Received: via spool by 74962-submit@debbugs.gnu.org id=B74962.17354392973159 (code B ref 74962); Sun, 29 Dec 2024 02:29:02 +0000 Received: (at 74962) by debbugs.gnu.org; 29 Dec 2024 02:28:17 +0000 Received: from localhost ([127.0.0.1]:53223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRj2P-0000oq-Cl for submit@debbugs.gnu.org; Sat, 28 Dec 2024 21:28:17 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:54301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRj2M-0000oS-Nx for 74962@debbugs.gnu.org; Sat, 28 Dec 2024 21:28:15 -0500 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2163bd70069so1394735ad.0 for <74962@debbugs.gnu.org>; Sat, 28 Dec 2024 18:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735439229; x=1736044029; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wLTS6GPAFUFzHrjyHzOKQICnrs5g05GckRHkBZAhLbg=; b=RIKMdQMw5LFd4pJfx1iTr8xjEyxnBKCoMS+qJu7qC0pdR8YJwqA5dr4xmdbnKWU2Fz YdJuCLNIXU8RTg9Y2o+imgtXQRNcZj9n8m37JNyP1krPIwruGyiMiWejsgAPAzkqa41O pKPJd5dYFIYQ8vTshK5yhqonMwb2Aal14vUuXQi2NFCZw3LzoEJAV6jWS3Qggidy9Cov C2CHaEtMFX76YdEnXi0JrP1P6HDxARgp9cKjrLfl2+XjVRb3MSHqORJbXTXYApQ0c89F Tk8TrZQiyrmDm2ySTLToYSwR1QRuhVtoMNa5ELZObcUJbdbc28n5PdzHd/D3Q5/VI45E maAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735439229; x=1736044029; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wLTS6GPAFUFzHrjyHzOKQICnrs5g05GckRHkBZAhLbg=; b=s3H7H3XYMoy7wXoYdE/c/fDGMFgtldYIL19aA72eyrHjtFssLiBwc3eqfo7HmEh2+a WayPhdiOpi4jCGxtNPV3RzYIBKR+cwKVyStO1ofB4foBXZIrn/76MeWmaluUoTAL64D/ qHT5kwYC5jOc5OZqxUCNffK18aULNXuS+q3EdX64wmeDhoAhdr4XUh57ICGbiY2WMb1A tJ+h+X/DP2z4sxpnFIhEGBwYiHkKftk8sk4F4DszROFl4aMgccMSzLjyZOtVcUjYd2rA 8maFm3eoqa0OUQWS12UdQOxtyvIbVOmD29YqT6djVDuoJ7jPGiswKcHN5MQrq8GNKjZ4 qZ8A== X-Forwarded-Encrypted: i=1; AJvYcCXW8/jSDKxoi6RxqlnrqV070S2Ni3dgyxpjPVR5TOFTk+bovVaLkY5lAGgVprKNmLIjNcVXlQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxMwE4K37bgN9+HY+WXBqGC42gndCzbzVxERYsKTuJZhEWFdYFF nZshQDLU6Rqy6VJGPdnkzZ2N0DUn5XgzVNZN73hag1WvY1Fpzb2iXHt/003qG/g= X-Gm-Gg: ASbGncs+jrb0+91w7s0JE1efJPDhOOPrHKg/sbRcE1pBNbOe5gEDrUCmLAkCZLeVfIE RtQL9qda9mv/m4wfYa79Rf8lCuK+BWc/r0XATQZ0bBg5xyxuCaiDoGZuGAHRmffugR97zXjgOEU CcIXOGdfxOJK6mQk349wHGPotnqPC+/rvZgXjytmr3HKxSQ1uaGNdUNbkwEjimHcX7Zdc31lv5Q kdCkQRx+HGZ/Fy6LdUhEq1UDmVrWS9KyEw9cX+hOViweSyQwXxrIQ== X-Google-Smtp-Source: AGHT+IGfTn2narg8Q/xanD1GHBmpbsiBY15aUw4cCHdM8euaiCM3STvd/1vRZJfK29CrStXDEdKhPw== X-Received: by 2002:a17:902:e54e:b0:216:7ee9:2222 with SMTP id d9443c01a7336-219e6f13c45mr459058315ad.35.1735439229128; Sat, 28 Dec 2024 18:27:09 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f4fbcsm155964915ad.174.2024.12.28.18.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2024 18:27:08 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87y0zzwxyf.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 28 Dec 2024 17:53:44 +0100") References: <3d0ccfc5f28f48b0a4e513e4ebfd3018c85b4407.1734594333.git.maxim.cournoyer@gmail.com> <6d1f4ffaa70f4cfb3ed9e18b46fe3cedb44025f2.1734594333.git.maxim.cournoyer@gmail.com> <878qs2zpaf.fsf@gnu.org> <87v7v6tygi.fsf@kaka.sjd.se> <87y0zzwxyf.fsf@gnu.org> Date: Sun, 29 Dec 2024 11:26:57 +0900 Message-ID: <877c7ji5qm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 0CA3953859 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.79 X-Spam-Score: -3.79 X-TUID: VBuVYWN/2qlB Hi, Ludovic Court=C3=A8s writes: > Simon Josefsson skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Maxim Cournoyer skribis: >>> >>>> * etc/guix-install.sh (REQUIRE): Remove "which". Add "nologin". >>>> (sys_create_build_user): Use 'type' instead of 'which'. >>>> >>>> Fixes: >>>> Reported-by: Simon Josefsson >>>> Change-Id: I0675716bab3fc22d3289ee7af2cb0ab33a1cee71 >>> >>> LGTM. >> >> Using 'type -P' is not POSIX and neither /bin/dash nor /bin/gash >> supports it. It seems like a GNU bash extension. Is that okay? > > Oh, not great. From what you write, I=E2=80=99m not sure what to conclud= e; > just skip this patch and be done with it? We currently use other Bash-specific features, so I think it's fine to embrace the Bash requirement instead of shying away from it. If we decide that we don't want Bash as a requirement at some point, we'll have to change a bunch of things; one of them would be to no longer make use of arrays since POSIX shells don't have them, for example. --=20 Thanks, Maxim