From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] distro: Add Python 2.7.3.
Date: Tue, 15 Jan 2013 00:28:14 +0100
Message-ID: <87622zibu9.fsf@gnu.org>
References: <87a9sbfkpb.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:60879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TutSL-0008BO-KB
	for bug-guix@gnu.org; Mon, 14 Jan 2013 18:28:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TutS8-0002Fe-63
	for bug-guix@gnu.org; Mon, 14 Jan 2013 18:28:41 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:32011)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1TutS7-0002FM-Ua
	for bug-guix@gnu.org; Mon, 14 Jan 2013 18:28:28 -0500
In-Reply-To: <87a9sbfkpb.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Mon, 14 Jan 2013 17:44:40 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Hi,

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> Also, should we explictly mention the licenses for third-party software
> incorporated in the Python distribution [2]?

Perhaps just add the link in a comment.

> +    (arguments `(#:tests? #f)) ; XXX: some tests fail

Did you try to investigate?  How hard would it be to fix that?

> +    (inputs
> +     `(("zlib" ,guix:zlib)
> +       ("openssl" ,guix:openssl)
> +       ("bzip2" ,guix:bzip2)

To avoid the #:renamer, I recommend doing this instead:

  #:use-module ((guix licenses) #:select (psfl))

> +       ("glibc" ,glibc-final)))

This is not needed: there=E2=80=99s an implicit =E2=80=9Clibc=E2=80=9D inpu=
t already (see
build-system/gnu.scm).

Thanks,
Ludo=E2=80=99.