Re: #!/usr/bin/env perl

[ludo@gnu.org (Ludovic Courtès)]

Andreas Enge <andreas@enge.fr> skribis:

> I had test failures in coreutils,

Do you still have the details around?  ‘env’ is part of Coreutils, so it
may be that it’s testing its behavior, and that patching prevents that.

Perhaps ‘patch-shebang’ could have a ‘patch-env?’ keyword parameter,
defaulting to #t, and if the above is correct, we’d instead arrange to
have it called with #:patch-env? #f.

> and to check whether it was related to my patch, I tried from scratch
> with the current core-updates branch. Any call to guix aborts with

[...]

> In /usr/local/bin/guix:
>   59: 1 [#<procedure 28381c0 ()>]
> In unknown file:
>    ?: 0 [scm-error misc-error #f ...]
>
> ERROR: In procedure scm-error:
> ERROR: No variable named guix-main in #<interface (guix ui) 28a0ea0>

You should be using ‘./pre-inst-env guix build xxx’, which you don’t
seem to be doing, no?

For info about why this happens, you could try:

  guile -c '(pk (@ (guix ui) guix-main))'

> From 63ac645147871eb773032da23d9f52bbd4f823eb Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Fri, 22 Feb 2013 23:00:41 +0100
> Subject: [PATCH] Patch-shebang: Handle "#!/usr/bin/env command"
>
> * guix/build/utils.scm (patch-shebang): Handle replacement of
>    "#!.*/env CMD ARGS" by "#!/nix/store/path/.../to/CMD ARGS".

Looks good to me.  Perhaps the only thing left will be the addition of
#:patch-env?, unless that turns out to be unnecessary.

Thanks!

Ludo’.