From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu-maintenance: Improve 'official-gnu-packages';
	add the related procedures.
Date: Wed, 27 Mar 2013 11:08:37 +0100
Message-ID: <87620dtasa.fsf@gnu.org>
References: <87obfchq38.fsf@karetnikov.org> <87sj4ok6sc.fsf@gnu.org>
	<87sj48gxzp.fsf_-_@karetnikov.org> <87lia09khe.fsf@gnu.org>
	<874ngbcfbl.fsf_-_@karetnikov.org> <87vc8rq6ol.fsf@gnu.org>
	<877gl0kye8.fsf@karetnikov.org> <87620jk4oi.fsf@gnu.org>
	<8738vhud12.fsf@karetnikov.org> <87620dx4um.fsf@gnu.org>
	<878v59swr0.fsf@karetnikov.org> <87ip4dvour.fsf@gnu.org>
	<87r4j18jje.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:39746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UKnHl-0006uk-8q
	for bug-guix@gnu.org; Wed, 27 Mar 2013 06:08:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UKnHj-0007UB-TU
	for bug-guix@gnu.org; Wed, 27 Mar 2013 06:08:49 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=44065
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UKnHj-00079x-NS
	for bug-guix@gnu.org; Wed, 27 Mar 2013 06:08:47 -0400
In-Reply-To: <87r4j18jje.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Wed, 27 Mar 2013 10:05:09 +0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>> You can if you end up not using the =E2=80=9Csyntactic constructor=E2=80=
=9D with named
>> fields (as was the case in my example).
>
> Heh, I used it; it's very handy.  I didn't even try to use
> 'gnu-package-descriptor'.
>
> Thanks for your suggestions.  Any other comments?  If not, I'll create a
> proper patch (the attached version doesn't honor multiple fields).

Looks good to me!

Nitpicking follows:

> +  #:use-module (ice-9 rdelim)           ; http-fetch*

The comment is misleading.

> +  (gplv3-status     gnu-package-gplv3-status)
> +  (activity-status  gnu-package-activity-status)
> +  (last-contact     gnu-package-last-contact)
> +  (next-contact     gnu-package-next-contact)
> +  (note             gnu-package-note))

I=E2=80=99d remove these 5 fields since Brandon mentioned that at least 2 of
them are being moved elsewhere, and we don=E2=80=99t need them anyway.

(It=E2=80=99s surprising that there=E2=80=99s no =E2=80=98license=E2=80=99 =
field in the file.)

Thanks!

Ludo=E2=80=99.