From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add libgpg-error as propagated inputs to gnupg, gpgme, and pinentry Date: Wed, 19 Feb 2014 22:24:04 -0500 Message-ID: <8761oa8o17.fsf@netris.org> References: <87k3cr8kcj.fsf@netris.org> <87ob23md40.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGKGB-000781-T9 for guix-devel@gnu.org; Wed, 19 Feb 2014 22:25:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGKG6-0004CI-FT for guix-devel@gnu.org; Wed, 19 Feb 2014 22:25:15 -0500 In-Reply-To: <87ob23md40.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 19 Feb 2014 14:43:59 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> From e6ddaf74f30ee5d6c8d76a3ae9cacdb14eb060c5 Mon Sep 17 00:00:00 2001 >> From: Mark H Weaver >> Date: Tue, 18 Feb 2014 22:06:34 -0500 >> Subject: [PATCH] gnu: Add libgpg-error as propagated inputs to gnupg, >> gpgme, and pinentry. >> >> * gnu/packages/gnupg.scm (gnupg, gpgme, pinentry): Make 'libgpg-error' >> a propagated input. > > This makes sense for GPGME, because it=E2=80=99s a library and its header= s may > refer to the libgpg-error headers. > > But what about GnuPG and Pinentry? These are normally just end-user > programs, right? Indeed, my mistake. > Also, please write a one-line rationale for the propagation as a > comment. Good idea. Here's an updated patch. Thanks, Mark --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-gpgme-Make-libgpg-error-a-propagated-input.patch Content-Description: [PATCH] gnu: gpgme: Make 'libgpg-error' a propagated input >From 68640c3c09c6c9ddcaae8d50754f0876b273d42a Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Wed, 19 Feb 2014 19:20:53 -0500 Subject: [PATCH] gnu: gpgme: Make 'libgpg-error' a propagated input. * gnu/packages/gnupg.scm (gpgme): Make 'libgpg-error' a propagated input. --- gnu/packages/gnupg.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index 499b200..85ce076 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -226,10 +226,12 @@ components), libgpg-error (centralized GnuPG error values), and libskba (base32 "15h429h6pd67iiv580bjmwbkadpxsdppw0xrqpcm4dvm24jc271d")))) (build-system gnu-build-system) + (propagated-inputs + ;; Needs to be propagated because gpgme.h includes gpg-error.h. + `(("libgpg-error" ,libgpg-error))) (inputs `(("gnupg" ,gnupg) - ("libassuan" ,libassuan) - ("libgpg-error" ,libgpg-error))) + ("libassuan" ,libassuan))) (home-page "http://www.gnupg.org/related_software/gpgme/") (synopsis "library providing simplified access to GnuPG functionality") (description -- 1.8.4 --=-=-=--