From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@gmail.com>
Subject: Re: [PATCH] gnu: Add libpetsc
Date: Thu, 01 May 2014 11:26:48 -0500
Message-ID: <8761lpmpmf.fsf@gmail.com>
References: <87eh0emy00.fsf@gmail.com> <87wqe64ibm.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1Wftn1-0001Kc-J5
	for guix-devel@gnu.org; Thu, 01 May 2014 12:24:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1Wftmw-0004l1-4N
	for guix-devel@gnu.org; Thu, 01 May 2014 12:24:51 -0400
In-Reply-To: <87wqe64ibm.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
	=?utf-8?Q?s?= message of "Wed, 30 Apr 2014 23:29:33 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

>> +(define-public libpetsc
>> +  (package
>> +    (name "libpetsc")
>
> I think this should be =E2=80=9Cpetsc=E2=80=9D, as it=E2=80=99s the upstr=
eam name and commonly
> used AFAIK.  WDYT?

I was originally thinking "petsc" but then discovered that the package
name on many other distributions is "libpetsc".  I would personally
prefer "petsc".

>> +         ;; Try to keep installed files from leaking build directory pa=
ths.
>> +         ;; Fortran modules will have references to the build directory
>> +         ;; because cmake passes absolute path names to the compiler.
>
> Rather =E2=80=9Cdirectory names=E2=80=9D and =E2=80=9Cabsolute file names=
=E2=80=9D (info "(standards)
> GNU Manuals").

I'll fix that.

> (This CMake story is terrible, BTW.)

I think PETSc has an alternative build system.  I'll check whether using
that one would improve anything.

>> +(define-public libpetsc-complex
>> +  (package (inherit libpetsc)
>> +    (name "libpetsc-complex")
>
> Likewise, =E2=80=9Cpetsc-complex=E2=80=9D?

Yes.

>> +++ b/gnu/packages/patches/petsc-fix-threadcomm.patch
>
> Please add a comment at the beginning of the patch saying what it does
> and whether it=E2=80=99s available upstream.

Will do.

--=20
`~Eric