From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: Guix-devel@gnu.org
Subject: Re: [PATCH] Add mcrypt
Date: Sun, 25 May 2014 00:34:48 +0200 [thread overview]
Message-ID: <8761ku956f.fsf@gnu.org> (raw)
In-Reply-To: <20140524085352.GA16714@debian> (Andreas Enge's message of "Sat, 24 May 2014 10:53:52 +0200")
Andreas Enge <andreas@enge.fr> skribis:
> On Sat, May 24, 2014 at 12:40:31AM -0500, Eric Bavier wrote:
>> + (native-inputs `(("file" ,file)))
>> + (arguments
>> + `(#:phases (alist-cons-before
>> + 'configure 'patch-configure
>> + (lambda _
>> + (substitute* "configure"
>> + (("/usr/bin/file")
>> + (which "file"))))
>> + %standard-phases)))
>
> Is this really needed? Lots of packages using the autotools look for "file",
> and when it is not available, nothing bad seems to happen. I was told before
> to just not bother.
Agreed.
Nikita Karetnikov <nikita@karetnikov.org> skribis:
>> This patch adds Mcrypt, and two library dependencies. Comments
>> welcome.
>
> I believe the libraries should be listed in the commit message as new
> variables. Ludo, WDYT?
Agreed, in the subject line.
Ludo’.
next prev parent reply other threads:[~2014-05-24 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 5:40 [PATCH] Add mcrypt Eric Bavier
2014-05-24 8:53 ` Andreas Enge
2014-05-24 22:34 ` Ludovic Courtès [this message]
2014-05-24 10:19 ` Nikita Karetnikov
2014-05-24 13:59 ` Taylan Ulrich Bayirli/Kammer
2014-05-24 22:33 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761ku956f.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=andreas@enge.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.