From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Emacs interface for Guix Date: Sat, 16 Aug 2014 14:24:42 +0200 Message-ID: <8761hsmxkl.fsf@gnu.org> References: <87k3719v7p.fsf@gmail.com> <87r419fa50.fsf@gnu.org> <87fvho9fqm.fsf@gmail.com> <87a97taixl.fsf@gmail.com> <87sil2rbly.fsf@gnu.org> <87tx5idn7f.fsf_-_@gmail.com> <87egwlkcy1.fsf@gnu.org> <87ppg5el2i.fsf@gmail.com> <87d2c5h4if.fsf@gnu.org> <87lhqsev1d.fsf@gmail.com> <877g2c74xh.fsf@gnu.org> <87ha1gds3w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XId2O-0000Lb-RS for guix-devel@gnu.org; Sat, 16 Aug 2014 08:24:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XId2O-0002jU-1h for guix-devel@gnu.org; Sat, 16 Aug 2014 08:24:48 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:35721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XId2N-0002jA-P9 for guix-devel@gnu.org; Sat, 16 Aug 2014 08:24:47 -0400 In-Reply-To: <87ha1gds3w.fsf@gmail.com> (Alex Kost's message of "Thu, 14 Aug 2014 00:58:27 +0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org (Sorry for replying to messages in the wrong order. :-)) Alex Kost skribis: > Ok, I'm attaching these patches. But there are several issues there: > > - I fixed a typo in "tests/profiles.scm" (=E2=80=9Cprofile=E2=80=9D -> = =E2=80=9Cprofiles=E2=80=9D) =E2=80=93 Is > it ok to do this in that commit or should there be a separate commit? No that=E2=80=99s OK. > - I added a copyright line to the test file as well. Is it ok? Sure! > - The main thing: look at =E2=80=98manifest-show-transaction=E2=80=99 =E2= =80=93 unlike > =E2=80=98show-what-to-remove/install=E2=80=99 it doesn't display an out= put path of a > package item, because a store should be used for that. So is it > acceptable or should something be changed there? I think it should be changed to display the same thing as before. What about adding just a =E2=80=98store=E2=80=99 parameter to =E2=80=98manifest-= show-transaction=E2=80=99, and then just use the same code as =E2=80=98show-what-to-remove/install=E2= =80=99? Other than that the two patches look good, so if you make that change, we can go ahead. >>> Also I think "guix.el" should check for freshness too, so >>> =E2=80=98check-package-freshness=E2=80=99 should probably be exported. >> >> Yes, probably in the (gnu packages) module? > > Probably, but I think I'm not competent to decide :) Well, take it as a suggestion then. :-) Thanks, Ludo=E2=80=99.