From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: base: Add Glibc-Hurd Headers. Date: Fri, 29 Aug 2014 15:48:32 +0200 Message-ID: <8761hbcspb.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNUqX-0007Vo-AF for Guix-devel@gnu.org; Fri, 29 Aug 2014 18:40:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNUqN-0006mx-Sk for Guix-devel@gnu.org; Fri, 29 Aug 2014 18:40:41 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:51094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNUqN-0006mS-LR for Guix-devel@gnu.org; Fri, 29 Aug 2014 18:40:31 -0400 In-Reply-To: (Manolis Ragkousis's message of "Mon, 2 Jun 2014 21:16:00 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Manolis Ragkousis Cc: Guix-devel@gnu.org Hi, Manolis! I have finally reviewed the 2 pending patches of yours that add glibc-hurd and glibc-hurd-headers. I=E2=80=99ve combined these 2 patches as well as the hurd-minimal one into a single one to make a self-contained patch. I=E2=80=99ve then reviewed it, which led me to simplify a few things, and a= dd a bunch of FIXMEs, and pushed the result as the =E2=80=98wip-hurd=E2=80=99 br= anch. Can you please check it out, look at all the FIXMEs, both in the .scm and .patch files, address them, and post a patch here (no need for a detailed commit log.) The FIXMEs are about: =E2=80=A2 Things that are probably unneeded: if there are actually unneed= ed, please remove them, otherwise add a comment clearly stating why they are needed. =E2=80=A2 Workarounds that lack a justification, have an unclear justification, and/or lack a link to the relevant mailing list discussion. If there is any FIXME that is unclear to you, please do let me know. There are many workarounds being applied here, so it=E2=80=99s very importa= nt to be rigorous in defining what they=E2=80=99re for so this can be maintained. Also make sure that the result does not introduce any regressions with the not-yet-reviewed cross-base.scm patch. I think we=E2=80=99re on the right track now. :-) Thanks in advance, and again apologies for the looooong delay! Ludo=E2=80=99.