From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org
Subject: Re: [PATCH] gnu: base: Add Glibc-Hurd Headers.
Date: Fri, 29 Aug 2014 15:48:32 +0200 [thread overview]
Message-ID: <8761hbcspb.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzPzXXJXd1DazYLA5PSUpn5Z9kxxpL35pp+i_e0zha3h8w@mail.gmail.com> (Manolis Ragkousis's message of "Mon, 2 Jun 2014 21:16:00 +0000")
Hi, Manolis!
I have finally reviewed the 2 pending patches of yours that add
glibc-hurd and glibc-hurd-headers. I’ve combined these 2 patches as
well as the hurd-minimal one into a single one to make a self-contained
patch.
I’ve then reviewed it, which led me to simplify a few things, and add a
bunch of FIXMEs, and pushed the result as the ‘wip-hurd’ branch.
Can you please check it out, look at all the FIXMEs, both in the .scm
and .patch files, address them, and post a patch here (no need for a
detailed commit log.)
The FIXMEs are about:
• Things that are probably unneeded: if there are actually unneeded,
please remove them, otherwise add a comment clearly stating why they
are needed.
• Workarounds that lack a justification, have an unclear
justification, and/or lack a link to the relevant mailing list
discussion.
If there is any FIXME that is unclear to you, please do let me know.
There are many workarounds being applied here, so it’s very important to
be rigorous in defining what they’re for so this can be maintained.
Also make sure that the result does not introduce any regressions with
the not-yet-reviewed cross-base.scm patch.
I think we’re on the right track now. :-)
Thanks in advance, and again apologies for the looooong delay!
Ludo’.
next prev parent reply other threads:[~2014-08-29 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 21:16 [PATCH] gnu: base: Add Glibc-Hurd Headers Manolis Ragkousis
2014-08-29 13:48 ` Ludovic Courtès [this message]
2014-09-24 13:01 ` Manolis Ragkousis
2014-09-27 9:31 ` Ludovic Courtès
2014-09-27 13:50 ` Manolis Ragkousis
2014-09-27 17:30 ` Manolis Ragkousis
2014-09-28 9:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761hbcspb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.