From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add nvi
Date: Tue, 02 Sep 2014 10:19:52 +0200
Message-ID: <8761h6sac7.fsf@gnu.org>
References: <54047591.9080902@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48942)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XOjJo-0001Ds-DU
	for guix-devel@gnu.org; Tue, 02 Sep 2014 04:20:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XOjJj-0001vZ-Oh
	for guix-devel@gnu.org; Tue, 02 Sep 2014 04:20:00 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:55217)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XOjJj-0001tM-HI
	for guix-devel@gnu.org; Tue, 02 Sep 2014 04:19:55 -0400
In-Reply-To: <54047591.9080902@gmail.com> (Marek Benc's message of "Mon, 01
	Sep 2014 15:33:05 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Marek Benc <merkur32@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Hi!

Marek Benc <merkur32@gmail.com> skribis:

> Disregard my previous email, I figured it out.

OK, perfect.  :-)

> Here is my favorite text editor. This is my first package, so I'm
> sorry if I messed up somewhere.
> The formatting is probably bad, but every package seemed to be
> formatted slightly differently, so I don't know.

Formatting looks good.  I=E2=80=99m just reporting a few minor issues below.

Could you send an updated patch in the format produced by =E2=80=98git
format-patch=E2=80=99, and with a ChangeLog-style commit log?  See =E2=80=
=9CSubmitting
Patches=E2=80=9D in the =E2=80=98HACKING=E2=80=99 file for details.

> +        (uri
> +          (string-append "http://harrier.slackbuilds.org/misc/nvi-" vers=
ion
> +                         ".tar.bz2"))

Shouldn=E2=80=99t it be
https://sites.google.com/a/bostic.com/keithbostic/files/... ?  (This is
the URL given on the home page.)

> +    (arguments
> +      `(#:out-of-source? '(#t)))

Just:

  `(#:out-of-source? #t)

> +    (license bsd-3)))

This is actually bsd-4 (see its =E2=80=98LICENSE=E2=80=99 file: it has the =
four clauses,
as shown at <http://directory.fsf.org/wiki/License:BSD_4Clause>.)

> --- a/gnu/packages/patches/nvi-assume-preserve-path.patch 2014-09-01
> 15:22:45.219850258 +0200
> +++ b/gnu/packages/patches/nvi-assume-preserve-path.patch 2014-09-01
> 15:03:50.395813104 +0200
> @@ -0,0 +1,28 @@
> +--- a/dist/configure    2014-09-01 14:46:01.075778095 +0200
> ++++ b/dist/configure    2014-09-01 14:52:08.411790122 +0200

Please add a sentence or two at the beginning of the file saying what it
does and why.  (You can remove the comment above =E2=80=98search-patch=E2=
=80=99 in
nvi.scm.)

Thanks!

Ludo=E2=80=99.