Re: [PATCH] Add nvi

[ludo@gnu.org (Ludovic Courtès)]

Hi!

Marek Benc <merkur32@gmail.com> skribis:

> Disregard my previous email, I figured it out.

OK, perfect.  :-)

> Here is my favorite text editor. This is my first package, so I'm
> sorry if I messed up somewhere.
> The formatting is probably bad, but every package seemed to be
> formatted slightly differently, so I don't know.

Formatting looks good.  I’m just reporting a few minor issues below.

Could you send an updated patch in the format produced by ‘git
format-patch’, and with a ChangeLog-style commit log?  See “Submitting
Patches” in the ‘HACKING’ file for details.

> +        (uri
> +          (string-append "http://harrier.slackbuilds.org/misc/nvi-" version
> +                         ".tar.bz2"))

Shouldn’t it be
https://sites.google.com/a/bostic.com/keithbostic/files/... ?  (This is
the URL given on the home page.)

> +    (arguments
> +      `(#:out-of-source? '(#t)))

Just:

  `(#:out-of-source? #t)

> +    (license bsd-3)))

This is actually bsd-4 (see its ‘LICENSE’ file: it has the four clauses,
as shown at <http://directory.fsf.org/wiki/License:BSD_4Clause>.)

> --- a/gnu/packages/patches/nvi-assume-preserve-path.patch 2014-09-01
> 15:22:45.219850258 +0200
> +++ b/gnu/packages/patches/nvi-assume-preserve-path.patch 2014-09-01
> 15:03:50.395813104 +0200
> @@ -0,0 +1,28 @@
> +--- a/dist/configure    2014-09-01 14:46:01.075778095 +0200
> ++++ b/dist/configure    2014-09-01 14:52:08.411790122 +0200

Please add a sentence or two at the beginning of the file saying what it
does and why.  (You can remove the comment above ‘search-patch’ in
nvi.scm.)

Thanks!

Ludo’.