From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: librsvg: Generate complete loaders.cache
	including support for SVG.
Date: Mon, 03 Nov 2014 23:07:53 +0100
Message-ID: <8761ew9buu.fsf@gnu.org>
References: <CAKrPhPMbQEV4JdngNDTGBmSjsEG7TsFseb+eJ1YxNyB=pvaSJw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43490)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XlPmk-0003uj-8N
	for guix-devel@gnu.org; Mon, 03 Nov 2014 17:07:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XlPmf-0000QE-Gm
	for guix-devel@gnu.org; Mon, 03 Nov 2014 17:07:38 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:45851)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XlPmf-0000Q8-9X
	for guix-devel@gnu.org; Mon, 03 Nov 2014 17:07:33 -0500
In-Reply-To: <CAKrPhPMbQEV4JdngNDTGBmSjsEG7TsFseb+eJ1YxNyB=pvaSJw@mail.gmail.com>
	(Federico Beffa's message of "Sun, 2 Nov 2014 18:18:33 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> As mentioned in a previous email, the cache generated by default does
> not include support for SVG provided by librsvg itself.  With this
> patch we generate a full cache file.

Nice.

> From 36c6d59180bdb2d80e169938097efca39431c122 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 2 Nov 2014 18:01:08 +0100
> Subject: [PATCH 1/2] gnu: librsvg: Generate complete loaders.cache includ=
ing
>  support for SVG.
>
> * gnu/packages/gnome.scm (librsvg): Add 'generate-full-chage phase.
                                                         ^^^^^^
Typo.

> +             (system=20
> +              (string-append=20
> +               "gdk-pixbuf-query-loaders "=20
> +               loaders-directory "/libpixbufloader-svg.so "
> +               (fold (lambda (s p) (string-append s " " p))  ""=20
> +                     (find-files (assoc-ref inputs "gdk-pixbuf")=20
> +                                 "libpixbufloader-.*\\.so"))
> +               "> " loaders-directory ".cache")))))

It may be clearer to replace fold with =E2=80=98string-join=E2=80=99

  (string-join (find-files ...))

... in which case the import of (srfi srfi-1) can also be removed.

OK to commit with these changes.

Thanks,
Ludo=E2=80=99.